From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E74FC433DB for ; Mon, 15 Mar 2021 15:05:37 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E495064DDF for ; Mon, 15 Mar 2021 15:05:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E495064DDF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cerno.tech Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=VUC4/QwizgI765c1qDPlbPhb97wF0/587t47pJyjH/k=; b=lsHLIBy42r5NA+eEeCuEIEbJh h4In6niTBGh+8lvaJb0NnZ6ZRb6L+D69YUzIEjGpNYk3VpDIa7GNZ7/8gU1xxOarXdsAdmFMo5uQ9 dBQfG098FBRdeThlrHAhlA9++HTAHQLGwQAH6lNRSdAU8KWABTQwcVf+iHZ//KqszDWZBBPN/+ozN qxcNBT05zgYxIe+ptdbZLffIuuId94e8KC0tLjzp8l7uRmg4mLreX54ZLw3GJ1ZqbK9hCZTWiYv9x v905a2Cs+ADabF9rr8I711R9aMuzEpYXgkLT7fhH90PtMoO0J6WJYyPPXm2MdFR+CVktZVkWaSY9p wqaEHi7wA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lLolH-00GEoE-Gl; Mon, 15 Mar 2021 15:04:03 +0000 Received: from wout4-smtp.messagingengine.com ([64.147.123.20]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lLol5-00GElP-Nt for linux-arm-kernel@lists.infradead.org; Mon, 15 Mar 2021 15:03:56 +0000 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 373C02385; Mon, 15 Mar 2021 11:03:47 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 15 Mar 2021 11:03:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=imv4IetqNlL67VMIjffr1KT6NlK C85EkumX2HdaLpqQ=; b=iLddbCBnHq2pKqGeEzFQaj68uwOm2kDuuedkz6fwWrI xlFIpqIOgF/E4HeeYiKmLuOYqW5rx22rHwX1kgRYKGZ3gXMTnopODCXuse6Jr+Sa MnOYMwl9NkAdmOwl5j8NqDLqgbwhAnJJId+cEOxeJjGAZrjyMzQSYO/L+apAOLV9 OUnOEoTroWFxEBjY6fpYmcnucwM1tCNljN9ttUcZaGkes+32f5pO5C+VojfA66V4 98uebtcO20452m+kM3xcbpYIHlnzXLqA0d2LVsHpw43aKXIGyDwAfCqKKC548Fuj 1lVE4PQO3aLGpO7juduPMA0gwCq4WN8q6BuQGfMod+A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=imv4Ie tqNlL67VMIjffr1KT6NlKC85EkumX2HdaLpqQ=; b=D7oG4rMpBZSgdfyypVnnrU Um7i+BemRlI+fPRMioITdWTfqeBDICwVebIXIyswa0xRiA0KuVkdm+FMhq+5OFVJ We//tLopWcv1IIq+DTKApUO9bAXiOMyh2CQgQKlsd0zjH1sDYSlLnKENGAK3OUP/ 1gceNs4qel8JsQba72pO5/rhh+h3e62nCxqAz4crJymg5LgAQs1cqCkL25hlcfpz I5jfpMFN5XAIgrsnz/RF/zbezkQZ7Vv7sh81a4iaL/Q+oN8dDQu1Hrtexve5TAn0 q2SEFGfBKyqeroJjx/QIX4V56jSS1W+Ln2i+Rkz2bN1unVpftrXeGQxAqNRe6bVg == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledruddvledgjeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpeforgigihhm vgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrfgrth htvghrnhepuedtgfejueduheevgfevvdettdduleffgfffkeeltdffkeegudekjeeuveei gedunecukfhppeeltddrkeelrdeikedrjeeinecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepmhgrgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Received: from localhost (lfbn-tou-1-1502-76.w90-89.abo.wanadoo.fr [90.89.68.76]) by mail.messagingengine.com (Postfix) with ESMTPA id 9F9EB1080063; Mon, 15 Mar 2021 11:03:45 -0400 (EDT) Date: Mon, 15 Mar 2021 16:03:43 +0100 From: Maxime Ripard To: Jernej =?utf-8?Q?=C5=A0krabec?= Cc: wens@csie.org, robh+dt@kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com Subject: Re: [PATCH] ARM: dts: sun8i: h3: beelink-x2: Add power button Message-ID: <20210315150343.uzq46th6eecdr4e2@gilmour> References: <20210306203611.15534-1-jernej.skrabec@siol.net> <20210308130506.v35gjviwknr5hat5@gilmour> <2517400.0zBCEEo8qi@kista> MIME-Version: 1.0 In-Reply-To: <2517400.0zBCEEo8qi@kista> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210315_150352_224931_618D92B3 X-CRM114-Status: GOOD ( 21.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============1359665905285430126==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============1359665905285430126== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="mfhruzbnsooaoye6" Content-Disposition: inline --mfhruzbnsooaoye6 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Thu, Mar 11, 2021 at 10:59:35PM +0100, Jernej =C5=A0krabec wrote: > Hi! >=20 > Dne ponedeljek, 08. marec 2021 ob 14:05:06 CET je Maxime Ripard napisal(a= ): > > Hi > >=20 > > On Sat, Mar 06, 2021 at 09:36:11PM +0100, Jernej Skrabec wrote: > > > Beelink X2 has power button. Add node for it. > > >=20 > > > Signed-off-by: Jernej Skrabec > > > --- > > > arch/arm/boot/dts/sun8i-h3-beelink-x2.dts | 11 +++++++++++ > > > 1 file changed, 11 insertions(+) > > >=20 > > > diff --git a/arch/arm/boot/dts/sun8i-h3-beelink-x2.dts b/arch/arm/boo= t/dts/ > sun8i-h3-beelink-x2.dts > > > index 62b5280ec093..4a2cb072ecf6 100644 > > > --- a/arch/arm/boot/dts/sun8i-h3-beelink-x2.dts > > > +++ b/arch/arm/boot/dts/sun8i-h3-beelink-x2.dts > > > @@ -111,6 +111,17 @@ spdif_out: spdif-out { > > > #sound-dai-cells =3D <0>; > > > compatible =3D "linux,spdif-dit"; > > > }; > > > + > > > + r_gpio_keys { > >=20 > > Underscores are not valid for node names (and will trigger a dtc warning > > when running with W=3D1). >=20 > Unless I'm doing something wrong, I didn't get any warning with "make dtb= s=20 > W=3D1". In fact many H3 boards have a node with this name and not a singl= e=20 > warning is produced with this command for underscores (there are other=20 > warnings though). It looks like I've been remembering it wrong, and it's actually W=3D2 that reports it, but it's here nonetheless :) Maxime --mfhruzbnsooaoye6 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYE93TwAKCRDj7w1vZxhR xYexAQDb6dkfEktXz1olTmB8ij8tEMvdw1+q+P4jn663TrYYlAEAwOCcYZI9M/W4 PYGJSL4AaL7FgNeesPXOs7AB7A0KygU= =znPS -----END PGP SIGNATURE----- --mfhruzbnsooaoye6-- --===============1359665905285430126== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============1359665905285430126==--