From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5B72C43381 for ; Tue, 16 Mar 2021 04:01:04 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 60955650DA for ; Tue, 16 Mar 2021 04:01:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 60955650DA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ml3VzMtTceNIGOKbOxGe04D/mx8DkwnSiQUhQjjvb0U=; b=pGKLJmMRfxWD0e9DAEBKIuG85 z1C5p9wGxXkOgpxwiOQEvuRha4PVLJX2/EvMhyVgqnQRr6kOLNKYypmeFhtRoy4y7cpTszDphOA5X J/NG9m8//SlU4hZaug4QcpBmz2q8Cb4s5wa+RrKL/2Zat0CuXeLO6YzuwZXir7V8oqKomWYiK5oIn QVq2blYC9XUrabU/oNDqSOAZJClAcBHiSAk+GYJVI6rzYbrQ3wv3o16J0HwvlP/3WU4K2bOzuqk5t YGl3hLwuLPM4OFyShuU3i5cyRCqh5i0rA2AjhipC+XDFf6G/5VDizW/jOZxwxcbwB5QbhXI5WFZwx 0+YmFtyCA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lM0rC-00HMj1-LM; Tue, 16 Mar 2021 03:58:58 +0000 Received: from mail-pj1-x102d.google.com ([2607:f8b0:4864:20::102d]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lM0r7-00HMiI-KV for linux-arm-kernel@lists.infradead.org; Tue, 16 Mar 2021 03:58:55 +0000 Received: by mail-pj1-x102d.google.com with SMTP id j6-20020a17090adc86b02900cbfe6f2c96so718088pjv.1 for ; Mon, 15 Mar 2021 20:58:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=SzXlqLikayDej+9/WrhYQCMKO1vcITmBgVXKNGZ0bAs=; b=zcIUpwKXaw9vakDsmOY9jbUuRQ9QiW/B6ZxkuPPh2Eher8WapBraPgcs5LoltOkLW4 BebV6XUdvP/TgwEvBa8gAnNPBZlbuEix1nkjEArrgf/1Ng6AmP/QlVvJmiVQLgJYusDv CXLGEyNnOe20cykU0evYfKl0rXta3czGG+CFuAlACZ2eEmIZ+wNmi1TmmpbMfDmUPavC UpSORVz/6EtbSEPiWRTP6y8/stOdTxIkpAubJpLiAkRk+91BZzqT/ZJmKTB4dBO+b7TV WAm2G9hUV5wRkVuybbIljyn4Uoby4whwfDRfaY2weFzfUi+novhxqpkGxKWvy8zVIHLF aNGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=SzXlqLikayDej+9/WrhYQCMKO1vcITmBgVXKNGZ0bAs=; b=c3nV0I1KoyLf9/GjxZiBe01xkqYNYCcWlnNNmhtUYh+6PRNdwUYU8HM0/e6obT3HmV 0WyN2fU0wBaM8h1uMcixWuycPAnasdvRTQ4nrv5uyNGzTtFM4mRq7cuX0Ms6rKcnNP4P ma3yBgzO0AzyOnw6ye/HhHHqPZucR4nPjI7OYLVDeT3IINzdTYaZYKfOBO34yR8zVjwu F0LtY0Ax5NlblT15xX9Z9sb4qEm1QYpi569l1lM4xGEYHmbrDP3oCefQYMFCGSUjwPe8 8a6PYaH6SJEVLoRchISp6ggQlBbijXgsLFNmb0005BUqvYOIN8MuFErkQVCQ15SUbgjp Kv1w== X-Gm-Message-State: AOAM532o0hNVmfRUHhCdUDQYVL4GJswCD7vpVPavgdG2dnlGAFpE7LYm DOUUFxMAf5depJn1pBEJoFnr X-Google-Smtp-Source: ABdhPJwiP6/+R4rhjKOCBg0O/VVBWzkj9vXCgcnKPWE/zir8dyBqI1gn3LPSdppyytdItwMFhZsZaQ== X-Received: by 2002:a17:902:e906:b029:e5:c6d2:7dd0 with SMTP id k6-20020a170902e906b02900e5c6d27dd0mr14963791pld.12.1615867132156; Mon, 15 Mar 2021 20:58:52 -0700 (PDT) Received: from thinkpad ([103.66.79.72]) by smtp.gmail.com with ESMTPSA id g21sm1085109pjl.28.2021.03.15.20.58.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Mar 2021 20:58:51 -0700 (PDT) Date: Tue, 16 Mar 2021 09:28:45 +0530 From: Manivannan Sadhasivam To: Cristian Ciocaltea Cc: Stephen Boyd , Rob Herring , Andreas =?iso-8859-1?Q?F=E4rber?= , Michael Turquette , Edgar Bernardi Righi , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-actions@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH 2/6] clk: actions: Fix SD clocks factor table on Owl S500 SoC Message-ID: <20210316035845.GB1798@thinkpad> References: <973b08fe414321ba4ade096a4917cadc2013426e.1615221459.git.cristian.ciocaltea@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <973b08fe414321ba4ade096a4917cadc2013426e.1615221459.git.cristian.ciocaltea@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210316_035853_933218_91C45C9F X-CRM114-Status: GOOD ( 17.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Mar 08, 2021 at 07:18:27PM +0200, Cristian Ciocaltea wrote: > Drop the unsupported entries in the factor table used for the SD[0-2] > clocks definitions on the Actions Semi Owl S500 SoC. > > Fixes: ed6b4795ece4 ("clk: actions: Add clock driver for S500 SoC") > Signed-off-by: Cristian Ciocaltea > --- > drivers/clk/actions/owl-s500.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/clk/actions/owl-s500.c b/drivers/clk/actions/owl-s500.c > index 75b7186185b0..69cd959205f5 100644 > --- a/drivers/clk/actions/owl-s500.c > +++ b/drivers/clk/actions/owl-s500.c > @@ -127,8 +127,6 @@ static struct clk_factor_table sd_factor_table[] = { > { 12, 1, 13 }, { 13, 1, 14 }, { 14, 1, 15 }, { 15, 1, 16 }, > { 16, 1, 17 }, { 17, 1, 18 }, { 18, 1, 19 }, { 19, 1, 20 }, > { 20, 1, 21 }, { 21, 1, 22 }, { 22, 1, 23 }, { 23, 1, 24 }, > - { 24, 1, 25 }, { 25, 1, 26 }, { 26, 1, 27 }, { 27, 1, 28 }, > - { 28, 1, 29 }, { 29, 1, 30 }, { 30, 1, 31 }, { 31, 1, 32 }, How did you determine that these values are not supported? I've seen cases where the datasheet has the incomplete information about the supported ranges but the downstream driver has everything. Thanks, Mani > > /* bit8: /128 */ > { 256, 1, 1 * 128 }, { 257, 1, 2 * 128 }, { 258, 1, 3 * 128 }, { 259, 1, 4 * 128 }, > @@ -137,8 +135,6 @@ static struct clk_factor_table sd_factor_table[] = { > { 268, 1, 13 * 128 }, { 269, 1, 14 * 128 }, { 270, 1, 15 * 128 }, { 271, 1, 16 * 128 }, > { 272, 1, 17 * 128 }, { 273, 1, 18 * 128 }, { 274, 1, 19 * 128 }, { 275, 1, 20 * 128 }, > { 276, 1, 21 * 128 }, { 277, 1, 22 * 128 }, { 278, 1, 23 * 128 }, { 279, 1, 24 * 128 }, > - { 280, 1, 25 * 128 }, { 281, 1, 26 * 128 }, { 282, 1, 27 * 128 }, { 283, 1, 28 * 128 }, > - { 284, 1, 29 * 128 }, { 285, 1, 30 * 128 }, { 286, 1, 31 * 128 }, { 287, 1, 32 * 128 }, > { 0, 0, 0 }, > }; > > -- > 2.30.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel