From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A28AFC433E0 for ; Tue, 16 Mar 2021 23:04:31 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 32B9864F4F for ; Tue, 16 Mar 2021 23:04:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 32B9864F4F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Ajlt8+4fy3K4KClneg3RbDkTzSctTH6lYsptqFbGxWc=; b=ZrwTp5A7SVNg0YTyc/dGGGbzV yDiRbssnXoGgNPVOJJC8JtohrKoizN7tviBhMXJ7ldM9qGfsBI3r+f4z5H+l7Bwwfh9oO1SLXd0A7 Z4oaJVA2a16oQEQzuLJaomL1mFibPKp2AiiSCjawV8HrzjcM4+Ql/qbKsBs72w30rYROtzp6vqDmU 9yqXA8ZxiSdIVlWZNbNi4xepJEW+pfD0rVm7ER6aHw5o2vKMJzKazA3ItNM9WGKweA4zY0XpVrfVj yIEqVP4boaDWNQCVDjP+arLgQOYLrzIC/y6I3jJFmHtYqVF9Rg+gBLydduYNGNXejNbCLPRQV7COB 8AQahg4qQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lMIiO-0020kt-3y; Tue, 16 Mar 2021 23:03:04 +0000 Received: from mail-pf1-x431.google.com ([2607:f8b0:4864:20::431]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lMIiI-0020kL-UA for linux-arm-kernel@lists.infradead.org; Tue, 16 Mar 2021 23:03:00 +0000 Received: by mail-pf1-x431.google.com with SMTP id t85so9828354pfc.13 for ; Tue, 16 Mar 2021 16:02:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=kXkZPUcTv+BH4LFKsPIbe+jirsdRWJGrIqCSnte4+pk=; b=n7z/7n8BAe+C7mTkXJHeaNKkrmAd3FDbaONpZvyNMxkhbVT0HhlGCasczqYzg9skM7 qBBK04FrNjFr5vEVg8tejTGS6nhlakf8ACj8v81qEm6NbXbdnWSH6RNFIfGot//y7tiV m7X88W7uUbP5jCvFAuxcc3DEyOCGAo9oImDDk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=kXkZPUcTv+BH4LFKsPIbe+jirsdRWJGrIqCSnte4+pk=; b=IKMsTC+JrkPYpuY+TMCLxuvTg8zySA6pza3NQ3f+QeXV4a4RUdJ0j9iJE/mbuAiQQ0 a861ceR3gHtdHXLgsUnUFBe5G5Y3rCFklpc0RVeyUk4FYDeXoU+VjPY9+CCwApSP+azL 3IwbS7VwIIs/5xLwPIWhDfmjUw7yYsQ6AWIcM11+ge60pmzNbycYrjbcBGBsZ2yDifV/ 8SLkPXg1wJPCIun7oNHHqgvgvbQanJhK1PhcA5NUJRRPfXoC/f2mFF+bFzQJFziTnO34 ENUCNfWaIm8miKumdAZO9NyDbBpFMtDMfyMN4FdB6iLfbSFGWCjMf1gvl3RS88WwXhpO jbUw== X-Gm-Message-State: AOAM5302vZswN3NUZMQ0AeFsGLcP09voDEXz2jrEA5h0T0oFQA4yY+9c tDfnDDhmafiYvSSA2Ztx+nYUlg== X-Google-Smtp-Source: ABdhPJxUsDSC7HTflCNgrlhXH8m0bkwMud4JF2D4um9D+38w6bFYcJnCSdxm5YlWmyN87vHVWtDfEA== X-Received: by 2002:a63:4652:: with SMTP id v18mr42886pgk.87.1615935775940; Tue, 16 Mar 2021 16:02:55 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id mp1sm372749pjb.48.2021.03.16.16.02.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Mar 2021 16:02:54 -0700 (PDT) Date: Tue, 16 Mar 2021 16:02:53 -0700 From: Kees Cook To: Sami Tolvanen Cc: Nathan Chancellor , Nick Desaulniers , Masahiro Yamada , Will Deacon , Jessica Yu , Arnd Bergmann , Tejun Heo , bpf@vger.kernel.org, linux-hardening@vger.kernel.org, linux-arch , linux-arm-kernel , linux-kbuild , PCI , LKML Subject: Re: [PATCH 17/17] arm64: allow CONFIG_CFI_CLANG to be selected Message-ID: <202103161602.6DB8AC31FA@keescook> References: <20210312004919.669614-1-samitolvanen@google.com> <20210312004919.669614-18-samitolvanen@google.com> <202103111851.69AA6E59@keescook> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210316_230259_202932_5015ED8C X-CRM114-Status: GOOD ( 12.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Mar 16, 2021 at 01:44:33PM -0700, Sami Tolvanen wrote: > On Thu, Mar 11, 2021 at 6:51 PM Kees Cook wrote: > > > > On Thu, Mar 11, 2021 at 04:49:19PM -0800, Sami Tolvanen wrote: > > > Select ARCH_SUPPORTS_CFI_CLANG to allow CFI to be enabled. > > > > > > Signed-off-by: Sami Tolvanen > > > > Reviewed-by: Kees Cook > > > > Random thought: the vDSO doesn't need special handling because it > > doesn't make any indirect calls, yes? > > That might be true, but we also filter out CC_FLAGS_LTO for the vDSO, > which disables CFI as well. Oh right! That would do it. :) -- Kees Cook _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel