From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB6D4C433DB for ; Tue, 16 Mar 2021 16:34:28 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 485A065107 for ; Tue, 16 Mar 2021 16:34:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 485A065107 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=3Fz6eGQFFpXzEDz7990uT71yE+/riP2tuiCCEG2ikeY=; b=C4YOJ/zwHSG9G5yR2q0FMjYcT FCypSuQ9lwrLwDsMGR8iMbAMMDVVZKJK4eOHvfXZODhlm2rlAj6XQltzDYNOZj//J7t6akQXmbV6x OgHifwM2dZZuqVE03mm0QeWVI5vG3MrXay6g5moT5yDl85gGr4482RYeTP7yqyHDrk904mhjeG/15 ti0aVFAYYD0vmF9dfaZz03aJqRRwK91KVjYSAe6xtMHUeWd5bTdAKobyPdkJ/GeOJ+CeffpwE+8oy fbuzQIWpFpUFtXGKL2Npx/xjBs5MA+ZYj3z6JX7aieqvf2hU4So4KKrYXG/2OEeY5yroTjVhUBrkG pFPK4Uwpw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lMCcn-001FFb-Ui; Tue, 16 Mar 2021 16:32:54 +0000 Received: from mail-ed1-x52d.google.com ([2a00:1450:4864:20::52d]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lMCce-001FEo-Tf; Tue, 16 Mar 2021 16:32:46 +0000 Received: by mail-ed1-x52d.google.com with SMTP id h13so22285200eds.5; Tue, 16 Mar 2021 09:32:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=DjTxZT8AqroYP99shdWO695KE0Qo/izOf7I5S4PGebY=; b=eMHU0ZgB9iZLTIKhDQsi86LqQoF4n2XUMbJKievcKjSFjzL5haEqigr0DZHElui9cB 5JaBQP2aW1BvQL6g0yEV7mrfwR+Vp7rFSaGia5lBvayHQr7Zs3azVbbMhDEzUH9imeVI svVLaHn8Rho/uRN/hE3RUXfJKLnCIDpcM+RsWJ7Mcb1rnoSmXDRESN1Qx93D2vyFFN98 iHw+/g5pMjm8PHSC6Yri7oG4q+Mg/SJLFWe5P+V8PFAAh1JUIgr2I3WMw8tmS/N1sdLK aihwSsUuCs33DfjsEd7yyGVm7LLVF8qXDDHxs97MiAU/mGbzk/qVvtFmiKbO+XXmUXzX 7X0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=DjTxZT8AqroYP99shdWO695KE0Qo/izOf7I5S4PGebY=; b=Rtkd3LKDA+7hrPmyY9WcyATLlX9EgS8tGA69JGMPRBq/i5E3zHRNMX4b3/NF8u6FO7 poGFe8quHIlNRjilTphbAVQ7wggyh24iTcoleLkHPmp7v4jBIXHAYF26AZKgPamRTgUZ eiYwfiQnPZ/y+cycVnIsU6mANcReRVDJ/+ovTZWvykqfkijP682HIypMOvlDJDrEeEfl esQDd9HD4dWa+Vh3a/ZW5Wn3Q4ICSWWnf6tX+emLLchGxgRhNFpcMfqizZylnXA8Y8Va 8d444EJ8T2SkdME3OHGgs5C4sep+lomLNzrYR1ptOnlTy/OfwmV8pdjckKD+/eNsBeOD /bTQ== X-Gm-Message-State: AOAM530x6oIpNmiR1JrtHDNO8IBMdUIcbYPzv6Cgp8+tG8BNcVz+YHZT sYRcAULhiW1I5nhhdoS4lrk= X-Google-Smtp-Source: ABdhPJxtZ4WnHx3NTNAcSmsmTV5p7JCQe4MelLjCfJBcuTeGIGE21s7wKJhvqqqetIqjzZvaCHLdvQ== X-Received: by 2002:a05:6402:4309:: with SMTP id m9mr38266598edc.25.1615912363716; Tue, 16 Mar 2021 09:32:43 -0700 (PDT) Received: from BV030612LT ([188.24.140.160]) by smtp.gmail.com with ESMTPSA id d15sm10818511edx.62.2021.03.16.09.32.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Mar 2021 09:32:43 -0700 (PDT) Date: Tue, 16 Mar 2021 18:32:40 +0200 From: Cristian Ciocaltea To: David Miller Cc: andrew@lunn.ch, kuba@kernel.org, robh+dt@kernel.org, afaerber@suse.de, mani@kernel.org, p.zabel@pengutronix.de, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-actions@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/3] net: ethernet: actions: Add Actions Semi Owl Ethernet MAC driver Message-ID: <20210316163240.GA1111731@BV030612LT> References: <20210315.143933.939938434416308507.davem@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210315.143933.939938434416308507.davem@redhat.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210316_163245_022531_948FAE20 X-CRM114-Status: GOOD ( 11.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Mar 15, 2021 at 02:39:33PM -0700, David Miller wrote: > From: Cristian Ciocaltea > Date: Mon, 15 Mar 2021 13:29:17 +0200 > > > + > > +#define DEFAULT_MSG_ENABLE (NETIF_MSG_DRV | NETIF_MSG_PROBE | NETIF_MSG_LINK) > > +static int debug = -1; > > +module_param(debug, int, 0); > > +MODULE_PARM_DESC(debug, "Debug level (0=none,...,16=all)"); > > Module parameters are strongly discouraged in networking drivers, pplease delete this > ad just pass the default to netif_mdg_init(), thanks! Ups, I was not aware of this since I've seen it in quite a lot of drivers. Thanks for pointing this out, I will take care of it in the next revision. Kind regards, Cristi _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel