From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D0F9C433DB for ; Tue, 16 Mar 2021 18:51:49 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2F1A86511A for ; Tue, 16 Mar 2021 18:51:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2F1A86511A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=DCGmX+SInmtyCIT6jbxA7MDLStKqBSifCl3hXiN7BGs=; b=W3gF+5kFkxXMaF/QDzh28Gn1B 7x/GYg40YbxR3Kv2JOdSzs6KXDsbGLCWJeGTU93rOjeLOjKY01Lo9oV2VNdzVaH9Ygm0s57kSNc05 VMNILY97N4iLjjHjWiIUTDCsqdpSCr8OCW0sFOI1hhr8hqUrfXvEKfDGl/p+m5B2bmHtZHhf8W3pO b6e4NDw3kwBa+/SyPKIJYkzsu6uDFuUPRVHbCd/I8W+8alRzPE19yDuqQV3u++EZawR6lubI/+jl8 ZHw5/GkVGTEGuA3aMgnYerEBmPrfB85j0O7YUiexILCaq/tL+WwA+OmWvYXN6VHAjzfnO0wENTLP4 HFWfXRRAA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lMElq-001f5j-S3; Tue, 16 Mar 2021 18:50:23 +0000 Received: from mail-ej1-x62b.google.com ([2a00:1450:4864:20::62b]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lMElm-001f51-2w; Tue, 16 Mar 2021 18:50:19 +0000 Received: by mail-ej1-x62b.google.com with SMTP id mm21so73860000ejb.12; Tue, 16 Mar 2021 11:50:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=JIDWJVCtqVTctPuvCcddfFP45PGJhsx7ii6usu9k8kI=; b=r0s92RsLYdx+MT4mzPcDqJIf7njkm7DryrHjr8C8yN5Nr2/DxAd9tzVM6Jg3fk9oEw oNP1xa32uW7a0zKLb+owgbLGCrngGZEwU/Oh+NCtn7hAql3tC9s0tB83soABU5Labjq1 OrhZMwqvQSyvCUf79h+gGK+gU3G/bFpmqydafAKuhe/JE1kA02SZnK5a0bFK1Biy9AXt JDanZJmKzPrrIOxMTO2ncU0mpXFFkdl1tBgtSLnqu2sUQlfd+F5tY2taf2WawqIXysGN 0A64WFshUOge4vG/+68k1ODWKayXFi6kBuvM0lY13AFuuhLjcqkGVSThBMD8f4eC9fat X1Eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=JIDWJVCtqVTctPuvCcddfFP45PGJhsx7ii6usu9k8kI=; b=Q1wr8gIVfOwsq72hT1zztU2tC1+Ftx2VbcESna8PcDxoFpbUb5buivvlpHRbLoumSN xgJo6uHl+ZLX/GxWHKuyYNNKSlXmizfOM6GJCXe3gUc4mjco5xYO62XiuntVLEa9y4gq GvDVwf3nLgUibmq/Wttlga0GTWvmny339xRJPiIue3S8f2NcLOXIAKbQkzHqGC+455Ow k9TJ6nab1dnC5B/jVU6fFEfcywR7MjYm/5moZ+YoWZu5QuP1A6yeTKqCiKE9TnF2LTHM nXrIZEHjyFzNCvayRuuQpZ5vp5Iwh3KwTcq2M8wgrL+WdAmAbDBfgdoDe8OwGyFv4fb0 49Fw== X-Gm-Message-State: AOAM530+vP6LAkB5LtGSFWxVL228R2hmummLE1yxQjK1uuekSyOgZbAl 5H4XPHzN9zJ6RVr2RzXAHHw= X-Google-Smtp-Source: ABdhPJxcsp8sHhglDnHjuUw4lQyDPqrEFmSQ6145fz7Iaf0s+0BRl7H7zTp9dHnVJ8Gik7sBF16ulw== X-Received: by 2002:a17:906:6c93:: with SMTP id s19mr30978725ejr.151.1615920617571; Tue, 16 Mar 2021 11:50:17 -0700 (PDT) Received: from BV030612LT ([188.24.140.160]) by smtp.gmail.com with ESMTPSA id y20sm2023626ejj.43.2021.03.16.11.50.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Mar 2021 11:50:16 -0700 (PDT) Date: Tue, 16 Mar 2021 20:50:14 +0200 From: Cristian Ciocaltea To: Manivannan Sadhasivam Cc: Stephen Boyd , Rob Herring , Andreas =?iso-8859-1?Q?F=E4rber?= , Michael Turquette , Edgar Bernardi Righi , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-actions@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH 4/6] clk: actions: Fix AHPPREDIV-H-AHB clock chain on Owl S500 SoC Message-ID: <20210316185014.GD1111731@BV030612LT> References: <58225ced4893018792d581c0476a0f1c70e08907.1615221459.git.cristian.ciocaltea@gmail.com> <20210316054547.GD1798@thinkpad> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210316054547.GD1798@thinkpad> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210316_185018_299788_7F4C1BAD X-CRM114-Status: GOOD ( 16.21 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Mar 16, 2021 at 11:15:47AM +0530, Manivannan Sadhasivam wrote: > On Mon, Mar 08, 2021 at 07:18:29PM +0200, Cristian Ciocaltea wrote: > > There are a few issues with the setup of the Actions Semi Owl S500 SoC's > > clock chain involving AHPPREDIV, H and AHB clocks: > > > > * AHBPREDIV clock is defined as a muxer only, although it also acts as > > a divider. > > * H clock is defined as a standard divider, although the raw value zero > > is not supported. > > What do you mean by not supported? The datasheet lists "0" as the valid divisor > value for divide by 1. Unfortunately CMU_BUSCLK1 is not documented in my S500 Datasheet (Version: 1.6, 2016-03-07). Do you have a newer (or a more official) one? The reference xapp-le code snipped is: static struct owl_div divider_H_CLK = { .type = DIV_T_NATURE, .range_from = 1, /* reserve H_CLK divsor 1 */ .range_to = 3, .reg = &divbit_H_CLK, }; Not sure why divisor 1 has been reserved.. Thanks, Cristi > Rest looks good to me. > > Thanks, > Mani > [...] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel