Re: [PATCH v5 03/10] coresight: config: Add configuration and feature generic functions

From: kernel test robot <lkp@intel.com>
To: Mike Leach <mike.leach@linaro.org>,
	linux-arm-kernel@lists.infradead.org, coresight@lists.linaro.org,
	mathieu.poirier@linaro.org, linux-doc@vger.kernel.org,
	suzuki.poulose@arm.com
Cc: kbuild-all@lists.01.org, yabinc@google.com, corbet@lwn.net,
	leo.yan@linaro.org, alexander.shishkin@linux.intel.com,
	tingwei@codeaurora.org
Subject: Re: [PATCH v5 03/10] coresight: config: Add configuration and feature generic functions
Date: Wed, 17 Mar 2021 08:07:16 +0800	[thread overview]
Message-ID: <202103170825.WIqbSlhX-lkp@intel.com> (raw)
In-Reply-To: <20210316180400.7184-4-mike.leach@linaro.org>

[-- Attachment #1: Type: text/plain, Size: 2409 bytes --]

Hi Mike,

I love your patch! Perhaps something to improve:

[auto build test WARNING on lwn/docs-next]
[also build test WARNING on linus/master v5.12-rc3 next-20210316]
[cannot apply to soc/for-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Mike-Leach/CoreSight-configuration-management-ETM-strobing/20210317-021436
base:   git://git.lwn.net/linux-2.6 docs-next
config: arm-randconfig-r035-20210316 (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/265bf2d4b60e95531fb85ec9205c907bccab9c3a
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Mike-Leach/CoreSight-configuration-management-ETM-strobing/20210317-021436
        git checkout 265bf2d4b60e95531fb85ec9205c907bccab9c3a
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/hwtracing/coresight/coresight-config.c:248: warning: wrong kernel-doc identifier on line:
    * Enable configuration for the device.

vim +248 drivers/hwtracing/coresight/coresight-config.c

   246	
   247	/**
 > 248	 * Enable configuration for the device.
   249	 *
   250	 * @config_csdev:	config_csdev to set.
   251	 * @preset:		preset values to use - 0 for default.
   252	 */
   253	int cscfg_csdev_enable_config(struct cscfg_config_csdev *config_csdev, int preset)
   254	{
   255		int err = 0;
   256	
   257		if (preset)
   258			err = cscfg_update_presets(config_csdev, preset);
   259		else
   260			err = cscfg_update_curr_params(config_csdev);
   261		if (!err)
   262			err = cscfg_prog_config(config_csdev, true);
   263		if (!err)
   264			config_csdev->enabled = true;
   265		return err;
   266	}
   267	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 33582 bytes --]

[-- Attachment #3: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel