From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E8F7C433E0 for ; Thu, 18 Mar 2021 10:50:09 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AE64464F3B for ; Thu, 18 Mar 2021 10:50:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AE64464F3B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=6VyE0EFf7iBp7hzL+Qtxb0btRHa+y03bCd7Lziultfk=; b=oSB2imO1UWiKICI/mlvRRPLPi haYZrBmhNfxBUL0rYIHz8aLSrzfSHVE5ev8CLNkuUHu/+NGRalVnqUwQF8Bx6z0VhzmjAN/NUM3kU Adwfwi8DGkKIq0UgP8Eix5akaHm/pr2bURbONMa94Y73g0AKPkPTYC3WMX6qIAj0OYXD2H2wVUt1j UxQWsCxnV5vD+VcXLHAotFXQSck1Nqwe+I/s+f9sBoVO2c563jMXwWWGP8k9OWwY9krih8thAW8rc 6bFOcJdhQuX/q+25CBtJ6ot6JHAA9J5amJwFobiNPYrqYDBt5/EJRswQ0oPILXUtXHd7du5cBrPHX hGjDMbOug==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lMqCZ-00523o-6y; Thu, 18 Mar 2021 10:48:27 +0000 Received: from mail.kernel.org ([198.145.29.99]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lMqCT-00523C-Fk for linux-arm-kernel@lists.infradead.org; Thu, 18 Mar 2021 10:48:23 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 2002564F30; Thu, 18 Mar 2021 10:48:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1616064499; bh=wUjo7pXS0qwNu7qlROg2ZrsNqWJ+naCq27CZFw+tGxU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=obtiLjOk0EJbDJRy146lV/GRO7i2UbA3KHW5om4V5UtomD55RTLbQB1T0kl6l+IZc y+PXnX+UWBZ+ZdFT/FQWieKCNl4AnJP26lYa60Wr0JY2ctc8z2HTyqtN6cH6RZGD2O xBlGhvC4m381d8r1igAax3qQZWdavHiqUr6uzykYgLYCt5wzf27KZXEsQDGIu8rEdZ DgPf1m8/r70mV4Md7VG8tNBITyv6qS8ZykgCZGDGzNtiGdHg7LZrlffbK58bYY4Yh6 nRekfn/A8SJ2EAIVcfZ5TMeaB0O2xKPDwdgfO/rZ1mkbmegX0nn0QUU2WfCN/iKKFv q9xyKl01a0ZGQ== Date: Thu, 18 Mar 2021 18:48:14 +0800 From: Shawn Guo To: Joakim Zhang Cc: robh+dt@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com, kernel@pengutronix.de, linux-imx@nxp.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V1] arm64: dts: imx8mp: fix FEC can't work when attached to generic phy driver Message-ID: <20210318104813.GB22955@dragon> References: <20210304114013.18494-1-qiangqing.zhang@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210304114013.18494-1-qiangqing.zhang@nxp.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210318_104821_934324_E6F9F8E3 X-CRM114-Status: GOOD ( 23.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Mar 04, 2021 at 07:40:13PM +0800, Joakim Zhang wrote: > Some users report that FEC can't work on i.MX8MP EVK board, it brings > inconvenience. The root cause should be FEC controller attached to > generic phy driver, as Realtek phy driver is built as module in the > defconfig file (CONFIG_REALTEK_PHY=m), so it is unavailable. If provide > "reset-gpios" property, it will reset phy when probed, and no way to > re-config phy since we use the generic phy dirver, which leads FEC can't > work. > > There are two ways to let FEC work: > > 1. If you want to use generic phy dirver, please delete "reset-gpios" > property, keep power-on strapping pins configurations. > > 2. If you want to use Realtek phy driver, please buildin driver > (CONFIG_REALTEK_PHY=y), and had better add another two reset > properties: > reset-assert-us = <20000>; > reset-deassert-us = <150000>; > According to RTL8211 serials PHY datasheet, for a complete PHY reset, > reset pin must be asserted low for at least 10ms for internal regulator. > Wait for at least 72ms (for internal circuits settling time) before > accessing the PHY register. > > This patch selects method 1, since users may waste time to find out FEC > failure, in most cases, they just want to use networking to debug other > modules. > > Fixs: commit 9e847693c6f34 ("arm64: dts: freescale: Add i.MX8MP EVK board support") > Signed-off-by: Joakim Zhang > --- > arch/arm64/boot/dts/freescale/imx8mp-evk.dts | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-evk.dts b/arch/arm64/boot/dts/freescale/imx8mp-evk.dts > index 7db4273cc88b..4f5c2fb33eda 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mp-evk.dts > +++ b/arch/arm64/boot/dts/freescale/imx8mp-evk.dts > @@ -97,7 +97,6 @@ > compatible = "ethernet-phy-ieee802.3-c22"; > reg = <1>; > eee-broken-1000t; > - reset-gpios = <&gpio4 2 GPIO_ACTIVE_LOW>; Hmm, DT is describing hardware. If board schematic says there is a reset GPIO, we should have it. Shawn > }; > }; > }; > -- > 2.17.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel