From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E44B7C433E0 for ; Thu, 18 Mar 2021 14:13:22 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8B66A64EF9 for ; Thu, 18 Mar 2021 14:13:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8B66A64EF9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=C3kjVwCie7QI4+L+Vh2RFvghWLvVY6laJyS+/I6MZZY=; b=hYzI9k8bXz6cyxuoRWX2T9W7Y /0Y3fRwoJVaB0w3tyzuyd/Vqvq4O8GUKSSEfyLozqcDiSo8AWjyo8mf0zfff8MkkJWOLIclG9yErc dHpl+gJI9gnvqxONDavCBNQjsjlOuN/E8YDlAEKrRzawgyfOnAwLONzYLsww1UpMWjjA5JMCb/aic SW9EVXwuIQGu6W3iM6kE+Y3bTjwdh7AyiGHX0JBLjPrwDm/xwODMpoMrjo8jALfePdOsk96aB/Gwx suhN0FfVENuD3hL1Aao3+R4pVziMFnSSJ7MxXedDiFubzWJHS1ymF1cYDW0aYjWh0ChCvnoHIBTnd 2mUwmHTJQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lMtNT-005Rrk-RP; Thu, 18 Mar 2021 14:11:59 +0000 Received: from mail.kernel.org ([198.145.29.99]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lMtNQ-005RqB-6X for linux-arm-kernel@lists.infradead.org; Thu, 18 Mar 2021 14:11:53 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 5C3E864E20; Thu, 18 Mar 2021 14:11:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1616076710; bh=4YnHl7gwi81S3iAatlqSlG18VzXM0SPmU2vgnSIIf3c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fh2gNeYjcMWWFPwQqw4SYwLfgxcV0fBUXg8sg3atSau6iSq6CVtcHPp52yB1lkqpm fj5jpdHAg5baOPGc3/Y9DzFKhMlVybiwVQecYwnIfgT10tJs1Bq0ro3ApT9UkWaiVC LMrmjLc39vwweMHb5cKh/qY7qePKmlEaptG5/BJ29L8pjO6t/Rc9vbEaDvC5sOgOhX lQKyJIm+8TbX8Ct5ntM2eHCYuT19ovuZsbv18x9Q+WzVZKaGp3V6a1dccAoj5NWuFi u9Qn7ODTHk4zaWrQVYT7B2O7N/doi1FfnRpBf+asYvE+SZb7Nhl3BEcV1KyxHUGMH2 8hrCsRPyiZBNQ== Date: Thu, 18 Mar 2021 14:11:44 +0000 From: Will Deacon To: Marc Zyngier Cc: kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, dave.martin@arm.com, daniel.kiss@arm.com, Catalin Marinas , James Morse , Julien Thierry , Suzuki K Poulose , broonie@kernel.org, ascull@google.com, qperret@google.com, kernel-team@android.com Subject: Re: [PATCH v2 09/11] KVM: arm64: Trap host SVE accesses when the FPSIMD state is dirty Message-ID: <20210318141144.GE7055@willie-the-truck> References: <20210318122532.505263-1-maz@kernel.org> <20210318122532.505263-10-maz@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210318122532.505263-10-maz@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210318_141152_442212_8134F32E X-CRM114-Status: GOOD ( 13.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Mar 18, 2021 at 12:25:30PM +0000, Marc Zyngier wrote: > ZCR_EL2 controls the upper bound for ZCR_EL1, and is set to > a potentially lower limit when the guest uses SVE. In order > to restore the SVE state on the EL1 host, we must first > reset ZCR_EL2 to its original value. > > To make it as lazy as possible on the EL1 host side, set > the SVE trapping in place when returning exiting from "returning exiting"? > diff --git a/arch/arm64/kvm/hyp/nvhe/switch.c b/arch/arm64/kvm/hyp/nvhe/switch.c > index f3d0e9eca56c..60adc7ff4caa 100644 > --- a/arch/arm64/kvm/hyp/nvhe/switch.c > +++ b/arch/arm64/kvm/hyp/nvhe/switch.c > @@ -68,7 +68,7 @@ static void __activate_traps(struct kvm_vcpu *vcpu) > static void __deactivate_traps(struct kvm_vcpu *vcpu) > { > extern char __kvm_hyp_host_vector[]; > - u64 mdcr_el2; > + u64 mdcr_el2, cptr; > > ___deactivate_traps(vcpu); > > @@ -101,7 +101,12 @@ static void __deactivate_traps(struct kvm_vcpu *vcpu) > write_sysreg(HCR_HOST_NVHE_PROTECTED_FLAGS, hcr_el2); > else > write_sysreg(HCR_HOST_NVHE_FLAGS, hcr_el2); > - write_sysreg(CPTR_EL2_DEFAULT, cptr_el2); > + > + cptr = CPTR_EL2_DEFAULT; > + if (vcpu_has_sve(vcpu) && (vcpu->arch.flags & KVM_ARM64_FP_ENABLED)) > + cptr |= CPTR_EL2_TZ; Acked-by: Will Deacon Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel