From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A3ECC433DB for ; Mon, 22 Mar 2021 05:58:10 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DBB3C6187E for ; Mon, 22 Mar 2021 05:58:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DBB3C6187E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=beagleboard.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Rqkgagxpke1WMckDK7gLTjRELQEhvT9gt9IvKufqJLU=; b=b9HjrfxYKKyGrrt6YCaKrA7PD 8cPHuBHEaZ8gocA5wnf8W3ElOaTBrJoC2gGSlCYg7Er4n6b/fzhl+V6M2X/Wor438LlthKyKh0Xj0 4e4gYiLDCqKMBxiDjQ/qccybOAPjLsOuI2ZJKsLx0JKEXt229gkcgXWO+AjO3VMYXDvRfdfKVru3M Qbs/nDLMwZQW2yxmuMaAfnDVBX1tQo8ZXyTn8gmYOuUT1xUPtfKRCCNyWXN4K0NCAM2DIguNB6u6J fOcs1tLUiqsZrqBqewQs8RJPONvSn1Rpw/KHrgyXNbqcHjsHGJ0GSckCVWWt/Z2UcNvGiVZUiKU/b HDkNp9Ivw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lODYO-00AxJv-P8; Mon, 22 Mar 2021 05:56:41 +0000 Received: from mail-pg1-x536.google.com ([2607:f8b0:4864:20::536]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lODYK-00AxJR-Bw for linux-arm-kernel@lists.infradead.org; Mon, 22 Mar 2021 05:56:38 +0000 Received: by mail-pg1-x536.google.com with SMTP id f10so836355pgl.9 for ; Sun, 21 Mar 2021 22:56:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=beagleboard-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=6R/wNYFYL96Z+W2s9fNrnXnmsOpLl/kcJR1fGSVoiEE=; b=kM9YBllT/tpxQ5AJXgkZE9dXlxkqQ8pj1Bypm9bDNdAj4gMOA2VjzOKIbP9gb67NWT Rv8mh0S7FL0PD6EyQBhZGtAptOBRPwWgB0SE3VMrxV08EXACUWyDmpgIEPnd+Ou79uk4 P8fFmtn2SWBeDxPj+8yaRQDra6q5l49j6pHZ0L2TRFXCEO0xcdMXsxKW6GBLRvAU1RAa 9bdVT4MDKxNDkljMnFO3XPjmEOqVhQ8il4eKMneqbdIsPVpu0mn04pASD4Yp/Gd4X/wK bYLRAO+DwCW4YZNpr7+1tRSytQlmc4X1zlQQXrBwWPlynA3jo0SoY4z7WJPvr9dcpETR Z6Qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=6R/wNYFYL96Z+W2s9fNrnXnmsOpLl/kcJR1fGSVoiEE=; b=Sg+P4omnBYK6SxSj2JjfyPG8ZN0Jj4vDoJcN13qALRd25uazl5Xualw9WJSiRvuVDL 4VeS6Qe1cFnhjrKk0oG93Pu5xF0yTTd6goAKMJ+QKf2WBsxkZOJ//9C3kJPWAjYRq8As xkjyWuOlTE/6bcNcAHx27Ch74ZlyeKFcH14g2DPjjG8YAyKoPZSRSY4Sbj9DCQqjpN5U v1z1OYxOsDYsnGPiee1SH5QqzkSCWRgdLOZsiq7zwpquO86HqQ/4N/CZib+tO/hTzeVC RvjuKdSz4/WR0ZGKzDdR238v/DYoRGB1/3ttdDZ0f5DgBrJSnIG3ByjQVixGKt3tRUe/ oJjA== X-Gm-Message-State: AOAM531KeC+FbAJd8WX+E01aIC1ktmd5UpnOgXhp7AHpchXlgN0WNQEz Uo78wS+qo1KGcrYxyGw3LsbLIw== X-Google-Smtp-Source: ABdhPJxKPdwcHLkk2BXaAkgeR/I9gBqO0bAm+q641P1HXjHdb70nXU62Q5IG3INGo0Ws0CuSdraeQg== X-Received: by 2002:a65:4288:: with SMTP id j8mr21082631pgp.231.1616392593821; Sun, 21 Mar 2021 22:56:33 -0700 (PDT) Received: from x1 ([2601:1c0:4701:ae70:f583:1360:2cc8:3c30]) by smtp.gmail.com with ESMTPSA id l22sm13200080pfd.145.2021.03.21.22.56.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 21 Mar 2021 22:56:33 -0700 (PDT) Date: Sun, 21 Mar 2021 22:56:31 -0700 From: Drew Fustini To: Hanna Hawa Cc: andy.shevchenko@gmail.com, tony@atomide.com, haojian.zhuang@linaro.org, linus.walleij@linaro.org, dwmw@amazon.co.uk, benh@amazon.com, ronenk@amazon.com, talel@amazon.com, jonnyc@amazon.com, hanochu@amazon.com, tgershi@amazon.com, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 0/3] Fix pinctrl-single pcs_pin_dbg_show() Message-ID: <20210322055631.GB392062@x1> References: <20210319152133.28705-1-hhhawa@amazon.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210319152133.28705-1-hhhawa@amazon.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210322_055636_876638_11E22E78 X-CRM114-Status: GOOD ( 18.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Mar 19, 2021 at 05:21:30PM +0200, Hanna Hawa wrote: > These patches fix the pcs_pin_dbg_show() function for the scenario where > a single register controls multiple pins (i.e. bits_per_mux is not zero) > Additionally, the common formula is moved to a separate function to > allow reuse. > > Changes since v3: > ----------------- > - define and set variable 'mux_bytes' in one line > - update commit message > > Changes since v2: > ----------------- > - move read() register to be outside of if condition (as it common > read()). > - Remove extra parentheses > - replace offset variable by direct return statements > > Changes since v1: > ----------------- > - remove unused variable in In function 'pcs_allocate_pin_table' > (Reported-by: kernel test robot ) > > Hanna Hawa (3): > pinctrl: pinctrl-single: remove unused variable > pinctrl: pinctrl-single: remove unused parameter > pinctrl: pinctrl-single: fix pcs_pin_dbg_show() when bits_per_mux is > not zero > > drivers/pinctrl/pinctrl-single.c | 65 ++++++++++++++++++-------------- > 1 file changed, 37 insertions(+), 28 deletions(-) > > -- > 2.17.1 > I'm curious what SoC are you using? It's good to know who has hardware to test bits_per_mux in the future. I pay attention to pinctrl-single as that is the driver used for the TI AM3358 SoC used in a variety of BeagleBone boards. It does not use bits_per_mux, but I can verify that this does not cause any regression for the AM3358 SoC: /sys/kernel/debug/pinctrl/44e10800.pinmux-pinctrl-single# cat pins registered pins: 142 pin 0 (PIN0) 0:? 44e10800 00000027 pinctrl-single pin 1 (PIN1) 0:? 44e10804 00000027 pinctrl-single pin 2 (PIN2) 0:? 44e10808 00000027 pinctrl-single pin 3 (PIN3) 0:? 44e1080c 00000027 pinctrl-single pin 4 (PIN4) 0:? 44e10810 00000027 pinctrl-single pin 5 (PIN5) 0:? 44e10814 00000027 pinctrl-single pin 6 (PIN6) 0:? 44e10818 00000027 pinctrl-single pin 7 (PIN7) 0:? 44e1081c 00000027 pinctrl-single pin 8 (PIN8) 22:gpio-96-127 44e10820 00000027 pinctrl-single pin 9 (PIN9) 23:gpio-96-127 44e10824 00000037 pinctrl-single pin 10 (PIN10) 26:gpio-96-127 44e10828 00000037 pinctrl-single pin 11 (PIN11) 27:gpio-96-127 44e1082c 00000037 pinctrl-single pin 12 (PIN12) 0:? 44e10830 00000037 pinctrl-single pin 140 (PIN140) 0:? 44e10a30 00000028 pinctrl-single pin 141 (PIN141) 13:gpio-64-95 44e10a34 00000020 pinctrl-single Reviewed-by: Drew Fustini Thanks, Drew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel