From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 271ABC433C1 for ; Tue, 23 Mar 2021 22:14:14 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A0D13601FC for ; Tue, 23 Mar 2021 22:14:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A0D13601FC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=xYsTY7mYLhXybfQmNkTN1Dq0ffHZ4tgitpQ3WhB2M2Y=; b=qlFszHOxLNhVQcdJJrfwOnezO zF3QH9FwGf/9irE73NISuYTQ7LEMiESHUrd7LY1ylN/dkzLy6atO2gV8cjRQBouQyIn1DuXmwAYit rGOAdiChhUdE9GC4hrF9demJbz+P75AYz3izmO11vL6qts+UwXcBYdCv5DMTsJAOg/lz0YGVC6H1H ZqIPnXX8bRZBPie0O4JHzsGRGkqggpkF/6PqNH5wqlgL8Ss7V7AjKPC0AbxUcVIqd+MBgShDltirr ocKQIPw8uxB04ND7VWjlJwkD/TF9inCxBef9qIVqx5vazP+t5Tzj9G6yEqUkj99+lgTFIL+mbpV7w NAIsF/0Uw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lOpGU-00FpIr-3F; Tue, 23 Mar 2021 22:12:42 +0000 Received: from mail-io1-f51.google.com ([209.85.166.51]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lOpGG-00FpHd-5x for linux-arm-kernel@lists.infradead.org; Tue, 23 Mar 2021 22:12:32 +0000 Received: by mail-io1-f51.google.com with SMTP id x17so8141328iog.2 for ; Tue, 23 Mar 2021 15:12:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=7vlfeKGY2anBMnkOGjXVtyCIrkxjLM4xf/feAmd+6IY=; b=XUsCO2LmyKEqyonJghZ0pipvgNS8cZGB2ZyuuJmdB7xZAiLlY5SpyWro0tH0PSGNz5 aE5nExzZZa/s5PXTgPNpHQ9uLnjPoUqoOl9Qa4k2bXsapYCCv+QtQVOfU3MIpCwFNkRd Jvi8y2qY87p7ITZFZ/pvG5SqEeKqMlM0aBj2KJOoEEtmwGurmoY07zTMAxoB5X80fXut ss+lErTozZDXOs9DjhGoG5BEwvCz25wwFpojZ0fDXh7zFM14m1LddJy9n1DoUvZhwznH N5uXhrL6z2oMiKSBJSCRsBJBeLEJRH79rv91BOOMYM2XYF55ADCIk78aJ09PLlHICtCC 5Ong== X-Gm-Message-State: AOAM533lL2N9TFc+4L0lv3QVkqKbuOB8i61Y5tU7jdBa4tZzBDsLQSwI CCWlSVMdimw5b+IZ5dAhWg== X-Google-Smtp-Source: ABdhPJzDhps+3EqTMgENMAo/QosogqZw12wpVlXNRCRIesnrYfqMO0lF3nqEGhf1aX/w1W1yHmlt7Q== X-Received: by 2002:a5e:dd0c:: with SMTP id t12mr222939iop.50.1616537546929; Tue, 23 Mar 2021 15:12:26 -0700 (PDT) Received: from robh.at.kernel.org ([64.188.179.253]) by smtp.gmail.com with ESMTPSA id u15sm80284iln.84.2021.03.23.15.12.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Mar 2021 15:12:25 -0700 (PDT) Received: (nullmailer pid 1432897 invoked by uid 1000); Tue, 23 Mar 2021 22:12:22 -0000 Date: Tue, 23 Mar 2021 16:12:22 -0600 From: Rob Herring To: =?iso-8859-1?Q?=C1lvaro_Fern=E1ndez?= Rojas Cc: Linus Walleij , Bartosz Golaszewski , Lee Jones , Michael Walle , Florian Fainelli , bcm-kernel-feedback-list@broadcom.com, Jonas Gorski , Necip Fazil Yildiran , Andy Shevchenko , linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v8 03/22] dt-bindings: improve BCM6345 GPIO binding documentation Message-ID: <20210323221222.GA1425873@robh.at.kernel.org> References: <20210317143803.26127-1-noltari@gmail.com> <20210317143803.26127-4-noltari@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210317143803.26127-4-noltari@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210323_221230_213207_12F31E4D X-CRM114-Status: GOOD ( 25.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Mar 17, 2021 at 03:37:44PM +0100, =C1lvaro Fern=E1ndez Rojas wrote: > Convert existing BCM6345 GPIO binding documentation to YAML and add bindi= ng > documentation for the GPIO controller found in BCM6318, BCM6328, BCM6358, > BCM6362, BCM6368 and BCM63268 SoCs. > = > Co-developed-by: Jonas Gorski > Signed-off-by: Jonas Gorski > Signed-off-by: =C1lvaro Fern=E1ndez Rojas > --- > v8: introduce changes suggested by Rob Herring > v7: new patch, splitted from pinctrl documentation Almost there... > = > .../bindings/gpio/brcm,bcm6345-gpio.txt | 46 ----------- > .../bindings/gpio/brcm,bcm6345-gpio.yaml | 78 +++++++++++++++++++ > 2 files changed, 78 insertions(+), 46 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/gpio/brcm,bcm6345-g= pio.txt > create mode 100644 Documentation/devicetree/bindings/gpio/brcm,bcm6345-g= pio.yaml > = > diff --git a/Documentation/devicetree/bindings/gpio/brcm,bcm6345-gpio.txt= b/Documentation/devicetree/bindings/gpio/brcm,bcm6345-gpio.txt > deleted file mode 100644 > index e7853143fa42..000000000000 > --- a/Documentation/devicetree/bindings/gpio/brcm,bcm6345-gpio.txt > +++ /dev/null > @@ -1,46 +0,0 @@ > -Bindings for the Broadcom's brcm,bcm6345-gpio memory-mapped GPIO control= lers. > - > -These bindings can be used on any BCM63xx SoC. However, BCM6338 and BCM6= 345 > -are the only ones which don't need a pinctrl driver. > -BCM6338 have 8-bit data and dirout registers, where GPIO state can be re= ad > -and/or written, and the direction changed from input to output. > -BCM6345 have 16-bit data and dirout registers, where GPIO state can be r= ead > -and/or written, and the direction changed from input to output. This detail about the h/w should be kept and extended given the newer = chips have 32-bit registers AIUI. > - > -Required properties: > - - compatible: should be "brcm,bcm6345-gpio" > - - reg-names: must contain > - "dat" - data register > - "dirout" - direction (output) register > - - reg: address + size pairs describing the GPIO register sets; > - order must correspond with the order of entries in reg-names > - - #gpio-cells: must be set to 2. The first cell is the pin number and > - the second cell is used to specify the gpio polarity: > - 0 =3D active high > - 1 =3D active low > - - gpio-controller: Marks the device node as a gpio controller. > - > -Optional properties: > - - native-endian: use native endian memory. > - > -Examples: > - - BCM6338: > - gpio: gpio-controller@fffe0407 { > - compatible =3D "brcm,bcm6345-gpio"; > - reg-names =3D "dirout", "dat"; > - reg =3D <0xfffe0407 1>, <0xfffe040f 1>; > - > - #gpio-cells =3D <2>; > - gpio-controller; > - }; > - > - - BCM6345: > - gpio: gpio-controller@fffe0406 { > - compatible =3D "brcm,bcm6345-gpio"; > - reg-names =3D "dirout", "dat"; > - reg =3D <0xfffe0406 2>, <0xfffe040a 2>; > - native-endian; > - > - #gpio-cells =3D <2>; > - gpio-controller; > - }; > diff --git a/Documentation/devicetree/bindings/gpio/brcm,bcm6345-gpio.yam= l b/Documentation/devicetree/bindings/gpio/brcm,bcm6345-gpio.yaml > new file mode 100644 > index 000000000000..d1d34a347a1f > --- /dev/null > +++ b/Documentation/devicetree/bindings/gpio/brcm,bcm6345-gpio.yaml > @@ -0,0 +1,78 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/gpio/brcm,bcm6345-gpio.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Broadcom BCM6345 GPIO controller > + > +maintainers: > + - =C1lvaro Fern=E1ndez Rojas > + - Jonas Gorski > + > +description: |+ > + Bindings for Broadcom's BCM63xx memory-mapped GPIO controllers. > + > + These bindings can be used on any BCM63xx SoC. However, BCM6338 and BC= M6345 > + are the only ones which don't need a pinctrl driver. > + > +properties: > + compatible: > + enum: > + - brcm,bcm6318-gpio > + - brcm,bcm6328-gpio > + - brcm,bcm6345-gpio > + - brcm,bcm6358-gpio > + - brcm,bcm6362-gpio > + - brcm,bcm6368-gpio > + - brcm,bcm63268-gpio > + > + gpio-controller: true > + > + "#gpio-cells": > + const: 2 > + > + gpio-ranges: > + maxItems: 1 > + > + native-endian: true > + > + reg: > + maxItems: 2 > + > + reg-names: > + items: > + - const: dirout > + - const: dat > + > +required: > + - compatible > + - reg > + - reg-names > + - gpio-controller > + - '#gpio-cells' > + > +additionalProperties: false > + > +examples: > + - | > + gpio-controller@fffe0406 { gpio@... > + compatible =3D "brcm,bcm6345-gpio"; > + reg-names =3D "dirout", "dat"; > + reg =3D <0xfffe0406 2>, <0xfffe040a 2>; > + native-endian; > + > + gpio-controller; > + #gpio-cells =3D <2>; > + }; > + > + - | > + gpio@0 { > + compatible =3D "brcm,bcm63268-gpio"; > + reg-names =3D "dirout", "dat"; > + reg =3D <0x0 0x8>, <0x8 0x8>; > + > + gpio-controller; > + gpio-ranges =3D <&pinctrl 0 0 52>; > + #gpio-cells =3D <2>; > + }; > -- = > 2.20.1 > = _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel