From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A45CC433C1 for ; Tue, 23 Mar 2021 23:22:05 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0E2C2600CD for ; Tue, 23 Mar 2021 23:22:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0E2C2600CD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=GIg3R3bITWbMRfDZraXaXXILJzlSg/SERE58wgNgdik=; b=DiEcigoEF87hqewCZ5l8c7/b/ QjMBwHYAXAZ1n0tNnb0RyoJTa2WPeeFOO5sFCSsrlGh26IF6+qy8eXwwLvXYTlqqX3JFeP+4qQosA RtSAnrQX7Gz/kbataEjrrahfD6yy52lU3SKeqb7nlt0UG9UpqgVI3e4G97nb3aR+cFdJrQrxxB+fd vrJKmRwKv8IN3bfCqCBjTb9bJwB48FX97w8FoxeKqexpct6oOirPk2bfbbxlWwI2HntLTIP7eG6NS HfT//oDddRDv7KE/HbF6mVv3Th9Ijc5hcas7PEx7DFydocOo1BMHwHZEkxhyxQ2EVCMS1D8n0YcWw tRLO8I1nw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lOqK3-00FykB-5O; Tue, 23 Mar 2021 23:20:27 +0000 Received: from mail-pf1-x42b.google.com ([2607:f8b0:4864:20::42b]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lOqJw-00FyjS-Tr for linux-arm-kernel@lists.infradead.org; Tue, 23 Mar 2021 23:20:22 +0000 Received: by mail-pf1-x42b.google.com with SMTP id 11so15939066pfn.9 for ; Tue, 23 Mar 2021 16:20:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=2mPqZ8T3s6ATLiDuP1AsIgNdhiWZsvEH4M6lDW4cfTI=; b=FkYfaAkO0Z6/s4JItNqmcW1gokGmTqNJc9DB36xytboCFozRTY5w7JdrA4JFNrrqUc PScrQdfFxWrPte+4sTO//YvN7fQwHcV4zIOKvLkNX+zkTewbGEUrY0GEDOiEQUF4vYuU aFAGddHODC9RZFrFAz47xwrt5Rc5jXEikRcLR5EzlVCiEtalcSZHIkFUV2dR22EvrkrX 0xQkfBA3CaMmqYlEvQNU41R3KeX7PtTHWJztwsyq20bzwZz7nyLoXhDTLGfFphS2wpwu 5p3iYee6HWfEVuxS+9Mfdy0BB3mLXec96LfugcFuNmiAtUKDyBgTj9/PwhGHdbLPB8XF 4C/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=2mPqZ8T3s6ATLiDuP1AsIgNdhiWZsvEH4M6lDW4cfTI=; b=nfIHnH5bwAYQ4+cUoYNQqnghY41JpFP7yofUkFGVgPulJ6P64UzbXnM6euB/A2l2to wk1Gkg58xHt3eycRz/L/L/++rPWOb51GDeh+575DGi/0uOvkkigJoxR3rSLlxvDW16eB 54p9U8D7BCtAVGt8ADpcNCbSG0jM7yX26fLDS6Sn65OuFa5J5Z/yAK8ZfYO32xySQ/ER F2gKTR5tvEYZPp50XEeKAEPGWzzNhCfv3NBYIl9Zdf7HsUWdGlTpvknO/lJUzsdrxfd8 OFioqzNeCaHl+0182LU+I6v1b1t06Srf3KEnCgNo1fM3H9pk1BoWXBS98xDe3cA4GWlR E0Qg== X-Gm-Message-State: AOAM532vXoXOgRcktmBPbPn6ORjc5k8NQkTXhbBaL+fUHFu4+hjfrZoT yC+QLDTl1CX9wUIvZUOKdCnyfA== X-Google-Smtp-Source: ABdhPJxNQ1MKjV1GEOTfkga2yU4EzySf+ImHzG//t/vH8JyfFvC/Ow4Oj+kKSp7Y3MjTm9kaPF1qEw== X-Received: by 2002:a17:902:8e89:b029:e6:ef44:6a54 with SMTP id bg9-20020a1709028e89b02900e6ef446a54mr756979plb.7.1616541617252; Tue, 23 Mar 2021 16:20:17 -0700 (PDT) Received: from xps15 (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id 22sm230405pjl.31.2021.03.23.16.20.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Mar 2021 16:20:16 -0700 (PDT) Date: Tue, 23 Mar 2021 17:20:14 -0600 From: Mathieu Poirier To: Suman Anna Cc: Bjorn Andersson , Grzegorz Jaszczyk , Jan Kiszka , Lokesh Vutla , Vignesh Raghavendra , linux-remoteproc@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] remoteproc: pru: Fix firmware loading crashes on K3 SoCs Message-ID: <20210323232014.GA1782475@xps15> References: <20210315205859.19590-1-s-anna@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210315205859.19590-1-s-anna@ti.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210323_232021_304262_66EFCE24 X-CRM114-Status: GOOD ( 21.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Mar 15, 2021 at 03:58:59PM -0500, Suman Anna wrote: > The K3 PRUs are 32-bit processors and in general have some limitations > in using the standard ARMv8 memcpy function for loading firmware segments, > so the driver already uses a custom memcpy implementation. This added > logic however is limited to only IRAMs at the moment, but the loading > into Data RAMs is not completely ok either and does generate a kernel > crash for unaligned accesses. > > Fix these crashes by removing the existing IRAM logic limitation and > extending the custom memcpy usage to Data RAMs as well for all K3 SoCs. > > Fixes: 1d39f4d19921 ("remoteproc: pru: Add support for various PRU cores on K3 AM65x SoCs") > Signed-off-by: Suman Anna Probably a good idea to CC stable as well... Reviewed-by: Mathieu Poirier > --- > drivers/remoteproc/pru_rproc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/remoteproc/pru_rproc.c b/drivers/remoteproc/pru_rproc.c > index 2667919d76b3..16979c1cd2f4 100644 > --- a/drivers/remoteproc/pru_rproc.c > +++ b/drivers/remoteproc/pru_rproc.c > @@ -585,7 +585,7 @@ pru_rproc_load_elf_segments(struct rproc *rproc, const struct firmware *fw) > break; > } > > - if (pru->data->is_k3 && is_iram) { > + if (pru->data->is_k3) { > ret = pru_rproc_memcpy(ptr, elf_data + phdr->p_offset, > filesz); > if (ret) { > -- > 2.30.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel