From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53DF8C433C1 for ; Wed, 24 Mar 2021 10:13:06 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CD0B561A04 for ; Wed, 24 Mar 2021 10:13:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CD0B561A04 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cerno.tech Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=l8FFgn7aGLpdcFmvQkEVH9C3AEcHTmGObThHX5rL7gM=; b=rPiedNKJEZ6xvsdvQBFU0IpM+ gE4QwnqZebNBV5FDM86vLmN01BIrR87k/W1v4/fXO18qKPqAv9PvjwsG7DwL6xJYkAG+P82oFQCEl Gxjg2h1+BOAGYy9o+vPCJhyf3w8ZeD4LQBd3DPl1oO5aK24a7JoejpTVcv07qWWRaMEfH86OydWmK VKzv3CRePaNvXYru0ptJbdXiqGC8M+JNI6CMtH5xPbUJUfYoe/FKNoSr+6SKv2jtTxxht5h/zRK6T HEJrOIrX24c8HQyibrbTiRUacPy34gQZEerPdj8f+nKsX8EwEDE6v3zncXFiuzJVBU+xAuPkIKBAD w2fR0+ISg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lP0U3-00GoBx-2u; Wed, 24 Mar 2021 10:11:27 +0000 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lP0Tw-00Go9P-4F for linux-arm-kernel@lists.infradead.org; Wed, 24 Mar 2021 10:11:23 +0000 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 12751D6D; Wed, 24 Mar 2021 06:11:15 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Wed, 24 Mar 2021 06:11:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=+wQbldXodj/75p2l96uhI6Hek8z qcssRoaEMguqNWGM=; b=TL21/JHiqptwbT7hJ3+/ZmItwMc3LKk7LrRBg3BiB+2 0oE/xykRj8ur8gwWgEy4Z7QwQU8kIGSoDqwIAdGY74mp3FkZQ2afaMLl3v1yUclX 5PnDYYD7EhivFmGYIEgCd3iUjPPdqK6/sjV+GHEzYFDjAvawO7V/29+qByntk5/q IENXTFMgB2MyOmFriJlvCoiOYnAr9GgzRS/UlKaiC4iYVy8HFBBH3b51nod1LCsP B7f23i+vSTu2yfWAfJl6399I5VaXiLeoJbtUXutEBDWmXusB8JumbAu1+wJg3vuF 7r4HZ4Zemhfmb47Q8Z7hzntl5DiUnWiBA1+JTFuh4Wg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=+wQbld Xodj/75p2l96uhI6Hek8zqcssRoaEMguqNWGM=; b=C20aS6qvips2PFG84xF/JZ +siHrFDdTkoZvgqXUNtt3iGVEAIu8UtjzJL1ZmuGePHi81mNXTEtucVKm98beXMh uV9+q/oZuEIOs2JYuuAtx/qbE8XbyHkXTbc7GCbVJivwEvDjRQZdA2pxrokWdKLc D2VMDThyTcAJcHfpYdCH4ea3UlTkHZNuZIz33o8BQm0J7hy9fFci3hyms+Tcdf7h Olr7pzBMBjqm+6tzP50US+8FZkqg73ki7a8TBSDB9AF8ZhuPB8yZnQqtPlJWwZMg /rDKL8D5FrqMUrR8dEf0M2UgEb0M5TdQIqSpvDXBgLlYwEXE3fQY9MXcvChud1AA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudegkedgudduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpeforgigihhm vgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrfgrth htvghrnhepveevfeffudeviedtgeethffhteeuffetfeffvdehvedvheetteehvdelfffg jedvnecuffhomhgrihhnpehkvghrnhgvlhdrohhrghenucfkphepledtrdekledrieekrd ejieenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehm rgigihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Received: from localhost (lfbn-tou-1-1502-76.w90-89.abo.wanadoo.fr [90.89.68.76]) by mail.messagingengine.com (Postfix) with ESMTPA id 68161108005C; Wed, 24 Mar 2021 06:11:12 -0400 (EDT) Date: Wed, 24 Mar 2021 11:11:09 +0100 From: Maxime Ripard To: Laurent Pinchart Cc: Jagan Teki , Samuel Holland , Chen-Yu Tsai , Jernej Skrabec , dri-devel , linux-arm-kernel , linux-kernel , linux-amarula , linux-sunxi Subject: Re: [PATCH v4 1/4] drm: sun4i: dsi: Use drm_of_find_panel_or_bridge Message-ID: <20210324101109.k46k3l7bksvxhll5@gilmour> References: <20210322140152.101709-1-jagan@amarulasolutions.com> <20210322140152.101709-2-jagan@amarulasolutions.com> MIME-Version: 1.0 In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210324_101121_452234_818D6E35 X-CRM114-Status: GOOD ( 38.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============7388362488405467914==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============7388362488405467914== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="kp676o7nybn544nt" Content-Disposition: inline --kp676o7nybn544nt Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Mar 24, 2021 at 11:55:35AM +0200, Laurent Pinchart wrote: > Hi Jagan, >=20 > On Wed, Mar 24, 2021 at 03:19:10PM +0530, Jagan Teki wrote: > > On Wed, Mar 24, 2021 at 3:09 PM Laurent Pinchart wrote: > > > On Wed, Mar 24, 2021 at 02:44:57PM +0530, Jagan Teki wrote: > > > > On Wed, Mar 24, 2021 at 8:18 AM Samuel Holland wrote: > > > > > On 3/23/21 5:53 PM, Laurent Pinchart wrote: > > > > > > On Mon, Mar 22, 2021 at 07:31:49PM +0530, Jagan Teki wrote: > > > > > >> Replace of_drm_find_panel with drm_of_find_panel_or_bridge > > > > > >> for finding panel, this indeed help to find the bridge if > > > > > >> bridge support added. > > > > > >> > > > > > >> Added NULL in bridge argument, same will replace with bridge > > > > > >> parameter once bridge supported. > > > > > >> > > > > > >> Signed-off-by: Jagan Teki > > > > > > > > > > > > Looks good, there should be no functional change. > > > > > > > > > > Actually this breaks all existing users of this driver, see below. > > > > > > > > > > > Reviewed-by: Laurent Pinchart > > > > > > > > > > > >> --- > > > > > >> Changes for v4, v3: > > > > > >> - none > > > > > >> > > > > > >> drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c | 11 ++++++++--- > > > > > >> 1 file changed, 8 insertions(+), 3 deletions(-) > > > > > >> > > > > > >> diff --git a/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c b/drivers/= gpu/drm/sun4i/sun6i_mipi_dsi.c > > > > > >> index 4f5efcace68e..2e9e7b2d4145 100644 > > > > > >> --- a/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c > > > > > >> +++ b/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c > > > > > >> @@ -21,6 +21,7 @@ > > > > > >> > > > > > >> #include > > > > > >> #include > > > > > >> +#include > > > > > >> #include > > > > > >> #include > > > > > >> #include > > > > > >> @@ -963,10 +964,14 @@ static int sun6i_dsi_attach(struct mipi_= dsi_host *host, > > > > > >> struct mipi_dsi_device *device) > > > > > >> { > > > > > >> struct sun6i_dsi *dsi =3D host_to_sun6i_dsi(host); > > > > > >> - struct drm_panel *panel =3D of_drm_find_panel(device->dev= =2Eof_node); > > > > > > > > > > This is using the OF node of the DSI device, which is a direct ch= ild of > > > > > the DSI host's OF node. There is no OF graph involved. > > > > > > > > > > >> + struct drm_panel *panel; > > > > > >> + int ret; > > > > > >> + > > > > > >> + ret =3D drm_of_find_panel_or_bridge(dsi->dev->of_node, 0,= 0, > > > > > >> + &panel, NULL); > > > > > > > > > > However, this function expects to find the panel using OF graph. = This > > > > > does not work with existing device trees (PinePhone, PineTab) whi= ch do > > > > > not use OF graph to connect the panel. And it cannot work, becaus= e the > > > > > DSI host's binding specifies a single port: the input port from t= he > > > > > display engine. > > > > > > > > Thanks for noticing this. I did understand your point and yes, I did > > > > mention the updated pipeline in previous versions and forgot to add= it > > > > to this series. > > > > > > > > Here is the updated pipeline to make it work: > > > > > > > > https://patchwork.kernel.org/project/dri-devel/patch/20190524104252= =2E20236-1-jagan@amarulasolutions.com/ > > > > > > > > Let me know your comments on this, so I will add a patch for the > > > > above-affected DTS files. > > > > > > DT is an ABI, we need to ensure backward compatibility. Changes in > > > kernel drivers can't break devices that have an old DT. > >=20 > > Thanks for your point. > >=20 > > So, we need to choose APIs that would compatible with the old DT and > > new DT changes. Am I correct? >=20 > Yes, that's correct. However, I see no particular reason to change the DT binding in this case. The DSI devices are supposed to be described through a subnode of their DSI controller, that's the generic binding and except for very odd devices (and a bridge like this one is certainly not one), I see no reason to deviate from that. Maxime --kp676o7nybn544nt Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYFsQPQAKCRDj7w1vZxhR xTMWAPoCqODHVwflYc37O1/gdVmLbZhcAVai6G99UtzoYOo5ygEArcWtqJ+TiVFf Y9qWwugKta+xfxFuIgIPVB46nGBixA4= =NGvV -----END PGP SIGNATURE----- --kp676o7nybn544nt-- --===============7388362488405467914== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============7388362488405467914==--