From: Catalin Marinas <catalin.marinas@arm.com>
To: Vincenzo Frascino <vincenzo.frascino@arm.com>
Cc: Will Deacon <will@kernel.org>,
linux-arm-kernel@lists.infradead.org, kernel-team@android.com,
Mark Rutland <mark.rutland@arm.com>,
Marc Zyngier <maz@kernel.org>,
Russell King <rmk+kernel@armlinux.org.uk>
Subject: Re: [PATCH 1/5] arm64: vdso: Use GFP_KERNEL for allocating compat vdso and signal pages
Date: Wed, 24 Mar 2021 17:28:02 +0000 [thread overview]
Message-ID: <20210324172801.GC3709@arm.com> (raw)
In-Reply-To: <2ea4ef90-ef57-0d1f-a020-8c44e991ee67@arm.com>
On Thu, Mar 18, 2021 at 06:03:44PM +0000, Vincenzo Frascino wrote:
> On 3/18/21 5:07 PM, Will Deacon wrote:
> > There's no need to allocate the compat vDSO and signal pages using
> > GFP_ATOMIC allocations, so use GFP_KERNEL instead.
> >
> > Signed-off-by: Will Deacon <will@kernel.org>
>
> Nit: We could explain why GFP_KERNEL is sufficient in the commit message.
Usually it's the other way around, document why GFP_ATOMIC is needed ;).
--
Catalin
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-03-24 17:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-18 17:07 [PATCH 0/5] Minor improvements to the compat vdso and sigpage Will Deacon
2021-03-18 17:07 ` [PATCH 1/5] arm64: vdso: Use GFP_KERNEL for allocating compat vdso and signal pages Will Deacon
2021-03-18 18:03 ` Vincenzo Frascino
2021-03-24 17:28 ` Catalin Marinas [this message]
2021-03-18 17:07 ` [PATCH 2/5] arm64: vdso: Remove redundant calls to flush_dcache_page() Will Deacon
2021-03-18 18:05 ` Vincenzo Frascino
2021-03-18 17:07 ` [PATCH 3/5] arm64: compat: Allow signal page to be remapped Will Deacon
2021-03-18 18:06 ` Vincenzo Frascino
2021-03-18 17:07 ` [PATCH 4/5] arm64: vdso: Avoid ISB after reading from cntvct_el0 Will Deacon
2021-03-18 18:08 ` Vincenzo Frascino
2021-03-18 17:07 ` [PATCH 5/5] arm64: compat: Poison the compat sigpage Will Deacon
2021-03-18 18:13 ` Vincenzo Frascino
2021-03-24 16:58 ` [PATCH 0/5] Minor improvements to the compat vdso and sigpage Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210324172801.GC3709@arm.com \
--to=catalin.marinas@arm.com \
--cc=kernel-team@android.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=maz@kernel.org \
--cc=rmk+kernel@armlinux.org.uk \
--cc=vincenzo.frascino@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).