From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52E3BC433DB for ; Wed, 24 Mar 2021 17:30:14 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B6F26619EC for ; Wed, 24 Mar 2021 17:30:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B6F26619EC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=3n3kFKQ4Py+im+JBUZwTej0iN11/p1mPM0hOlzrbK5M=; b=haKkzXsMotVQBRfapWulGYpSA xAMaro/YmfvCZxqtHVcsxfL44ZjjSjX12JEaZfEdJaiC9mhL/9Dz+i7q5j8ntuqp6RZG/y/pOCeAc JtZxrbYfCMraBIUIksI8zPNcY2ZuSta5rgNgb9xHnvzvCOhH5lSxX9dOErUTY632eIdROJ7lxgcW3 g0EoKxG82uvEvN9yxr3eWoxBLwLBcf6nK/M63sQ3zB9rmOKf/yug1Eau1wWmntQtUMGWVL3y4z/Xc 8ZtZa3b63tZWtku7hboqXkCJCLKXhF4enk720CLngqiUISoL4lpPq5oZ6iqum6nMLzGPTExJAp7jr N/ugHSe8A==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lP7Ih-00HWPV-I9; Wed, 24 Mar 2021 17:28:12 +0000 Received: from mail.kernel.org ([198.145.29.99]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lP7Ie-00HWOn-5G for linux-arm-kernel@lists.infradead.org; Wed, 24 Mar 2021 17:28:09 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 5BD6661A17; Wed, 24 Mar 2021 17:28:05 +0000 (UTC) Date: Wed, 24 Mar 2021 17:28:02 +0000 From: Catalin Marinas To: Vincenzo Frascino Cc: Will Deacon , linux-arm-kernel@lists.infradead.org, kernel-team@android.com, Mark Rutland , Marc Zyngier , Russell King Subject: Re: [PATCH 1/5] arm64: vdso: Use GFP_KERNEL for allocating compat vdso and signal pages Message-ID: <20210324172801.GC3709@arm.com> References: <20210318170738.7756-1-will@kernel.org> <20210318170738.7756-2-will@kernel.org> <2ea4ef90-ef57-0d1f-a020-8c44e991ee67@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <2ea4ef90-ef57-0d1f-a020-8c44e991ee67@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210324_172808_378406_C5AC9230 X-CRM114-Status: UNSURE ( 9.80 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Mar 18, 2021 at 06:03:44PM +0000, Vincenzo Frascino wrote: > On 3/18/21 5:07 PM, Will Deacon wrote: > > There's no need to allocate the compat vDSO and signal pages using > > GFP_ATOMIC allocations, so use GFP_KERNEL instead. > > > > Signed-off-by: Will Deacon > > Nit: We could explain why GFP_KERNEL is sufficient in the commit message. Usually it's the other way around, document why GFP_ATOMIC is needed ;). -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel