From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41EAEC433DB for ; Wed, 24 Mar 2021 17:43:35 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D3CFD61A1A for ; Wed, 24 Mar 2021 17:43:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D3CFD61A1A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=GuxnwD6+kDaen2cTW3zsUs/9JOKORXPLTcRFPRJEM58=; b=S6OT1ErHVYVthw3MjzWx9qlUF DpmEEV1OJNk9qpMHc82YoK9t0q+lcc7giMj1yYWN/6/JWeLGq+rOt1m88gu9dCpQPOnwqP1fLkoGR Vdacu8LTNQxRclZ7wGcmXsQKCB9x41G+drhf4AFW2LeWmITknzzV3HS3EvFXw3d9I5w1mGJTxzyZ+ XoibjkTu1wE2MxGZlDTFB/JD8GJ0xQGBai1A7/wKxMah99hTY91cA0J1K43QQrGoUpArke9hS35mp fSAmVvc08Y5d9g2eNdMESJJnpz2P0vz5Nt1JXzNla/iZydz5u6oUz4D4r/0p0mV12QA86dwTCcb/s aFUqENghw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lP7Vq-00HYYB-9M; Wed, 24 Mar 2021 17:41:46 +0000 Received: from mail.kernel.org ([198.145.29.99]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lP7Vl-00HYX1-7o for linux-arm-kernel@lists.infradead.org; Wed, 24 Mar 2021 17:41:43 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 8049C61A19; Wed, 24 Mar 2021 17:41:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1616607699; bh=htBRaBnyR28VLiCRvWJ8GrezsXw43e6rEl/CYh5JYlY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nC/39jKLJ2WW5B7Ht9uVjnTzS4IVBjlUt+qLupSoW7jSCpOj05mAKW0ze0wVvFBWh vVS+QvUq+zn9dM3FhPYf/Up4ZhUHuyUBQVWlzThEQMOlJy+EcN6HGvnaGgootoghSz 2+MHZ1qSlpgjzcfFYw3kbqi+jQhg2VLHPbMyb4la362GqeeMRb3pgGhx7357zM5mwn OMzblv0IlYn2TKJdLwnKYhPFF3cBLeUAGX5mSE3zJ720qVJ1odPYLwdtT3s8xW9v9N WqA31GPfnwLfjtsOTQQFlq8wPk2kwJ02FUJ1L7ImzbC26d38IuELPv73g1oAmS2rtD LnJr8S0H59oJA== Date: Wed, 24 Mar 2021 10:41:35 -0700 From: Nathan Chancellor To: Masahiro Yamada Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Catalin Marinas , Will Deacon Subject: Re: [PATCH] arm64: move --fix-cortex-a53-843419 linker test to Kconfig Message-ID: <20210324174135.umlsyuzjvspq5rdz@archlinux-ax161> References: <20210324071128.1723273-1-masahiroy@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210324071128.1723273-1-masahiroy@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210324_174141_460898_E8155205 X-CRM114-Status: GOOD ( 25.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Mar 24, 2021 at 04:11:28PM +0900, Masahiro Yamada wrote: > $(call ld-option, --fix-cortex-a53-843419) in arch/arm64/Makefile is > evaluated every time even for Make targets that do not need the linker, > such as "make ARCH=arm64 install". > > Recently, the Kbuild tree queued up a patch to avoid needless > compiler/linker flag evaluation. I beleive it is a good improvement > itself, but causing a false-positive warning for arm64 installation > in linux-next. (Thanks to Nathan for the report) > > Kconfig can test the linker capability just once, and store it in the > .config file. The build and installation steps that follow do not need > to test the liniker over again. > > Reported-by: Nathan Chancellor > Signed-off-by: Masahiro Yamada Tested-by: Nathan Chancellor Reviewed-by: Nathan Chancellor Thanks for the quick fix! > --- > > I was not sure what the preferred CONFIG option name is. > Please suggest a one if you have a better idea. > > > arch/arm64/Kconfig | 3 +++ > arch/arm64/Makefile | 2 +- > 2 files changed, 4 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig > index 5656e7aacd69..4a33428de8ac 100644 > --- a/arch/arm64/Kconfig > +++ b/arch/arm64/Kconfig > @@ -521,6 +521,9 @@ config ARM64_ERRATUM_843419 > > If unsure, say Y. > > +config ARM64_LD_HAS_FIX_ERRATUM_843419 > + def_bool $(ld-option,--fix-cortex-a53-843419) > + > config ARM64_ERRATUM_1024718 > bool "Cortex-A55: 1024718: Update of DBM/AP bits without break before make might result in incorrect update" > default y > diff --git a/arch/arm64/Makefile b/arch/arm64/Makefile > index 5b84aec31ed3..7ef44478560d 100644 > --- a/arch/arm64/Makefile > +++ b/arch/arm64/Makefile > @@ -21,7 +21,7 @@ LDFLAGS_vmlinux += -shared -Bsymbolic -z notext \ > endif > > ifeq ($(CONFIG_ARM64_ERRATUM_843419),y) > - ifeq ($(call ld-option, --fix-cortex-a53-843419),) > + ifneq ($(CONFIG_ARM64_LD_HAS_FIX_ERRATUM_843419),y) > $(warning ld does not support --fix-cortex-a53-843419; kernel may be susceptible to erratum) > else > LDFLAGS_vmlinux += --fix-cortex-a53-843419 > -- > 2.27.0 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel