From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B126DC433DB for ; Thu, 25 Mar 2021 14:37:02 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4D2D4619FC for ; Thu, 25 Mar 2021 14:37:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4D2D4619FC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Jw4bd/LE+DfJE8HDCZuI7xeNtxoomfdWHFZw1s6xR70=; b=MSSPJ3mWiHIR2WfYnbp5sRLzL tQsl96FboLpok58x7flIUP7MRvR+EK2rWiWQKm1HHASyhtsq4+QxX1kt3gLC0pFqas3EqWUDkLo5Z 21YzhMo1SIE5fU2CXPzMgZOMDDFd8vGIcHgp5xEdBEZKmHxFHENbzpY84Gl4gS0E9SUeaxFN3BIk5 XExAhAZaG79o0clTq+zxfCRb7qhfok35AcMgyx52mafcZDD281GHKVxSrHXPJIKaOg4yHFqt0FDmq Y+mCK/yv2wQZvuCmS4hYRFZfQF0ZodbkdLwATd1/Pqa+SlrmSrzoTE0H1UmQ1MzHFZBi8ObrZy3xA rsEyTONeQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lPR4c-001cwF-8k; Thu, 25 Mar 2021 14:34:58 +0000 Received: from foss.arm.com ([217.140.110.172]) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lPR4U-001cqy-Ge for linux-arm-kernel@lists.infradead.org; Thu, 25 Mar 2021 14:34:53 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D629F143D; Thu, 25 Mar 2021 07:34:48 -0700 (PDT) Received: from C02TD0UTHF1T.local (unknown [10.57.22.175]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 991D13F792; Thu, 25 Mar 2021 07:34:47 -0700 (PDT) Date: Thu, 25 Mar 2021 14:34:33 +0000 From: Mark Rutland To: Linus Walleij Cc: Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] arm64: barrier: Remove spec_bar() macro Message-ID: <20210325143433.GA41100@C02TD0UTHF1T.local> References: <20210325141304.1607595-1-linus.walleij@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210325141304.1607595-1-linus.walleij@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210325_143451_032500_23DD80C1 X-CRM114-Status: GOOD ( 19.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Mar 25, 2021 at 03:13:04PM +0100, Linus Walleij wrote: > The spec_bar() macro was introduced in > commit bd4fb6d270bc ("arm64: Add support for SB barrier and patch in over DSB; ISB sequences") > as a way for C to insert a speculation barrier and was then > used in one single place: set_fs(). > > Later on > commit 3d2403fd10a1 ("arm64: uaccess: remove set_fs()") > deleted set_fs() altogether and as noted in the commit > on the new path the regular sb() assembly macro will > be used. > > Delete the remnant. > > Cc: Mark Rutland > Fixes: 3d2403fd10a1 ("arm64: uaccess: remove set_fs()") > Signed-off-by: Linus Walleij I think this is a cleanup rather than a fix, so we don't need the fixes tag. I don't have a problem with this going, so with the fixes tag removed: Acked-by: Mark Rutland Mark. > --- > arch/arm64/include/asm/barrier.h | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/arch/arm64/include/asm/barrier.h b/arch/arm64/include/asm/barrier.h > index c3009b0e5239..bab29932d21b 100644 > --- a/arch/arm64/include/asm/barrier.h > +++ b/arch/arm64/include/asm/barrier.h > @@ -25,10 +25,6 @@ > #define psb_csync() asm volatile("hint #17" : : : "memory") > #define csdb() asm volatile("hint #20" : : : "memory") > > -#define spec_bar() asm volatile(ALTERNATIVE("dsb nsh\nisb\n", \ > - SB_BARRIER_INSN"nop\n", \ > - ARM64_HAS_SB)) > - > #ifdef CONFIG_ARM64_PSEUDO_NMI > #define pmr_sync() \ > do { \ > -- > 2.29.2 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel