From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0185FC433DB for ; Thu, 25 Mar 2021 15:01:09 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 74B7F61A0F for ; Thu, 25 Mar 2021 15:01:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 74B7F61A0F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=jnqbxVF4F1KXmXpBfpmRJeICddlV05nSBbENLvxN8oU=; b=b4FhPnGfUaHUo+b3OfecbZJC5 21wI2jG5uqHuUj3ZHmYELMi6KuWLmLy4/mNnatJJvQkDPoMopsGc/Tm5c2omJFCCxua8RKhB7yZZp 1QrnCiv8SYoGPVCFkU/t9jqXh3vCMeQG2buqowuMegOWiqnWbN0jjnYBHCBMsMrlnf7hMMFJsbmeq bkjio+0mFFPwzENbEco39E3OO5HQuv/tCD7IPDhwejJqX8yi4Rm38tkYgwMyXiD/J6oJvV4SZywe7 gU2/pbvkHsmn9iOnoS5a/BoQaNqawQTbYUCxnLQkAKZROGkw7SeGMSbhlXtNbm6voSndOZvKHaztB ustCC7sAg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lPRSI-001g48-1x; Thu, 25 Mar 2021 14:59:26 +0000 Received: from mail.kernel.org ([198.145.29.99]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lPRSC-001g3f-UD for linux-arm-kernel@lists.infradead.org; Thu, 25 Mar 2021 14:59:22 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 639D761A0F; Thu, 25 Mar 2021 14:59:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1616684359; bh=89AGHW8+EGljajNu3MeDUxKz32WiCO/dlRAg9lyx4E0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fep51D+SIvV5jSZcW9owmJSuzKzyyLLLg2XN/qCGWZ+qHqrK/LUNvSejDMve94DQX S2/d68ADk9fkxRsyOA78tbwmCHXVQh0KsnN16vvrYaros1o7/oFo6J9zDgwhO13Pux z8U0Ok9Re9RE6swGihXG0JdUaj6Xey11G6DFPD/gOT3vrcLfRwnp6TaaSJ+eyvGZ8+ nLO2r+LobX5kzawTf6w21AG67oRDcmu3SMMJA/6n/ovJQwRTK2Ha06xj1yl5JeuUSn 4kp46VoJqmsfkifEUBGVEW8OVXVPQT9yHz7ldBqY0yw1/1XJ6GCIEHsZlCMtUAEE6Y 1ZXPIkoipMPXQ== Date: Thu, 25 Mar 2021 14:59:15 +0000 From: Will Deacon To: Shawn Guo , lorenzo.pieralisi@arm.com Cc: Robin Murphy , Bjorn Andersson , linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH] iommu/arm-smmu-qcom: create qcom_smmu_impl for ACPI boot Message-ID: <20210325145914.GC15172@willie-the-truck> References: <20210301074021.20059-1-shawn.guo@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210301074021.20059-1-shawn.guo@linaro.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210325_145921_216675_10F16047 X-CRM114-Status: GOOD ( 13.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org [+ Lorenzo] On Mon, Mar 01, 2021 at 03:40:21PM +0800, Shawn Guo wrote: > Though qcom_adreno_smmu_impl is not used by ACPI boot right now, > qcom_smmu_impl is already required at least to boot up Lenovo Flex 5G > laptop. Let's check asl_compiler_id in IORT header to ensure we are > running a QCOM SMMU and create qcom_smmu_impl for it. > > !np is used to check ACPI boot, because fwnode of SMMU device is > a static allocation and thus has_acpi_companion() doesn't work here. > > Signed-off-by: Shawn Guo > --- > drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c | 33 ++++++++++++++++++++++ > 1 file changed, 33 insertions(+) I don't know what a "asl_compiler_id" is, but it doesn't sound like it has an awful lot to do with the SMMU. Lorenzo -- any idea what we should be doing here instead? Probably not using ACPI? Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel