From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E296C433E0 for ; Thu, 25 Mar 2021 17:05:06 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1BF5A61A16 for ; Thu, 25 Mar 2021 17:05:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1BF5A61A16 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ErPU/KfzDAeqyyVGnqHpYUZzvskPSFhCSlykFr4hkSw=; b=PjoldYzx3V6+V5p6V5cE3zMwB ih9r7XUiGZDODP0wugxTIDsQxjeGXh6MJ5swCl5/aRGQR3oXG8sdkhdN5IbQYQgi80LzXvQPChPi1 Kf8zvwC+RCOogJs/y++m//MAvwDrBykk9pTS9h1/yzJdXOFfraFZmrcOpywRSc6XF3WJ9AWCzw5cY OZsbES0q98nbO3jfCSo6Qv/PO/7Bp3jl0kQSryLoUXkEytYVeudC7o8++GIW5yDbCLrMQQPKFkqm+ 4LNOt7ZpICLZ5SDXu79PA6rGWzrqKs+mbtkRLyzvMIHhCXyeBJC1YwBADmzv15mlhZXELtsCqqxwl CucsNKM6A==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lPTNx-001s3A-Pk; Thu, 25 Mar 2021 17:03:05 +0000 Received: from mail-oi1-x22e.google.com ([2607:f8b0:4864:20::22e]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lPTNt-001s2L-72 for linux-arm-kernel@lists.infradead.org; Thu, 25 Mar 2021 17:03:03 +0000 Received: by mail-oi1-x22e.google.com with SMTP id a8so2787630oic.11 for ; Thu, 25 Mar 2021 10:03:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=wWPXhqdD+6tI05MivtckeKrepPnDQMjU+zHRBIZrqSA=; b=oJrDWezcCTqUggAw7El3CjJwi79kw9zFvmH8x2oL31DoKNlHN0pF283NKszWNG0L76 WdyS3hYlPlmatNw4fhFPVPbpXh3EtPdKPnvTh+giO/vsUJILOQKQOhR+crlh8qhQlSum ElIAzvaGKr6uhaVRMkVDzpsFKez6LfbAvqhA5A3hC4uyD+qUTYaFSbbpLbfrp41FFGKd d9BkngB4hhqh+KGE9DqmssDd7YDudsb7skxDLemFctvlEVRPDwxrKnUJGD1WLsdqSOZQ UCi5cQ3iNxzrryljH19rn6AgYPg+1pWfuBr7NOyAoOpnyTjOQsCftogJ9lDZr6z/ClNQ xIjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=wWPXhqdD+6tI05MivtckeKrepPnDQMjU+zHRBIZrqSA=; b=a8s+KshFNApEfqdlmNn+upjqCi2rppG7bRdpcy2g7AdCzyWZtfXOmy9FEUQTOFr/1H en46KvSoo1IcZn3SdgrzvzPaIQ9tL5nZsWG2pZsS94Nh4taTDVJS1bqfHk+Ur43mutBB VBoRXca8Q2Xc4Wh3lKqezWUe4JN01JdKJM3eZOtA/RKxFi5CzsEvLg3uHgGMRt3X/AvH ARrU7vpK6OlYuckNitYwLMGl6HkeGKCz29Wk9jDUBvtkhHa/xNAQGzgS1VwTh/F10aIl RsTSPrkHQ/0os66mnF8NF1fV+CesMR6oS09m7XI4W2SRbGZgoPn0vGLsGxjFqeDVB3YR urHA== X-Gm-Message-State: AOAM531JyJJ6BHeQ7Kdx3/4koMjYyxNbkLBAMxCnstxTKAd4fKirPhM/ SPMVgDAM+UnXpf0GHG7AsKtxgg== X-Google-Smtp-Source: ABdhPJwWxU1ru7SaSik7Cy8ypCPiAxwuwNtXQ1sFRK+6ioXk6PX6XiolViLhiYWs6vXC7RNk5StewA== X-Received: by 2002:a54:4494:: with SMTP id v20mr6853153oiv.147.1616691779417; Thu, 25 Mar 2021 10:02:59 -0700 (PDT) Received: from yoga (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id d26sm1340852oos.32.2021.03.25.10.02.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Mar 2021 10:02:59 -0700 (PDT) Date: Thu, 25 Mar 2021 12:02:56 -0500 From: Bjorn Andersson To: Will Deacon Cc: Shawn Guo , lorenzo.pieralisi@arm.com, Robin Murphy , linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH] iommu/arm-smmu-qcom: create qcom_smmu_impl for ACPI boot Message-ID: <20210325170256.GA904837@yoga> References: <20210301074021.20059-1-shawn.guo@linaro.org> <20210325145914.GC15172@willie-the-truck> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210325145914.GC15172@willie-the-truck> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210325_170301_361028_8EA7407D X-CRM114-Status: GOOD ( 21.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu 25 Mar 09:59 CDT 2021, Will Deacon wrote: > [+ Lorenzo] > > On Mon, Mar 01, 2021 at 03:40:21PM +0800, Shawn Guo wrote: > > Though qcom_adreno_smmu_impl is not used by ACPI boot right now, > > qcom_smmu_impl is already required at least to boot up Lenovo Flex 5G > > laptop. Let's check asl_compiler_id in IORT header to ensure we are > > running a QCOM SMMU and create qcom_smmu_impl for it. > > > > !np is used to check ACPI boot, because fwnode of SMMU device is > > a static allocation and thus has_acpi_companion() doesn't work here. > > > > Signed-off-by: Shawn Guo > > --- > > drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c | 33 ++++++++++++++++++++++ > > 1 file changed, 33 insertions(+) > > I don't know what a "asl_compiler_id" is, but it doesn't sound like it > has an awful lot to do with the SMMU. > I would prefer that we somehow relate this to the particular board, rather than all Qualcomm-related ACPI tables. E.g. by relying on the SMMU devices having a _HID of QCOM0409. Shawn, any reason for this wouldn't be possible? > Lorenzo -- any idea what we should be doing here instead? Probably not > using ACPI? > The 8cx (aka sc8180x) platform comes with Qualcomm's usual SMMU stream-mapping quirks and this is one of the patches needed to bring enough ACPI support to run the Debian installer that Shawn has been working on. After the installer we currently only boot this using DT - which already enables the quirk. Regards, Bjorn _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel