From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C43A8C433C1 for ; Fri, 26 Mar 2021 04:36:48 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5533E61A26 for ; Fri, 26 Mar 2021 04:36:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5533E61A26 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Fi5p9jF+PE9ZiZGVJpd+HXd+9Mdoe78jEVS5HPFbPfs=; b=j3v6G6TUs86MWoxzB+xSlOY95 lRGhJG1oOJU64b7R3n+NY7PX0a7W48xwI4U4HxTrgFqINDMzKbOPON5KZta4lytGlSWwERDF55FV0 tbRrX2ITuUlwcEF9m6wp/4w7muR4atXpIentPwhX6TZW9vB5rq326FTrGvUMhFFD9MXARG+CgAPD/ 0dXIUlIicXDpibmCDYJW25Xqq1Yk7BNe5u0UpNZp2Re0tJVNa4PxfgxcTZa4YJXk3GyfaJzjcpNRr 3nCJYKBI1HUvN3k06zkr+R84upfHsRtPdSfa1MSxgdeUJE4ytdYQeIP36Xtt6TmzlVCBqMR1uUGa5 N4RSR79Vg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lPeBe-002lBA-6a; Fri, 26 Mar 2021 04:35:06 +0000 Received: from mail-pg1-x532.google.com ([2607:f8b0:4864:20::532]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lPeBU-002l9P-Pr for linux-arm-kernel@lists.infradead.org; Fri, 26 Mar 2021 04:35:03 +0000 Received: by mail-pg1-x532.google.com with SMTP id l76so3777563pga.6 for ; Thu, 25 Mar 2021 21:34:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ZznyDRg62Aq1s1+p2944fwJCGEKWMFo0KzijBRVLdmY=; b=TIB4PsMHJfphVL92/msg3G5qMO4sc9Q0j+qrJPLXwTDkmFfcf0Ausc1NmOjXDUFjD1 GDkWCYMA3bUeziVVqzGGizG/fAmUwj8oXAFn38jaiwedU+5KjkHu1IQGatlAG01m56gy zq5vsbOryhA4183WK8CwjCtKavIwW9tgiaU9w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ZznyDRg62Aq1s1+p2944fwJCGEKWMFo0KzijBRVLdmY=; b=G6JWEgjvZkxQ+ZBf45OsvO5l9E1Z9gXB1upPtZtX2n4m4bBjsJqNdiVrmUVq6NNwTU I3ZaJY1ydP1zVe4K9U4gcsgMUJXXwM8XJ+ttpmZLL68GW0kn+Kg91hRX5RmztvfDyzqy as+RfcEZ6By+JqFcCYR9dew8JzJ0CO4mYGZNXE8E3jtFExU5Uai1yAt6xHWCm+X5O/lk e0S+3REUM6HklSkoVVVvBiP/+kEFcAZNWtCzfPqDEMf8YRavLuipNl1d2YammT1K6lMW uqbls7/dFJoTVj0nen0JO1HtNIibr/+as5EjXnHQvg8fEEMfi83e8QtQdx25gtRMcB2A B5Lw== X-Gm-Message-State: AOAM530Kea9U/WRB2nfQqLX0l1DoxaJsKEvrpcxCT/FbvSUugsnZoQh0 /0YYm/Ztq5N28dwi0/uTQU58vQ== X-Google-Smtp-Source: ABdhPJxBRCXJ1li4dH5xsPQG84q9505VJQO+4Hhbb6bLG6ZNByyMdRrV56Yf27GEeoRpH/Z6b/yttg== X-Received: by 2002:aa7:8e8f:0:b029:1f1:5a1a:7f82 with SMTP id a15-20020aa78e8f0000b02901f15a1a7f82mr11057824pfr.52.1616733295456; Thu, 25 Mar 2021 21:34:55 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id w191sm8543354pfd.25.2021.03.25.21.34.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Mar 2021 21:34:54 -0700 (PDT) Date: Thu, 25 Mar 2021 21:34:54 -0700 From: Kees Cook To: Sami Tolvanen Cc: Nathan Chancellor , Nick Desaulniers , Masahiro Yamada , Will Deacon , Jessica Yu , Arnd Bergmann , Tejun Heo , "Paul E. McKenney" , Christoph Hellwig , Peter Zijlstra , bpf@vger.kernel.org, linux-hardening@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kbuild@vger.kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 05/17] workqueue: use WARN_ON_FUNCTION_MISMATCH Message-ID: <202103252134.03274C44@keescook> References: <20210323203946.2159693-1-samitolvanen@google.com> <20210323203946.2159693-6-samitolvanen@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210323203946.2159693-6-samitolvanen@google.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210326_043459_429327_78F2E4AA X-CRM114-Status: GOOD ( 14.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Mar 23, 2021 at 01:39:34PM -0700, Sami Tolvanen wrote: > With CONFIG_CFI_CLANG, a callback function passed to > __queue_delayed_work from a module points to a jump table entry > defined in the module instead of the one used in the core kernel, > which breaks function address equality in this check: > > WARN_ON_ONCE(timer->function != delayed_work_timer_fn); > > Use WARN_ON_FUNCTION_MISMATCH() instead to disable the warning > when CFI and modules are both enabled. > > Signed-off-by: Sami Tolvanen Reviewed-by: Kees Cook -- Kees Cook _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel