From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78E70C433DB for ; Thu, 25 Mar 2021 23:03:07 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F3FA8619BA for ; Thu, 25 Mar 2021 23:03:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F3FA8619BA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=eSB/tgMdp0UWZP/TM5bYKW2pLY3quOYjUfF6mZwIbAM=; b=RREVS/CXum7DCXfBnXL6eEwtL M6z/fD3qSnkt3KBRYcLzpPb9WXLHWTguk7qOnO3bvz6PlqYBr0FKMdhzudlsW55BB+MLi5lfJZsaV as7w1L6LS8OnC51oNMPf9QXw+GqeGA6O/x3EVlhPNnDeo8owCm7inhFjFuwVnw2ddblYaqVprZOXo GQsqCizWBi57ssJSXegXTgT9rAmOaFPTJNCTXAUjlyzp54wQQGdAXmKm0pOVeh9+eKzNJVZ4esZc1 RBIgA82MwVq1Jp8sUa+eA8Go4VWvqIm8CD3E+ZoIMy5Ag2Z0OnJEObHO8y/iD/FzW6FO6In6Bv0nd ZAHIcKJww==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lPYyK-002KV2-Ac; Thu, 25 Mar 2021 23:01:00 +0000 Received: from mail-pg1-x529.google.com ([2607:f8b0:4864:20::529]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lPYyD-002KUT-CS for linux-arm-kernel@lists.infradead.org; Thu, 25 Mar 2021 23:00:55 +0000 Received: by mail-pg1-x529.google.com with SMTP id f10so3301083pgl.9 for ; Thu, 25 Mar 2021 16:00:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=NYtrjNLVWQTr/dq5ZWJC4E1PqUHmp98t32XFTCKiVw4=; b=EZmqD8jxmBdlgeO8EZfB3JDqfJgcDTb2IC+XJ4WgJherysg5+d+VrBiP1bRB/J6gai iq+bZmftHKnQiXYr9d7eBdUTXkLaRGYv0U983t6Usk8Dsuq+ou5WiS1TLizGOl6Ec+J+ Bvk/Yz5W80G3YVgJMpNz7nSR8y1/G318t/iLk7y3oOZUYFbBdqLdndcQms9GLeKNJCyH DcH3qvHPg4NgUbNW5JqbzJdV1Nbq2ceomWP7PCS5PozXk/AiNyIO2sUiWs63qd8Au6Vj BYfsWoWk9tlUdVSjKhoeUoR+SWjYjvp7/3pYjA6MgpzoDEtQQBK3Uw+tAcCFfGdiG0pw Ff0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=NYtrjNLVWQTr/dq5ZWJC4E1PqUHmp98t32XFTCKiVw4=; b=WR5RsuxRT/0tX2XGS4fQ5hwLEcYcX86YXTTRo5w0dSS+IqFc/Rimw1aVdSCVHyAkhf mj1AUmhL60TuCUrKyv8LyuCCWus9tgvSqA/D3WVS56DejCwZVl2hRt/etPIcbHMz6eW+ oCIbJMske5Gm835aM1BNZNK9NHfQ8TB4grBae2F0rZ6Li9EsbXgZdOCxznaKk6D1FWxw KJaVPt4SgbR/JQ0CwPFgl2wrMpzAZwbz/MWTirUPzXeTcAuVPddXcg87UpoYD5ErTFs8 TkxxtWGZJ3CY1+UvwbB/0TgUB81TA/hPP4PBWRGT9+ul+2BHLNR+IOgDCGXMPaUMAbZV /vfQ== X-Gm-Message-State: AOAM533yVazas6XpXS/vIIdNPRyh+zVyXp/GKJVBWdtl/6+EJh1kACOa oOkcl7ClPpT0XUOJ46eXF40g0w== X-Google-Smtp-Source: ABdhPJzvKiD1Kv9upD760EFR6AfmRIrLbT435H9CLx1xpc+/w2S9Ah1dIAy8zg0+rg3yq1M4Fx9J3Q== X-Received: by 2002:aa7:86c1:0:b029:203:900:2813 with SMTP id h1-20020aa786c10000b029020309002813mr9748625pfo.35.1616713249127; Thu, 25 Mar 2021 16:00:49 -0700 (PDT) Received: from xps15 (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id c6sm6810901pfj.99.2021.03.25.16.00.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Mar 2021 16:00:44 -0700 (PDT) Date: Thu, 25 Mar 2021 17:00:42 -0600 From: Mathieu Poirier To: "Peng Fan (OSS)" Cc: ohad@wizery.com, bjorn.andersson@linaro.org, o.rempel@pengutronix.de, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, linux-remoteproc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan Subject: Re: [PATCH 1/2] remoteproc: imx_rproc: enlarge IMX7D_RPROC_MEM_MAX Message-ID: <20210325230042.GB1982573@xps15> References: <20210319104708.7754-1-peng.fan@oss.nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210319104708.7754-1-peng.fan@oss.nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210325_230053_622141_F0E179A1 X-CRM114-Status: GOOD ( 26.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Peng, On Fri, Mar 19, 2021 at 06:47:07PM +0800, Peng Fan (OSS) wrote: > From: Peng Fan > > 8 is not enough when we need more, so enlarge IMX7D_RPROC_MEM_MAX to 32, > and also rename it to IMX_RPROC_MEM_MAX which make more sense. > > Signed-off-by: Peng Fan > --- > drivers/remoteproc/imx_rproc.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c > index 6d3207ccbaef..24275429a7cc 100644 > --- a/drivers/remoteproc/imx_rproc.c > +++ b/drivers/remoteproc/imx_rproc.c > @@ -48,7 +48,7 @@ > | IMX6SX_SW_M4C_NON_SCLR_RST \ > | IMX6SX_SW_M4C_RST) > > -#define IMX7D_RPROC_MEM_MAX 8 > +#define IMX_RPROC_MEM_MAX 32 The size of structure imx_rproc_att_imx7d and imx_rproc_att_imx6sx have not changed nor has there been an addition of new imx_rproc_att that would justify the change. It seems to me you are working on something internally and this patch is in preparation for that. If that is the case then please resubmit this patch with the rest of the code. Thanks, Mathieu > > /** > * struct imx_rproc_mem - slim internal memory structure > @@ -88,7 +88,7 @@ struct imx_rproc { > struct regmap *regmap; > struct rproc *rproc; > const struct imx_rproc_dcfg *dcfg; > - struct imx_rproc_mem mem[IMX7D_RPROC_MEM_MAX]; > + struct imx_rproc_mem mem[IMX_RPROC_MEM_MAX]; > struct clk *clk; > struct mbox_client cl; > struct mbox_chan *tx_ch; > @@ -272,7 +272,7 @@ static void *imx_rproc_da_to_va(struct rproc *rproc, u64 da, size_t len, bool *i > if (imx_rproc_da_to_sys(priv, da, len, &sys)) > return NULL; > > - for (i = 0; i < IMX7D_RPROC_MEM_MAX; i++) { > + for (i = 0; i < IMX_RPROC_MEM_MAX; i++) { > if (sys >= priv->mem[i].sys_addr && sys + len < > priv->mem[i].sys_addr + priv->mem[i].size) { > unsigned int offset = sys - priv->mem[i].sys_addr; > @@ -425,7 +425,7 @@ static int imx_rproc_addr_init(struct imx_rproc *priv, > if (!(att->flags & ATT_OWN)) > continue; > > - if (b >= IMX7D_RPROC_MEM_MAX) > + if (b >= IMX_RPROC_MEM_MAX) > break; > > priv->mem[b].cpu_addr = devm_ioremap(&pdev->dev, > @@ -459,7 +459,7 @@ static int imx_rproc_addr_init(struct imx_rproc *priv, > return err; > } > > - if (b >= IMX7D_RPROC_MEM_MAX) > + if (b >= IMX_RPROC_MEM_MAX) > break; > > /* Not use resource version, because we might share region */ > -- > 2.30.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel