From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28173C433C1 for ; Fri, 26 Mar 2021 11:04:13 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B782B61A0D for ; Fri, 26 Mar 2021 11:04:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B782B61A0D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=xbLFU4PKAFW4ZEw0VYjak+62lt+t+jXqY5xTb+ROy6U=; b=dL8Bbbs8z3IuYvK7TwgFwIG96 AA038BzHxjBalvqxzFN6lW/frU+4egsYxfsXSW0pxSXHHU3JJVIVC3N5g85TREF8vr42Vwgf74UhY H4fGd4H/lOhDki6Bb8MmshOjrIaJW2ZPfLmeM8cc36LFR23ONFpE4wm1GzxH1DGMNnzM1Jv6USvY/ p7wOHnFXklmbEGc7/XkcFy0YZQl/oqitC1OL0MLFNLDHN2gmzIs3XOxYb78kiSj/b+EyZOxyUJzGM duchrn6cangQUVDc7sW+PqFH1XkLm9bwSONYLAKj35l149nSHfSVnA5PuWONNhS1SdYyQQlaObC42 SageDk+GA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lPkEm-003NJf-TD; Fri, 26 Mar 2021 11:02:45 +0000 Received: from foss.arm.com ([217.140.110.172]) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lPkEi-003NIx-4E for linux-arm-kernel@lists.infradead.org; Fri, 26 Mar 2021 11:02:42 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id DF7EE143D; Fri, 26 Mar 2021 04:02:37 -0700 (PDT) Received: from e120937-lin (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A49523F7D7; Fri, 26 Mar 2021 04:02:35 -0700 (PDT) Date: Fri, 26 Mar 2021 11:02:29 +0000 From: Cristian Marussi To: Stephen Boyd Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, sudeep.holla@arm.com, lukasz.luba@arm.com, james.quinlan@broadcom.com, Jonathan.Cameron@Huawei.com, f.fainelli@gmail.com, etienne.carriere@linaro.org, thara.gopinath@linaro.org, vincent.guittot@linaro.org, souvik.chakravarty@arm.com, Michael Turquette Subject: Re: [PATCH v7 18/38] clk: scmi: port driver to the new scmi_clk_proto_ops interface Message-ID: <20210326110229.GB43717@e120937-lin> References: <20210316124903.35011-1-cristian.marussi@arm.com> <20210316124903.35011-19-cristian.marussi@arm.com> <161671733901.3012082.11186673559577220910@swboyd.mtv.corp.google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <161671733901.3012082.11186673559577220910@swboyd.mtv.corp.google.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210326_110240_732507_A13E9F5E X-CRM114-Status: GOOD ( 17.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Mar 25, 2021 at 05:08:59PM -0700, Stephen Boyd wrote: > Sorry didn't notice because linux-clk@vger.kernel.org wasn't Cced > Ah, sorry my bad. > Quoting Cristian Marussi (2021-03-16 05:48:43) > > Port driver to the new SCMI Clock interface based on protocol handles > > and common devm_get_ops(). > > > > Cc: Michael Turquette > > Cc: Stephen Boyd > > Signed-off-by: Cristian Marussi > > --- > > v6 -> v7 > > - fixed Copyright > > - renamed non-static function to fit scmi__ naming pattern > > v4 --> v5 > > - using renamed devm_get/put_protocol > > --- > > drivers/clk/clk-scmi.c | 27 +++++++++++++++++---------- > > 1 file changed, 17 insertions(+), 10 deletions(-) > > > > diff --git a/drivers/clk/clk-scmi.c b/drivers/clk/clk-scmi.c > > index c754dfbb73fd..be4c13d63385 100644 > > --- a/drivers/clk/clk-scmi.c > > +++ b/drivers/clk/clk-scmi.c > > @@ -2,7 +2,7 @@ > > /* > > * System Control and Power Interface (SCMI) Protocol based clock driver > > * > > - * Copyright (C) 2018 ARM Ltd. > > + * Copyright (C) 2018-2021 ARM Ltd. > > */ > > > > #include > > @@ -13,11 +13,13 @@ > > #include > > #include > > > > +static const struct scmi_clk_proto_ops *clk_ops; > > Can you call it scmi_proto_clk_ops instead of clk_ops? We already have > 'struct clk_ops' and this pollutes the global namespace with another > 'clk_ops'. > Sure I'll do and reply on this thread and CCing linux-clk with the fix. Thanks Cristian > > + > > struct scmi_clk { > > u32 id; > > struct clk_hw hw; > > const struct scmi_clock_info *info; > > - const struct scmi_handle *handle; > > + const struct scmi_protocol_handle *ph; > > }; > > > > #define to_scmi_clk(clk) container_of(clk, struct scmi_clk, hw) _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel