From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C73CC433C1 for ; Fri, 26 Mar 2021 13:43:01 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9B97661A18 for ; Fri, 26 Mar 2021 13:43:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9B97661A18 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=yvQvvQU7+SmvqdsRcK5uAqQrEQIeSLzEF5iH2rgaPrU=; b=VI5G0BFNANVspL+pHFcOW9C+U tSISA0nMaPa1tkNaKk6hgrn0D8K9+a07bQTCMCgnb21O+PwelLOcK+emo3rzDjkLo9LKTn/8aPl2z kt/qjeRSVisR8epBqH+6YkaFmpeR3Kl4ChEfueBaNPRAMaKh39QFDUsrWbYpoXUJnhCM4S2U4Jwma ThbNrEpORNfHlAPNtg2hvXdxYhDv8nCm6iBGLt3FGCSBJmRdmWEzvtS1MTDrvSKzgvxw5SCH3aVYA VkvJ73+Gn/Epc8pzMaNKy+prHS2SlidvbB4cnjn+CY7kMeb3s+GpZakaeKukqhHqSbyvqLZQxPfuF 5vnrvLyQw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lPmie-003caI-I6; Fri, 26 Mar 2021 13:41:44 +0000 Received: from foss.arm.com ([217.140.110.172]) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lPmiX-003cYp-DV for linux-arm-kernel@lists.infradead.org; Fri, 26 Mar 2021 13:41:39 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7649A143D; Fri, 26 Mar 2021 06:41:34 -0700 (PDT) Received: from bogus (unknown [10.57.54.194]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 6535E3F7D7; Fri, 26 Mar 2021 06:41:33 -0700 (PDT) Date: Fri, 26 Mar 2021 13:41:31 +0000 From: Sudeep Holla To: Arnd Bergmann Cc: Linus Walleij , Sudeep Holla , Viresh Kumar , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ARM: vexpress: spc: fix uniprocessor initialization Message-ID: <20210326134131.bftspszcwixrkomt@bogus> References: <20210323125649.1930186-1-arnd@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210323125649.1930186-1-arnd@kernel.org> User-Agent: NeoMutt/20171215 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210326_134137_903551_36252DB0 X-CRM114-Status: GOOD ( 13.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Arnd, Sorry for the delay On Tue, Mar 23, 2021 at 01:56:38PM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > When CONFIG_SMP is disabled, topology_physical_package_id() > returns -1 and gcc notices undefined behavior: > > arch/arm/mach-versatile/spc.c: In function 've_spc_clk_init': > arch/arm/mach-versatile/spc.c:583:21: error: array subscript -1 is below array bounds of 'bool[2]' {aka '_Bool[2]'} [-Werror=array-bounds] > 583 | if (init_opp_table[cluster]) > | ~~~~~~~~~~~~~~^~~~~~~~~ > arch/arm/mach-versatile/spc.c:556:7: note: while referencing 'init_opp_table' > 556 | bool init_opp_table[MAX_CLUSTERS] = { false }; > | ^~~~~~~~~~~~~~ > > It's not clear to me what the correct behavior should be, but > it seems safe to just not continue with the initialization. > I don't have any other patches for vexpress platform or driver support. Can you apply this directly ? Assuming that, Acked-by: Sudeep Holla -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel