From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACF99C433E0 for ; Fri, 26 Mar 2021 16:57:59 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 46CE661A26 for ; Fri, 26 Mar 2021 16:57:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 46CE661A26 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=pJu72r0QiSsxjFGA0obRGGFRR5C7nxqUb6RgwVvKW48=; b=J2qsEqmo7WBJHsHjKsBsceRb3 lnIOzLVPJkULv4nImCshb7+nF0EaVbQWZl9mI12p8Dpn0sB6+bx474pvayux/VBl+BkwtgZhiw4o0 tMTFkJak+WnyOG+MdBg7e62wiDo8ZIHxYYOaiLxSZ5LXnJFJgoiOFw5+qd9CeCmdDCdhSOzZ3vH2O UfCIevFqjiABQ6mmnOvHpJH2WjURgnp3MQCNFKJ1hwnE/0sf88g12Fw7zFZNYRRZrDp+jAlxNmRbE xuZ3bF9GgAlqUkAUgGQobRu0SBkez0zW7MUa7T+1yvE04L28M4vzaJLp1tMZ6RnwaqV1M8G0BS/z2 UvCS00ejg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lPpko-0041Qr-IH; Fri, 26 Mar 2021 16:56:10 +0000 Received: from mail-pf1-x42a.google.com ([2607:f8b0:4864:20::42a]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lPpkd-0041PD-GO for linux-arm-kernel@lists.infradead.org; Fri, 26 Mar 2021 16:56:02 +0000 Received: by mail-pf1-x42a.google.com with SMTP id c204so5268845pfc.4 for ; Fri, 26 Mar 2021 09:55:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=g1Uy9d+x52PS14PTvMAoQwDjVveA0DH36nttCERiI7Q=; b=a80H2ees3469kCcs67qote6p+j4n2tNGo8RNLAoAMqUMpoN82OvseR8XK+TG66Qu5v 0PVzeFP8EsXIyvK4fmAVhqzb6SyxPlOAo9IGUqPmjqB2EKS+D8g5cJPJkzM80b+DMWvv iOrXCIID1GPa8OcY+MSSiVzM6Jt0eeYcwTqlUz7ZxHK1ywcKW3BJjS5cSyWc9dCVb2bF ceEEv82gqNel0qdiT2sYmRsuTR9rqaMsgpwPav4kp+eo/Yb2ZfTDE50aAXCZhQ6Hhs6y HzFKmEPM7M94WI2QyOCU09bgpyvHhppfgWo9nWbTMNRY6Az5iRh0umL8oIt+sBpWAQcC +iEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=g1Uy9d+x52PS14PTvMAoQwDjVveA0DH36nttCERiI7Q=; b=oArF2mvGbySUbXYUO/D7IbEki6MvNyRtMlv+uDA23O9vc/Soy6d8odkIqvviC5lOvo xu2XhV30eywU1Ufe/kUZ/MQyD5YQIcNB2gvpRkSAyXp3rmL0fBvUUXX0NLaKPBqvpiyN kCSLU9er7KSd6kNYIzH8NiiRpuAmqbw88lnJx9eOE96NzS5B/FTCBNnNJ7ZbPko5YBtb 8/TH8TlDCHBN1moefEfmCr5kbkw0+CXMZDmJjqk6kCokaGnPJLCCAOLidJX7rMTZWqaI FNlWNbIp54ookpniP7bM0A3H6om2ndcsw5uDHAr7fMWvy2d25z0Wz0Zsb2Hux34jv/4L /saQ== X-Gm-Message-State: AOAM533VOuRRv2pTziiWadjhXm4r70wJgz6/h0WeWS3cQ2gFujhGVnOJ Ui2Y+3tzu09VaynoBzaJKte7hA== X-Google-Smtp-Source: ABdhPJwhCjn44fCVQZLhcoMOf6r9qgzuhYaQwAyZDN6Cjv9oWQA+4/uaPIRcWOxD4+Y+nREY62ghVA== X-Received: by 2002:a65:4942:: with SMTP id q2mr12817796pgs.34.1616777757859; Fri, 26 Mar 2021 09:55:57 -0700 (PDT) Received: from xps15 (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id k10sm9344744pfk.49.2021.03.26.09.55.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Mar 2021 09:55:53 -0700 (PDT) Date: Fri, 26 Mar 2021 10:55:50 -0600 From: Mathieu Poirier To: Suzuki K Poulose Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, coresight@lists.linaro.org, mike.leach@linaro.org, leo.yan@linaro.org, anshuman.khandual@arm.com, maz@kernel.org, catalin.marinas@arm.com, Will Deacon , Mark Rutland Subject: Re: [PATCH v5 07/19] arm64: kvm: Enable access to TRBE support for host Message-ID: <20210326165550.GC2009902@xps15> References: <20210323120647.454211-1-suzuki.poulose@arm.com> <20210323120647.454211-8-suzuki.poulose@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210323120647.454211-8-suzuki.poulose@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210326_165559_649761_B28F90BE X-CRM114-Status: GOOD ( 30.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Mar 23, 2021 at 12:06:35PM +0000, Suzuki K Poulose wrote: > For a nvhe host, the EL2 must allow the EL1&0 translation > regime for TraceBuffer (MDCR_EL2.E2TB == 0b11). This must > be saved/restored over a trip to the guest. Also, before > entering the guest, we must flush any trace data if the > TRBE was enabled. And we must prohibit the generation > of trace while we are in EL1 by clearing the TRFCR_EL1. > > For vhe, the EL2 must prevent the EL1 access to the Trace > Buffer. > > Cc: Will Deacon > Cc: Catalin Marinas > Cc: Marc Zyngier > Cc: Mark Rutland > Cc: Anshuman Khandual > Acked-by: Mathieu Poirier > Signed-off-by: Suzuki K Poulose > --- > arch/arm64/include/asm/el2_setup.h | 13 +++++++++ > arch/arm64/include/asm/kvm_arm.h | 2 ++ > arch/arm64/include/asm/kvm_host.h | 2 ++ > arch/arm64/kernel/hyp-stub.S | 3 ++- > arch/arm64/kvm/debug.c | 6 ++--- > arch/arm64/kvm/hyp/nvhe/debug-sr.c | 42 ++++++++++++++++++++++++++++++ > arch/arm64/kvm/hyp/nvhe/switch.c | 1 + > 7 files changed, 65 insertions(+), 4 deletions(-) > Marc - do you want me to pick up this one? > diff --git a/arch/arm64/include/asm/el2_setup.h b/arch/arm64/include/asm/el2_setup.h > index d77d358f9395..bda918948471 100644 > --- a/arch/arm64/include/asm/el2_setup.h > +++ b/arch/arm64/include/asm/el2_setup.h > @@ -65,6 +65,19 @@ > // use EL1&0 translation. > > .Lskip_spe_\@: > + /* Trace buffer */ > + ubfx x0, x1, #ID_AA64DFR0_TRBE_SHIFT, #4 > + cbz x0, .Lskip_trace_\@ // Skip if TraceBuffer is not present > + > + mrs_s x0, SYS_TRBIDR_EL1 > + and x0, x0, TRBIDR_PROG > + cbnz x0, .Lskip_trace_\@ // If TRBE is available at EL2 > + > + mov x0, #(MDCR_EL2_E2TB_MASK << MDCR_EL2_E2TB_SHIFT) > + orr x2, x2, x0 // allow the EL1&0 translation > + // to own it. > + > +.Lskip_trace_\@: > msr mdcr_el2, x2 // Configure debug traps > .endm > > diff --git a/arch/arm64/include/asm/kvm_arm.h b/arch/arm64/include/asm/kvm_arm.h > index 94d4025acc0b..692c9049befa 100644 > --- a/arch/arm64/include/asm/kvm_arm.h > +++ b/arch/arm64/include/asm/kvm_arm.h > @@ -278,6 +278,8 @@ > #define CPTR_EL2_DEFAULT CPTR_EL2_RES1 > > /* Hyp Debug Configuration Register bits */ > +#define MDCR_EL2_E2TB_MASK (UL(0x3)) > +#define MDCR_EL2_E2TB_SHIFT (UL(24)) > #define MDCR_EL2_TTRF (1 << 19) > #define MDCR_EL2_TPMS (1 << 14) > #define MDCR_EL2_E2PB_MASK (UL(0x3)) > diff --git a/arch/arm64/include/asm/kvm_host.h b/arch/arm64/include/asm/kvm_host.h > index 3d10e6527f7d..80d0a1a82a4c 100644 > --- a/arch/arm64/include/asm/kvm_host.h > +++ b/arch/arm64/include/asm/kvm_host.h > @@ -315,6 +315,8 @@ struct kvm_vcpu_arch { > struct kvm_guest_debug_arch regs; > /* Statistical profiling extension */ > u64 pmscr_el1; > + /* Self-hosted trace */ > + u64 trfcr_el1; > } host_debug_state; > > /* VGIC state */ > diff --git a/arch/arm64/kernel/hyp-stub.S b/arch/arm64/kernel/hyp-stub.S > index 5eccbd62fec8..05d25e645b46 100644 > --- a/arch/arm64/kernel/hyp-stub.S > +++ b/arch/arm64/kernel/hyp-stub.S > @@ -115,9 +115,10 @@ SYM_CODE_START_LOCAL(mutate_to_vhe) > mrs_s x0, SYS_VBAR_EL12 > msr vbar_el1, x0 > > - // Use EL2 translations for SPE and disable access from EL1 > + // Use EL2 translations for SPE & TRBE and disable access from EL1 > mrs x0, mdcr_el2 > bic x0, x0, #(MDCR_EL2_E2PB_MASK << MDCR_EL2_E2PB_SHIFT) > + bic x0, x0, #(MDCR_EL2_E2TB_MASK << MDCR_EL2_E2TB_SHIFT) > msr mdcr_el2, x0 > > // Transfer the MM state from EL1 to EL2 > diff --git a/arch/arm64/kvm/debug.c b/arch/arm64/kvm/debug.c > index dbc890511631..7b16f42d39f4 100644 > --- a/arch/arm64/kvm/debug.c > +++ b/arch/arm64/kvm/debug.c > @@ -89,7 +89,7 @@ void kvm_arm_reset_debug_ptr(struct kvm_vcpu *vcpu) > * - Debug ROM Address (MDCR_EL2_TDRA) > * - OS related registers (MDCR_EL2_TDOSA) > * - Statistical profiler (MDCR_EL2_TPMS/MDCR_EL2_E2PB) > - * - Self-hosted Trace Filter controls (MDCR_EL2_TTRF) > + * - Self-hosted Trace (MDCR_EL2_TTRF/MDCR_EL2_E2TB) > * > * Additionally, KVM only traps guest accesses to the debug registers if > * the guest is not actively using them (see the KVM_ARM64_DEBUG_DIRTY > @@ -107,8 +107,8 @@ void kvm_arm_setup_debug(struct kvm_vcpu *vcpu) > trace_kvm_arm_setup_debug(vcpu, vcpu->guest_debug); > > /* > - * This also clears MDCR_EL2_E2PB_MASK to disable guest access > - * to the profiling buffer. > + * This also clears MDCR_EL2_E2PB_MASK and MDCR_EL2_E2TB_MASK > + * to disable guest access to the profiling and trace buffers > */ > vcpu->arch.mdcr_el2 = __this_cpu_read(mdcr_el2) & MDCR_EL2_HPMN_MASK; > vcpu->arch.mdcr_el2 |= (MDCR_EL2_TPM | > diff --git a/arch/arm64/kvm/hyp/nvhe/debug-sr.c b/arch/arm64/kvm/hyp/nvhe/debug-sr.c > index f401724f12ef..9499e18dd28f 100644 > --- a/arch/arm64/kvm/hyp/nvhe/debug-sr.c > +++ b/arch/arm64/kvm/hyp/nvhe/debug-sr.c > @@ -58,10 +58,51 @@ static void __debug_restore_spe(u64 pmscr_el1) > write_sysreg_s(pmscr_el1, SYS_PMSCR_EL1); > } > > +static void __debug_save_trace(u64 *trfcr_el1) > +{ > + > + *trfcr_el1 = 0; > + > + /* Check if we have TRBE */ > + if (!cpuid_feature_extract_unsigned_field(read_sysreg(id_aa64dfr0_el1), > + ID_AA64DFR0_TRBE_SHIFT)) > + return; > + > + /* Check we can access the TRBE */ > + if ((read_sysreg_s(SYS_TRBIDR_EL1) & TRBIDR_PROG)) > + return; > + > + /* Check if the TRBE is enabled */ > + if (!(read_sysreg_s(SYS_TRBLIMITR_EL1) & TRBLIMITR_ENABLE)) > + return; > + /* > + * Prohibit trace generation while we are in guest. > + * Since access to TRFCR_EL1 is trapped, the guest can't > + * modify the filtering set by the host. > + */ > + *trfcr_el1 = read_sysreg_s(SYS_TRFCR_EL1); > + write_sysreg_s(0, SYS_TRFCR_EL1); > + isb(); > + /* Drain the trace buffer to memory */ > + tsb_csync(); > + dsb(nsh); > +} > + > +static void __debug_restore_trace(u64 trfcr_el1) > +{ > + if (!trfcr_el1) > + return; > + > + /* Restore trace filter controls */ > + write_sysreg_s(trfcr_el1, SYS_TRFCR_EL1); > +} > + > void __debug_save_host_buffers_nvhe(struct kvm_vcpu *vcpu) > { > /* Disable and flush SPE data generation */ > __debug_save_spe(&vcpu->arch.host_debug_state.pmscr_el1); > + /* Disable and flush Self-Hosted Trace generation */ > + __debug_save_trace(&vcpu->arch.host_debug_state.trfcr_el1); > } > > void __debug_switch_to_guest(struct kvm_vcpu *vcpu) > @@ -72,6 +113,7 @@ void __debug_switch_to_guest(struct kvm_vcpu *vcpu) > void __debug_restore_host_buffers_nvhe(struct kvm_vcpu *vcpu) > { > __debug_restore_spe(vcpu->arch.host_debug_state.pmscr_el1); > + __debug_restore_trace(vcpu->arch.host_debug_state.trfcr_el1); > } > > void __debug_switch_to_host(struct kvm_vcpu *vcpu) > diff --git a/arch/arm64/kvm/hyp/nvhe/switch.c b/arch/arm64/kvm/hyp/nvhe/switch.c > index 68ab6b4d5141..736805232521 100644 > --- a/arch/arm64/kvm/hyp/nvhe/switch.c > +++ b/arch/arm64/kvm/hyp/nvhe/switch.c > @@ -95,6 +95,7 @@ static void __deactivate_traps(struct kvm_vcpu *vcpu) > > mdcr_el2 &= MDCR_EL2_HPMN_MASK; > mdcr_el2 |= MDCR_EL2_E2PB_MASK << MDCR_EL2_E2PB_SHIFT; > + mdcr_el2 |= MDCR_EL2_E2TB_MASK << MDCR_EL2_E2TB_SHIFT; > > write_sysreg(mdcr_el2, mdcr_el2); > if (is_protected_kvm_enabled()) > -- > 2.24.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel