From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55447C433C1 for ; Fri, 26 Mar 2021 19:21:50 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 03AEE61945 for ; Fri, 26 Mar 2021 19:21:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 03AEE61945 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:MIME-Version:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:References:In-Reply-To:Message-Id:Date:Subject:Cc:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=rxpGFAALt7gEKRIp4cv6duJBJQyZhLAC+IEG0OBq/0A=; b=kPCaZntyhwEUQGbfwWMa6DqtPm C02CKjO3/jiQ77VB0boBrKf1Hy/d5atCt9zs2sU28JCmhEBt1qFAclAZ3cdh6udbBFhLN7f/Gny6X BaWvawrKkZKPtTiiJrR7l4Is7U66yqohItrifjNMBnDy2NBY5hD/tFe8AuvRR78K2eMtH/MbUrbMV ApK1OIvoH+KocUwTJ+OIRM5+HT9JeRPcW63WCWcbySYUKNP+TICpFxSXk450+JgBDt5DkUUud/Ipw 07fKNZDHpT9Bntda59rNLT6HMEf4gz0Ls6wTcE43PgHoHMWxaR3Jjv4q9PwwwtkAkOLxY6BsCSeUV kXjcy6EQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lPs09-004Cd4-7d; Fri, 26 Mar 2021 19:20:09 +0000 Received: from mail-ed1-x52d.google.com ([2a00:1450:4864:20::52d]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lPrzT-004CSO-6C; Fri, 26 Mar 2021 19:19:28 +0000 Received: by mail-ed1-x52d.google.com with SMTP id w18so7607536edc.0; Fri, 26 Mar 2021 12:19:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=M/9AAleVmFAMrayfO8gflHwlnHawghg4IbNPiAHidSA=; b=BwBmdNMkYjWREZoEW6Qw+pyNmX+4hg+o4WGSPNdGSW0EzAqFPTHSTsEsjj+uuTuzoZ 5GWuW3AMy3aGoyG+U1a+mB0O1ZSyw7GI3HDnng82EBqU73XwuYOqadvIiPZBKwkbjoaA 7BLqBrRFOGP4VxorPBbLEy3xdhHIM8wNz+BX8oEumvLEYmgK1MlzLAuwHSGi7wbIlG2i 2Od8/TXTQKRJ1Naazh+NjXkNBzog88Y7LyYyBif3ZOfFidCd0YfdSow5cxYaxcfLTkhF Q3K/KarVpbSVzhqtC9aZd/28a/xGLfBjgGvjfLGl768qDvf6gB2/p4oL6VQlvuEdpcKd xfjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=M/9AAleVmFAMrayfO8gflHwlnHawghg4IbNPiAHidSA=; b=pAWGl7UhuGMWDVcG0YeBGWszWMiXm7BgPxVaK2WMW5TWYNX5sckFZPwq/TF4zhhMRW FQgnP2bUUkvbTng+6dfMVEUNTkZXozUZhfOcmseDYHn4cIWpROEE2S42MFJeIefbvNBU xOmG1rKB9CqA04VGaoE78GCWIH+gDFWNfHSgIf94h9g15Iq4KeSn88RAmf8FuuahuRJb LeXT30ccQRh1W437k3saT1yNlQtPPZs5qLleZSgj4aQ0GPLMIpUJ8k0JJs+HLFXbi5Rn g7CBw7qubzQ02yWstuKlhkrYD0TGyrF3/mQuebU5SrZ/oPSAljwSSqvGB+NTuBPEhMM+ d7CA== X-Gm-Message-State: AOAM530AnYss6buV+UWO2zOvwVQusa6LYj6md2t5vCFTlliWW89BipMl grxzq5Q6HpbgI5f5pM0cUP8+2Of94+s= X-Google-Smtp-Source: ABdhPJy4mPNuOgXTUv0iVfS8Og7f8FyOegkBueCSwmhMt50Ur/q5IXlXsgTOR5ipG8s3Cw+/IbYTWg== X-Received: by 2002:aa7:da04:: with SMTP id r4mr16990098eds.343.1616786366594; Fri, 26 Mar 2021 12:19:26 -0700 (PDT) Received: from stbsrv-and-01.and.broadcom.net ([192.19.231.250]) by smtp.gmail.com with ESMTPSA id c19sm4739373edu.20.2021.03.26.12.19.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Mar 2021 12:19:26 -0700 (PDT) From: Jim Quinlan To: linux-pci@vger.kernel.org, Nicolas Saenz Julienne , Rob Herring , Mark Brown , bcm-kernel-feedback-list@broadcom.com, jim2101024@gmail.com, james.quinlan@broadcom.com Cc: Lorenzo Pieralisi , Bjorn Helgaas , Florian Fainelli , Jim Quinlan , linux-rpi-kernel@lists.infradead.org (moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE), linux-arm-kernel@lists.infradead.org (moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE), linux-kernel@vger.kernel.org (open list) Subject: [PATCH v3 6/6] PCI: brcmstb: Check return value of clk_prepare_enable() Date: Fri, 26 Mar 2021 15:19:04 -0400 Message-Id: <20210326191906.43567-7-jim2101024@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210326191906.43567-1-jim2101024@gmail.com> References: <20210326191906.43567-1-jim2101024@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210326_191927_295562_8EE64BBD X-CRM114-Status: GOOD ( 12.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The check was missing on PCIe resume. Signed-off-by: Jim Quinlan Acked-by: Florian Fainelli Fixes: 8195b7417018 ("PCI: brcmstb: Add suspend and resume pm_ops") --- drivers/pci/controller/pcie-brcmstb.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/pci/controller/pcie-brcmstb.c b/drivers/pci/controller/pcie-brcmstb.c index 2d9288399014..f6d9d785b301 100644 --- a/drivers/pci/controller/pcie-brcmstb.c +++ b/drivers/pci/controller/pcie-brcmstb.c @@ -1396,7 +1396,9 @@ static int brcm_pcie_resume(struct device *dev) int ret; base = pcie->base; - clk_prepare_enable(pcie->clk); + ret = clk_prepare_enable(pcie->clk); + if (ret) + return ret; ret = brcm_set_regulators(pcie, TURN_ON); if (ret) @@ -1535,7 +1537,9 @@ static int brcm_pcie_probe(struct platform_device *pdev) ret = brcm_pcie_get_regulators(pcie); if (ret) { - dev_err(pcie->dev, "failed to get regulators (err=%d)\n", ret); + pcie->num_supplies = 0; + if (ret != -EPROBE_DEFER) + dev_err(pcie->dev, "failed to get regulators (err=%d)\n", ret); goto fail; } -- 2.17.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel