From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE784C433DB for ; Sat, 27 Mar 2021 10:21:49 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 69B1761A02 for ; Sat, 27 Mar 2021 10:21:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 69B1761A02 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=672YmyvDUpDOByprBD8pgagzkM41IEILntaBq/6Q9jM=; b=EcKHjq+OKFH16MzArh+lv6uHS qd4XolKLzyGR9z4jNsFhHMmCPu06Ojt78hPw9DgKHEqVE9C4duVc3QKDsw041vu1HyP0scpOG/SEC hDx1Y94TCyhx6c3uo9eMKa+EYAHWgjao7wpLpoaFpouGvaFnXs5uLlkA3dI7kDrHyBKhJoLvZT8SL bQ6l/Qw9Y2ob+NZADG1mKJWtez0LhzbHZ53AoRi7CSNfDGBf+i9ix4iXlBMZx/5sk4ldEIU2DHAeX DdFC4/JrgX2BZXUIVVgI2t9lv1hd0By7k3fR1ai29ak4OPbMkD0Q0svS/Ewf3bFBJ6dBGw5BP/kbL x3LbxIePA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lQ63L-0050ni-V9; Sat, 27 Mar 2021 10:20:24 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lQ63H-0050n3-Lq for linux-arm-kernel@lists.infradead.org; Sat, 27 Mar 2021 10:20:21 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=DVjYSyWQdbWu0/nbG+Yl381iPzwCZZyDqilArg4nupU=; b=RWob4ATBhI0omzHwVpSZz+5rJ PvShLfpkCXTTYHLmGnvRsSXA3voEtP4FgpJXYv2PekHAr/Yfe+aeZY19xJ+atsVLlzU/LNYtaFz8x KuR39CKrY6gHyr886ECyy74TXcZBHAadfN/GPWfM6GXo9LqmXtTTrsS1vqrvvRYY18yrqPEBTJL9H png8xT0eNBhQ7ETjTWk8Odqwn1d8n0Qm8tcMKwhsY2AjYkYT00Mk2toronqDhmirBYt+8IKlbJhdH L/c+EfeYhAIjyMuuFMIZWN+GclekFfxR/tzssc1YHqupY71wCFd3Rt8I1aWSCFMBA+PB6/oITQbC0 rPHVGSsBA==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:51866) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lQ63B-0006Pg-TG; Sat, 27 Mar 2021 10:20:13 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1lQ63A-0007xU-VS; Sat, 27 Mar 2021 10:20:12 +0000 Date: Sat, 27 Mar 2021 10:20:12 +0000 From: Russell King - ARM Linux admin To: Shixin Liu Cc: Andrey Ryabinin , Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , kasan-dev@googlegroups.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm: 9016/2: Make symbol 'tmp_pmd_table' static Message-ID: <20210327102012.GT1463@shell.armlinux.org.uk> References: <20210327083018.1922539-1-liushixin2@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210327083018.1922539-1-liushixin2@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210327_102019_841102_59ABEE2B X-CRM114-Status: GOOD ( 19.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Why do you have 9016/2 in the subject line? That's an identifier from the patch system which shouldn't be in the subject line. If you want to refer to something already committed, please do so via the sha1 git hash and quote the first line of the commit description within ("...") in the body of your commit description. Thanks. On Sat, Mar 27, 2021 at 04:30:18PM +0800, Shixin Liu wrote: > Symbol 'tmp_pmd_table' is not used outside of kasan_init.c and only used > when CONFIG_ARM_LPAE enabled. So marks it static and add it into CONFIG_ARM_LPAE. > > Signed-off-by: Shixin Liu > --- > arch/arm/mm/kasan_init.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/mm/kasan_init.c b/arch/arm/mm/kasan_init.c > index 9c348042a724..3a06d3b51f97 100644 > --- a/arch/arm/mm/kasan_init.c > +++ b/arch/arm/mm/kasan_init.c > @@ -27,7 +27,9 @@ > > static pgd_t tmp_pgd_table[PTRS_PER_PGD] __initdata __aligned(PGD_SIZE); > > -pmd_t tmp_pmd_table[PTRS_PER_PMD] __page_aligned_bss; > +#ifdef CONFIG_ARM_LPAE > +static pmd_t tmp_pmd_table[PTRS_PER_PMD] __page_aligned_bss; > +#endif > > static __init void *kasan_alloc_block(size_t size) > { > -- > 2.25.1 > > -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel