From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9826DC433C1 for ; Sun, 28 Mar 2021 08:19:47 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3565D61951 for ; Sun, 28 Mar 2021 08:19:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3565D61951 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=45Vdvgg077zXPs8G/ey7W+vR+3o1a3OzrnaoM3z3G8E=; b=F/Tu/yhGZKtW4tdAaIGzcFsqp xEzGhG0jHMJjoaRbyJW+J3m+KMk2v3hpasMHiB3aW+r26amiEYDeLnWzxHOabF3A6I3sTsoaxFhst fsWpVrLywj/2TMvvd0ykrX/RH+Badke0WXDF7e5MRX0z7ldz6jo6gE9H5QTxkBsnKZskwLq/3KIuH J4eLOGSiR/MaXS4GE+JSikHA89ke5n7eFAqmCYUSByceNUeq+6eu7hAgq/RtQRC3kjF8/KVK5aAzb G/Ut++9NnLIRojbWuNSoFV1wYgq0GLFyslVjDTlbB5abcHJeUfNSNGYcN5lUj9wNWsBzqQUjLDY1R ++T0ox7Dw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lQQcm-0060vo-Ra; Sun, 28 Mar 2021 08:18:21 +0000 Received: from mail-pl1-x636.google.com ([2607:f8b0:4864:20::636]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lQQcf-0060v2-FZ for linux-arm-kernel@lists.infradead.org; Sun, 28 Mar 2021 08:18:15 +0000 Received: by mail-pl1-x636.google.com with SMTP id v8so2944320plz.10 for ; Sun, 28 Mar 2021 01:18:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=XLqk7J/e/Gq7rEEcPvaBEoFPtT3QJSySBP+HlLjgriQ=; b=c8El76MujHNF1Ic3rnwY8U1Jf6mSer+erGRSV9djkARGslPiOM6ESp3kUxK2No3wIx Uh5yw0bw1JYjy9BHLjk6fCm4PgehJwr8MVovfE+Oye/AmU6+/7ghaGE6tfzc03CI52jl JYpnwst4XXZuHltq+yU+BqMofJei/NrDtfnzzheAe+YocDU8xWAenJO8NEbSzvXf8QBh Ih8sZRlfpfwsP5nOBJYACL+CRzYBzMUkyWTv6M9a8ffQl9AHAti0GaFw8R6vL0cBDpku NS7X+CQ6CGXhoWD+xO2Kq3tBx7Vte9GPS4HrFkjUkDUbkHkHl6xrBP7ES8On0qNCZFsu vKVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=XLqk7J/e/Gq7rEEcPvaBEoFPtT3QJSySBP+HlLjgriQ=; b=h+lUrKupsmn/wFUgMvv9vsccSLSRxmy9hdDBpohoFhNnRt+cNE+A8G8dn5HUIJOj6G HDB+ucy4hWebkvUPrbhThp6PEpKZr1InFbQQGaM7LcbYmiv0dNDt65h2jQrfZHNZCAxW I+l7vldDfWWyE2SFMN0/WbtdUURTbW7CY6yjeiSl58bgrlfzWUiS8Ew2GAGmY3kyrZjX Rc5wPm+YeJjP+/Lr5UnHu70z8HWN0EqEzjBdW5AFDQBA+Y+kGWe7LXfyyhE/OePY0Bni W086fzoln6DAizZ3IzhpTSGFvodWib1xxfkP6HjprIzeioNj/DAmifzcfE8xPczbhceR l7mA== X-Gm-Message-State: AOAM5317ZIA7IUusdfRUGd3+hnNEy+IGFSzo4RObBKCxWiqCiLSlRAdB zLr6qRtO7NBvr7Qm5sI7AvnIkA== X-Google-Smtp-Source: ABdhPJyoen3SCXQkQNHxcNqHE0qucHysVcs7+mhAJXv8A4V+fp9Sj6f6uUu8iXvYn2ArfGVwOc7clg== X-Received: by 2002:a17:902:6903:b029:e5:e0e6:d950 with SMTP id j3-20020a1709026903b02900e5e0e6d950mr23478177plk.21.1616919491357; Sun, 28 Mar 2021 01:18:11 -0700 (PDT) Received: from dragon (80.251.214.228.16clouds.com. [80.251.214.228]) by smtp.gmail.com with ESMTPSA id ge16sm12944587pjb.43.2021.03.28.01.18.09 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sun, 28 Mar 2021 01:18:10 -0700 (PDT) Date: Sun, 28 Mar 2021 16:18:05 +0800 From: Shawn Guo To: Bjorn Andersson Cc: Will Deacon , lorenzo.pieralisi@arm.com, Robin Murphy , linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH] iommu/arm-smmu-qcom: create qcom_smmu_impl for ACPI boot Message-ID: <20210328081804.GA24152@dragon> References: <20210301074021.20059-1-shawn.guo@linaro.org> <20210325145914.GC15172@willie-the-truck> <20210325170256.GA904837@yoga> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210325170256.GA904837@yoga> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210328_091813_675709_CD35E2D7 X-CRM114-Status: GOOD ( 23.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Mar 25, 2021 at 12:02:56PM -0500, Bjorn Andersson wrote: > On Thu 25 Mar 09:59 CDT 2021, Will Deacon wrote: > > > [+ Lorenzo] > > > > On Mon, Mar 01, 2021 at 03:40:21PM +0800, Shawn Guo wrote: > > > Though qcom_adreno_smmu_impl is not used by ACPI boot right now, > > > qcom_smmu_impl is already required at least to boot up Lenovo Flex 5G > > > laptop. Let's check asl_compiler_id in IORT header to ensure we are > > > running a QCOM SMMU and create qcom_smmu_impl for it. > > > > > > !np is used to check ACPI boot, because fwnode of SMMU device is > > > a static allocation and thus has_acpi_companion() doesn't work here. > > > > > > Signed-off-by: Shawn Guo > > > --- > > > drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c | 33 ++++++++++++++++++++++ > > > 1 file changed, 33 insertions(+) > > > > I don't know what a "asl_compiler_id" is, but it doesn't sound like it > > has an awful lot to do with the SMMU. > > > > I would prefer that we somehow relate this to the particular board, > rather than all Qualcomm-related ACPI tables. E.g. by relying on the > SMMU devices having a _HID of QCOM0409. > > Shawn, any reason for this wouldn't be possible? The arm-smmu driver is probing a device created from IORT table rather DSDT, and there is no info like HID that can be found around the device. Shawn _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel