From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 080B6C433C1 for ; Tue, 30 Mar 2021 08:09:26 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8B6C0600EF for ; Tue, 30 Mar 2021 08:09:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8B6C0600EF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID:Date: Subject:CC:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=npm+6h0ZMnx7Egf+yiZ73/L0YRw1L4j9uL0S58Ke83E=; b=kJF5jrTnhdwEgjJXig6pRndXb zVn7VK/6FYPMXJ2jpYi666CEWHsZwZSsvhQ4wb0B5EPx8e4YOOVBvLVagUOP21mhwXiNAP/yJ57zC Ts0gauvgm+7D0qL+NVRoQ6dfd1vc/1yoZ7bK6hWnOP17l1XEx1mf4yDUcbuEiMM8uonLbN3WPYUCv 9wtR3S49wbAV+MlwJyG5aDTMBz/Mb+ZyJV5z3yitujTt7XWaPOzPLFVP3z4s2KPcsnDly46dQSGNX b0BB1E4PNtxDN3Gv+YyCPEHXwJ70JlbjIl5BjpUt5yk+p0Glx3bOPDFW4ZYIsLSiOTNPUTn+htjO5 rqNldIn5w==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lR9PH-002yGt-6p; Tue, 30 Mar 2021 08:07:23 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lR9OU-002y9d-Mj for linux-arm-kernel@lists.infradead.org; Tue, 30 Mar 2021 08:06:37 +0000 X-UUID: 8daf1d04c0084b41a075de822e85dae5-20210330 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:CC:To:From; bh=/vBzcOzGVmnmlf+VW8NVOqfPwvnpoADTxKYvHxajHu8=; b=A59k92FY7RB1YxaQnlJSnYaMhsgoY7/IWLrKhTiOze9pEb/XZmH3VSXYYxle0dVhD4t5xyD/ZC8HW7gflTWZCbNbd+ph2TmY/B20rSzgEokgBCyjg4NXQrWvusfAYhWP8Id1vBgNADNXriuUDSgh4RayLMiFc9WVYs2Y5bFkU9c=; X-UUID: 8daf1d04c0084b41a075de822e85dae5-20210330 Received: from mtkcas67.mediatek.inc [(172.29.193.45)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 345465543; Tue, 30 Mar 2021 00:06:24 -0800 Received: from mtkmbs08n1.mediatek.inc (172.21.101.55) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 30 Mar 2021 01:06:23 -0700 Received: from MTKCAS06.mediatek.inc (172.21.101.30) by mtkmbs08n1.mediatek.inc (172.21.101.55) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 30 Mar 2021 16:06:15 +0800 Received: from mtksdccf07.mediatek.inc (172.21.84.99) by MTKCAS06.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Tue, 30 Mar 2021 16:06:15 +0800 From: Lecopzer Chen To: CC: , , , , , , , , , , , Subject: Re: [PATCH v5] arm64: Enable perf events based hard lockup detector Date: Tue, 30 Mar 2021 16:06:15 +0800 Message-ID: <20210330080615.21938-1-lecopzer.chen@mediatek.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: References: MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210330_090635_386424_8F8D6D9B X-CRM114-Status: GOOD ( 18.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > Hi Will, Mark, > > On Fri, 15 Jan 2021 at 17:32, Sumit Garg wrote: > > > > With the recent feature added to enable perf events to use pseudo NMIs > > as interrupts on platforms which support GICv3 or later, its now been > > possible to enable hard lockup detector (or NMI watchdog) on arm64 > > platforms. So enable corresponding support. > > > > One thing to note here is that normally lockup detector is initialized > > just after the early initcalls but PMU on arm64 comes up much later as > > device_initcall(). So we need to re-initialize lockup detection once > > PMU has been initialized. > > > > Signed-off-by: Sumit Garg > > --- > > > > Changes in v5: > > - Fix lockup_detector_init() invocation to be rather invoked from CPU > > binded context as it makes heavy use of per-cpu variables and shouldn't > > be invoked from preemptible context. > > > > Do you have any further comments on this? > > Lecopzer, > > Does this feature work fine for you now? This really fixes the warning, I have a real hardware for testing this now. but do we need to call lockup_detector_init() for each cpu? In init/main.c, it's only called by cpu 0 for once. BRs, Lecopzer _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel