From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5799C433C1 for ; Tue, 30 Mar 2021 11:07:56 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3748561985 for ; Tue, 30 Mar 2021 11:07:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3748561985 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Xhd/xSlUhl0RUAPNy2m5BMcyrw5f9of7ug+eeqpavUM=; b=fncoxNW+Gh8QOjoyfbi4np7R/ VYqNIY0FEHMR8TTIpOktYIHRPPXVQINxlrid5Aj3CzTCYKBx97NuZYwXihKt8ETIU81b/a1k2N2qB 2adLy39UUAsB/QkSi9LnAdk+MKbNDIojTD5zAemJugb5xQpirx4MZemgIxHYO4lrFlkjOsvWZkaql poJprYtPFbonsW/I7WY05TS9nsAul4EncyOQXlsB4TX3CNF4PtZmwQBdGZTkIHn/XBNX982t6Q1sU 3LGdcllEjuGTtuHWGRDMdH8g+3nG2noCyxfP3Y2nHWMgJ5pJNzjGf39R0Cw4vesmJqv3j8XrsCHye xqV+wtujw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lRCCF-003VxH-Qc; Tue, 30 Mar 2021 11:06:07 +0000 Received: from foss.arm.com ([217.140.110.172]) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lRCC3-003VvP-0A for linux-arm-kernel@lists.infradead.org; Tue, 30 Mar 2021 11:05:58 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9DD921FB; Tue, 30 Mar 2021 04:05:52 -0700 (PDT) Received: from lpieralisi (e121166-lin.cambridge.arm.com [10.1.196.255]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 817723F694; Tue, 30 Mar 2021 04:05:51 -0700 (PDT) Date: Tue, 30 Mar 2021 12:05:46 +0100 From: Lorenzo Pieralisi To: Marc Zyngier Cc: Lecopzer Chen , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, tglx@linutronix.de, lecopzer@gmail.com, yj.chiang@mediatek.com, Julien Thierry Subject: Re: [PATCH] irqchip/gic-v3: Fix IPRIORITYR can't perform byte operations in GIC-600 Message-ID: <20210330110546.GA24881@lpieralisi> References: <20210330100619.24747-1-lecopzer.chen@mediatek.com> <87o8f1q6c6.wl-maz@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <87o8f1q6c6.wl-maz@kernel.org> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210330_120555_851621_419F52E0 X-CRM114-Status: GOOD ( 29.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Mar 30, 2021 at 11:33:13AM +0100, Marc Zyngier wrote: > [+Lorenzo, +Julien on an actual email address] > > On Tue, 30 Mar 2021 11:06:19 +0100, > Lecopzer Chen wrote: > > > > When pseudo-NMI enabled, register_nmi() set priority of specific IRQ > > by byte ops, and this doesn't work in GIC-600. > > > > We have asked ARM Support [1]: > > > Please refer to following description in > > > "2.1.2 Distributor ACE-Lite slave interface" of GIC-600 TRM for > > > the GIC600 ACE-lite slave interface supported sizes: > > > "The GIC-600 only accepts single beat accesses of the sizes for > > > each register that are shown in the Programmers model, > > > see Chapter 4 Programmer's model on page 4-102. > > > All other accesses are rejected and given either an > > > OKAY or SLVERR response that is based on the GICT_ERR0CTLR.UE bit.". > > > > Thus the register needs to be written by double word operation and > > the step will be: read 32bit, set byte and write it back. > > > > [1] https://services.arm.com/support/s/case/5003t00001L4Pba > > You do realise that this link: > > - is unusable for most people as it is behind a registration interface > - discloses confidential information to other people > > I strongly suggest you stop posting such links. > > > > > Signed-off-by: Lecopzer Chen > > --- > > drivers/irqchip/irq-gic-v3.c | 13 ++++++++++++- > > 1 file changed, 12 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/irqchip/irq-gic-v3.c b/drivers/irqchip/irq-gic-v3.c > > index eb0ee356a629..cfc5a6ad30dc 100644 > > --- a/drivers/irqchip/irq-gic-v3.c > > +++ b/drivers/irqchip/irq-gic-v3.c > > @@ -440,10 +440,21 @@ static void gic_irq_set_prio(struct irq_data *d, u8 prio) > > { > > void __iomem *base = gic_dist_base(d); > > u32 offset, index; > > + u32 val, prio_offset_mask, prio_offset_shift; > > > > offset = convert_offset_index(d, GICD_IPRIORITYR, &index); > > > > - writeb_relaxed(prio, base + offset + index); > > + /* > > + * GIC-600 memory mapping register doesn't support byte opteration, > > + * thus read 32-bits from register, set bytes and wtire back to it. > > + */ > > + prio_offset_shift = (index & 0x3) * 8; > > + prio_offset_mask = GENMASK(prio_offset_shift + 7, prio_offset_shift); > > + index &= ~0x3; > > + val = readl_relaxed(base + offset + index); > > + val &= ~prio_offset_mask; > > + val |= prio << prio_offset_shift; > > + writel_relaxed(val, base + offset + index); > > } > > > > static u32 gic_get_ppi_index(struct irq_data *d) > > From the architecture spec: > > > 11.1.3 GIC memory-mapped register access > > In any system, access to the following registers must be supported: > > [...] > * Byte accesses to: > - GICD_IPRIORITYR. > - GICD_ITARGETSR. > - GICD_SPENDSGIR. > - GICD_CPENDSGIR. > - GICR_IPRIORITYR. > > > So if GIC600 doesn't follow this architectural requirement, this is a > HW erratum, and I want an actual description of the HW issue together > with an erratum number. > > Lorenzo, can you please investigate on your side? Sure - I will look into it and report back. Thanks, Lorenzo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel