From: Alexander A Sverdlin <alexander.sverdlin@nokia.com>
To: linux-arm-kernel@lists.infradead.org
Cc: Alexander Sverdlin <alexander.sverdlin@nokia.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ingo Molnar <mingo@redhat.com>,
Russell King <linux@armlinux.org.uk>,
Florian Fainelli <f.fainelli@gmail.com>,
linux-kernel@vger.kernel.org,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Qais Yousef <qais.yousef@arm.com>
Subject: [PATCH v8 0/3] ARM: Implement MODULE_PLT support in FTRACE
Date: Tue, 30 Mar 2021 13:40:32 +0200 [thread overview]
Message-ID: <20210330114035.18575-1-alexander.sverdlin@nokia.com> (raw)
From: Alexander Sverdlin <alexander.sverdlin@nokia.com>
FTRACE's function tracer currently doesn't always work on ARM with
MODULE_PLT option enabled. If the module is loaded too far, FTRACE's
code modifier cannot cope with introduced veneers and turns the
function tracer off globally.
ARM64 already has a solution for the problem, refer to the following
patches:
arm64: ftrace: emit ftrace-mod.o contents through code
arm64: module-plts: factor out PLT generation code for ftrace
arm64: ftrace: fix !CONFIG_ARM64_MODULE_PLTS kernels
arm64: ftrace: fix building without CONFIG_MODULES
arm64: ftrace: add support for far branches to dynamic ftrace
arm64: ftrace: don't validate branch via PLT in ftrace_make_nop()
But the presented ARM variant has just a half of the footprint in terms of
the changed LoCs. It also retains the code validation-before-modification
instead of switching it off.
Changelog:
v8:
* Add warn suppress parameter to arm_gen_branch_link()
v7:
* rebased
v6:
* rebased
v5:
* BUILD_BUG_ON() ensures fixed_plts[] always fits one PLT block
* use "for" loop instead of "while"
* scripts/recordmcount is filtering reloc types
v4:
* Fixed build without CONFIG_FUNCTION_TRACER
* Reorganized pre-allocated PLTs handling in get_module_plt(),
now compiler eliminates the whole FTRACE-related handling code
if ARRAY_SIZE(fixed_plts) == 0
v3:
* Only extend struct dyn_arch_ftrace when ARM_MODULE_PLTS is enabled
v2:
* As suggested by Steven Rostedt, refrain from tree-wide API modification,
save module pointer in struct dyn_arch_ftrace instead (PowerPC way)
Alexander Sverdlin (3):
ARM: PLT: Move struct plt_entries definition to header
ARM: Add warn suppress parameter to arm_gen_branch_link()
ARM: ftrace: Add MODULE_PLTS support
arch/arm/include/asm/ftrace.h | 3 +++
arch/arm/include/asm/insn.h | 8 +++----
arch/arm/include/asm/module.h | 10 +++++++++
arch/arm/kernel/ftrace.c | 46 +++++++++++++++++++++++++++++++++-------
arch/arm/kernel/insn.c | 19 +++++++++--------
arch/arm/kernel/module-plts.c | 49 +++++++++++++++++++++++++++++++++----------
6 files changed, 103 insertions(+), 32 deletions(-)
--
2.10.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next reply other threads:[~2021-03-30 11:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-30 11:40 Alexander A Sverdlin [this message]
2021-03-30 11:40 ` [PATCH v8 1/3] ARM: PLT: Move struct plt_entries definition to header Alexander A Sverdlin
2021-03-30 11:40 ` [PATCH v8 2/3] ARM: Add warn suppress parameter to arm_gen_branch_link() Alexander A Sverdlin
2021-03-30 11:40 ` [PATCH v8 3/3] ARM: ftrace: Add MODULE_PLTS support Alexander A Sverdlin
2021-03-30 18:57 ` [PATCH v8 0/3] ARM: Implement MODULE_PLT support in FTRACE Florian Fainelli
2021-04-01 23:52 ` Florian Fainelli
2021-04-09 15:33 ` Qais Yousef
2021-04-12 6:28 ` Alexander Sverdlin
2021-04-12 11:08 ` Qais Yousef
2021-04-19 21:54 ` Florian Fainelli
2021-04-19 22:34 ` Qais Yousef
2021-05-04 19:11 ` Florian Fainelli
2021-05-05 8:02 ` Alexander Sverdlin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210330114035.18575-1-alexander.sverdlin@nokia.com \
--to=alexander.sverdlin@nokia.com \
--cc=ard.biesheuvel@linaro.org \
--cc=f.fainelli@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mingo@redhat.com \
--cc=qais.yousef@arm.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox