* [PATCH -next] i2c: gpio: use DEFINE_SPINLOCK() for spinlock
@ 2021-03-27 9:52 Chen Lifu
2021-04-01 3:38 ` chenlifu
0 siblings, 1 reply; 3+ messages in thread
From: Chen Lifu @ 2021-03-27 9:52 UTC (permalink / raw)
To: chenlifu, Russell King
Cc: heying24, yuehaibing, weiyongjun1, johnny.chenyi,
linux-arm-kernel, linux-kernel, kernel-janitors
From: Lifu Chen <chenlifu@huawei.com>
spinlock can be initialized automatically with DEFINE_SPINLOCK()
rather than explicitly calling spin_lock_init().
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Lifu Chen <chenlifu@huawei.com>
---
arch/arm/mach-sa1100/simpad.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/arch/arm/mach-sa1100/simpad.c b/arch/arm/mach-sa1100/simpad.c
index c7fb9a73e4c5..c183432880d3 100644
--- a/arch/arm/mach-sa1100/simpad.c
+++ b/arch/arm/mach-sa1100/simpad.c
@@ -45,7 +45,7 @@
*/
static long cs3_shadow;
-static spinlock_t cs3_lock;
+static DEFINE_SPINLOCK(cs3_lock);
static struct gpio_chip cs3_gpio;
long simpad_get_cs3_ro(void)
@@ -379,8 +379,6 @@ static int __init simpad_init(void)
{
int ret;
- spin_lock_init(&cs3_lock);
-
cs3_gpio.label = "simpad_cs3";
cs3_gpio.base = SIMPAD_CS3_GPIO_BASE;
cs3_gpio.ngpio = 24;
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] i2c: gpio: use DEFINE_SPINLOCK() for spinlock
2021-03-27 9:52 [PATCH -next] i2c: gpio: use DEFINE_SPINLOCK() for spinlock Chen Lifu
@ 2021-04-01 3:38 ` chenlifu
2021-04-01 7:49 ` Dan Carpenter
0 siblings, 1 reply; 3+ messages in thread
From: chenlifu @ 2021-04-01 3:38 UTC (permalink / raw)
To: Russell King
Cc: heying24, yuehaibing, weiyongjun1, johnny.chenyi,
linux-arm-kernel, linux-kernel, kernel-janitors
Kindly pinging ...
Best Regards,
Chen Lifu
在 2021/3/27 17:52, Chen Lifu 写道:
> From: Lifu Chen <chenlifu@huawei.com>
>
> spinlock can be initialized automatically with DEFINE_SPINLOCK()
> rather than explicitly calling spin_lock_init().
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Lifu Chen <chenlifu@huawei.com>
> ---
> arch/arm/mach-sa1100/simpad.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/arch/arm/mach-sa1100/simpad.c b/arch/arm/mach-sa1100/simpad.c
> index c7fb9a73e4c5..c183432880d3 100644
> --- a/arch/arm/mach-sa1100/simpad.c
> +++ b/arch/arm/mach-sa1100/simpad.c
> @@ -45,7 +45,7 @@
> */
>
> static long cs3_shadow;
> -static spinlock_t cs3_lock;
> +static DEFINE_SPINLOCK(cs3_lock);
> static struct gpio_chip cs3_gpio;
>
> long simpad_get_cs3_ro(void)
> @@ -379,8 +379,6 @@ static int __init simpad_init(void)
> {
> int ret;
>
> - spin_lock_init(&cs3_lock);
> -
> cs3_gpio.label = "simpad_cs3";
> cs3_gpio.base = SIMPAD_CS3_GPIO_BASE;
> cs3_gpio.ngpio = 24;
>
> .
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] i2c: gpio: use DEFINE_SPINLOCK() for spinlock
2021-04-01 3:38 ` chenlifu
@ 2021-04-01 7:49 ` Dan Carpenter
0 siblings, 0 replies; 3+ messages in thread
From: Dan Carpenter @ 2021-04-01 7:49 UTC (permalink / raw)
To: chenlifu
Cc: Russell King, heying24, yuehaibing, weiyongjun1, johnny.chenyi,
linux-arm-kernel, linux-kernel, kernel-janitors
On Thu, Apr 01, 2021 at 11:38:30AM +0800, chenlifu wrote:
> Kindly pinging ...
>
> Best Regards,
> Chen Lifu
>
> 在 2021/3/27 17:52, Chen Lifu 写道:
It's to early to start asking for a response. Please wait at least two
weeks. (Probably four weeks if the merge window was open).
regards,
dan carpenter
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-04-01 7:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-03-27 9:52 [PATCH -next] i2c: gpio: use DEFINE_SPINLOCK() for spinlock Chen Lifu
2021-04-01 3:38 ` chenlifu
2021-04-01 7:49 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).