From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01E42C433B4 for ; Thu, 1 Apr 2021 08:39:56 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 78C2560190 for ; Thu, 1 Apr 2021 08:39:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 78C2560190 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=b+f98e+wyBlUZkpqwOfL2xUGA5NC07Ty466uSKnHI08=; b=WJQ4u5ohlpJQ6XuxknJRuL5nA qSyps1NbxwHilyGH0FFqjKR6OjbprHJagb3T4cP3Cr/fhml3o/V1ytbp1s+Y2py4ywe6F/tTYZaSw RRhykP645vFNhHNJ+QlcHj2+8tjjys9fgj5V26LzJw1LYsl559GmIdVfRr/ru+Bnwztoaq/4JGQdp D7xI+lXwlErFGfA3iSHhLPhjXy4eNyMO1XCSZKWArx9zWDWraLKkqyo5SzwIM5cFTYqS9gV4ZvizD hkeWmtLb2gP3RoSf6bPPcvfqueDu1d+EpEJ0s1Wm7BJUORCeGuiUU7mCjqwFUIz9sxpX58GU60/5A XEa2FvP/w==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lRsqH-008yKN-84; Thu, 01 Apr 2021 08:38:17 +0000 Received: from mail.kernel.org ([198.145.29.99]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lRsq8-008yJI-92 for linux-arm-kernel@lists.infradead.org; Thu, 01 Apr 2021 08:38:10 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id C6D0B61041; Thu, 1 Apr 2021 08:38:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1617266286; bh=pL7zEm/CJ6Uq13TbvMopTgicNXFZzItUs41gFNFs0bo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=A3X3lduCFkIuAeuQcqpzhul7wvKwDj5UjZ40gX0BhH6coMkam04N1fMhBXiO1k9fr Qx/8Cp+zmkSw5yt/9WD3OWEBwEdVVUiTgmrKXPktPG5MJhpkzp1IqJLPCbqq2ePs32 NzwqEkscV/FJQFSYJe0Z+pA7s1+1j2kz8cRLj9B2ZGRPbxRir0oMbkz4NORBnn08Qw zpEovn8ARnysgKDkNQpa5nWT4UqQLnGUIgZL92lSn8A0CTU6eFdvu51VF/lz3gas5G NbEBSMnsjL1na3BP/51tBCx3wTgdCqXYFtiXlE20KJqh/YGMRt2tzdaxvdOsy5SBYF Da/Tpgqva8b+A== Date: Thu, 1 Apr 2021 09:37:59 +0100 From: Will Deacon To: Kees Cook Cc: Catalin Marinas , Mark Rutland , Thomas Gleixner , Elena Reshetova , x86@kernel.org, Andy Lutomirski , Peter Zijlstra , Alexander Potapenko , Alexander Popov , Ard Biesheuvel , Jann Horn , Vlastimil Babka , David Hildenbrand , Mike Rapoport , Andrew Morton , Jonathan Corbet , Randy Dunlap , kernel-hardening@lists.openwall.com, linux-hardening@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v9 0/6] Optionally randomize kernel stack offset each syscall Message-ID: <20210401083758.GA8745@willie-the-truck> References: <20210331205458.1871746-1-keescook@chromium.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210331205458.1871746-1-keescook@chromium.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210401_093808_663894_6196237A X-CRM114-Status: GOOD ( 10.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Kees, On Wed, Mar 31, 2021 at 01:54:52PM -0700, Kees Cook wrote: > Hi Will (and Mark and Catalin), > > Can you take this via the arm64 tree for v5.13 please? Thomas has added > his Reviewed-by, so it only leaves arm64's. :) Sorry, these got mixed up in my inbox so I just replied to v7 and v8 and then noticed v9. Argh! However, I think the comments still apply: namely that the dummy "=m" looks dangerous to me and I think you're accessing pcpu variables with preemption enabled for the arm64 part: https://lore.kernel.org/r/20210401083034.GA8554@willie-the-truck https://lore.kernel.org/r/20210401083430.GB8554@willie-the-truck Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel