From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DEBE4C43461 for ; Thu, 1 Apr 2021 09:36:02 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5EA816108B for ; Thu, 1 Apr 2021 09:36:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5EA816108B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=avAdfNXPig7yMS0RkCAqIagbr2Kqo/XD2Nsu/VumyaM=; b=iPzSnEWWj5pVjoUGuARAflVyV Vy2en/f2UpZjHPgwTJN7vyme/OfY8RwHrAdShesDHVfd/xyXSOKkNnTnkXYOCdDY44MN/0GDQyl6M zTZQuCwtW76087mSrwkiArkxb94Sf2h7L9laNT5NuMiCQpRo5KE/JBkGr51jkLMIK3b/gmWyTJAI5 l9B3IZ/AfTFwa9CKPBkwYjvj87MeAjIGzAp7h+hXkMO9qdUldkkOFCo1yGr1yDyTYFl9pIwmpjFYz E6P/AxBXVSghchq5JxL0hPwaiDUrens/nyP761DyvoUF2bCYTrZeRUUbQ8XzJAMUewZ9AwcSaWLdI okaCJyIDw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lRtiT-0094KR-9j; Thu, 01 Apr 2021 09:34:17 +0000 Received: from verein.lst.de ([213.95.11.211]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lRtiO-0094J6-CC for linux-arm-kernel@lists.infradead.org; Thu, 01 Apr 2021 09:34:14 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 6995C68B05; Thu, 1 Apr 2021 11:34:08 +0200 (CEST) Date: Thu, 1 Apr 2021 11:34:08 +0200 From: Christoph Hellwig To: Will Deacon Cc: Christoph Hellwig , Joerg Roedel , Li Yang , Michael Ellerman , David Woodhouse , Lu Baolu , linuxppc-dev@lists.ozlabs.org, linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, iommu@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org Subject: Re: [PATCH 08/18] iommu/fsl_pamu: merge pamu_set_liodn and map_liodn Message-ID: <20210401093408.GD2934@lst.de> References: <20210316153825.135976-1-hch@lst.de> <20210316153825.135976-9-hch@lst.de> <20210330124651.GH5908@willie-the-truck> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210330124651.GH5908@willie-the-truck> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210401_103412_542449_5B286D46 X-CRM114-Status: GOOD ( 11.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Mar 30, 2021 at 01:46:51PM +0100, Will Deacon wrote: > > + ret = pamu_config_ppaace(liodn, geom->aperture_start, > > + geom->aperture_end - 1, ~(u32)0, > > + 0, dma_domain->snoop_id, dma_domain->stash_id, > > + PAACE_AP_PERMS_QUERY | PAACE_AP_PERMS_UPDATE); > > There's more '+1' / '-1' confusion here with aperture_end which I'm not > managing to follow. What am I missing? You did not missing anything, I messed this up. Fixed. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel