From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D496C433ED for ; Thu, 1 Apr 2021 11:09:40 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E9EDB61041 for ; Thu, 1 Apr 2021 11:09:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E9EDB61041 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ehWrNuR5i7uvbQoXunO/jjKlAt4/ZnErLMbiLc0VsgA=; b=h6ET/4AmWBQEAVIzEI+NJ2cCx /zjOA5nz0MsKHc5vWQ6ABvWx+y+kt+Mg11q0BdDYEwdH5gqRV8mRWSSKvRSmVYv61aSBpVqd4glUH lYufzYnCpU7VEzgf0NR3vkPBfc4Mkku6GSBmybQ7XRo1no/NfVqQevJjubzcg9XxRjxrySHha0Mi6 Z8gpuLT4LgxkMKBtak8SwNlPoLsQZQfJVS3dJ/LvN8MEuGIAWIPMEX03uhl0CF1ciWDgYC9lutbe7 2Q1i6HbLsPg3FPO+faH2udtv1k6Ow4yMB4/GIn+DYYVg1fCAkrUv0AIaan9+RjCdBg4IBO3cA1Dko BZbE1dl5g==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lRvBM-009KgO-GA; Thu, 01 Apr 2021 11:08:12 +0000 Received: from mail.kernel.org ([198.145.29.99]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lRvBA-009KZO-HS; Thu, 01 Apr 2021 11:08:04 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 41366610CA; Thu, 1 Apr 2021 11:07:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1617275279; bh=ogd+y0+ZXpj/igXJ7ptSRR8VZf3rn4GEdDLItqgA/SY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OftIwAXvBBXjILGp6g/LnTvAHq00DxXPLg5xCuM5HEUpREg0qwheg/vNZUxXNN8I0 S01QMncG4IuZ4vWglC3QzCXJM/ZW3oEXCty58naVv6tzdHJw8EbzSRDeWdLAOccoy1 2UyPohCy/CjeukzhhRSbVuaDgmIo1XpPd1HIXStWxz3XAobydHGu+GbEBNfEGAQ2+3 hDydlKNk/wPHDiPYtX+izzLTI2gdZotZPlpKwcv4s456ixkIKd3niVhHlv25GbXKYa ged+8ITp8ti4G4x8JRc/08wQqZYQjb+TlcNHplD2SzhkIaUk/iF3ru/sQJ2XBrT/Hq pqvpwoCqsdyDA== Date: Thu, 1 Apr 2021 16:37:52 +0530 From: Manivannan Sadhasivam To: Cristian Ciocaltea Cc: Andreas =?iso-8859-1?Q?F=E4rber?= , Rob Herring , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-actions@lists.infradead.org, linux-kernel@vger.kernel.org, matheus@castello.eng.br Subject: Re: [PATCH v2 0/6] Add support for Actions Semi Owl socinfo Message-ID: <20210401110752.GG14052@work> References: <20210401052438.GB14052@work> <20210401094041.GA1993499@BV030612LT> <20210401102717.GF14052@work> <252dd954-c8f1-fa2a-c37a-ede386fc9d43@suse.de> <20210401105805.GA1998829@BV030612LT> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210401105805.GA1998829@BV030612LT> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210401_120802_709081_62F21176 X-CRM114-Status: GOOD ( 32.58 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org + Matheus On Thu, Apr 01, 2021 at 01:58:05PM +0300, Cristian Ciocaltea wrote: > Hi Mani, Andreas, > = > On Thu, Apr 01, 2021 at 12:49:37PM +0200, Andreas F=E4rber wrote: > > Hi, > > = > > On 01.04.21 12:27, Manivannan Sadhasivam wrote: > > > On Thu, Apr 01, 2021 at 12:40:41PM +0300, Cristian Ciocaltea wrote: > > >> On Thu, Apr 01, 2021 at 10:54:38AM +0530, Manivannan Sadhasivam wrot= e: > > >>> On Tue, Mar 30, 2021 at 04:48:15PM +0300, Cristian Ciocaltea wrote: > > >>>> This patchset adds a socinfo driver which provides information abo= ut > > >>>> Actions Semi Owl SoCs to user space via sysfs: machine, family, so= c_id, > > >>>> serial_number. > > >>>> > > >>>> Please note the serial number is currently available only for the = S500 > > >>>> SoC variant. > > >>>> > > >>>> This has been tested on the S500 SoC based RoseapplePi SBC. > > >>>> > > >>> > > >>> Is this the soc_id provided by the vendor bootloader (uboot)? If so= , under > > >>> what basis it provides? I don't think the SoC has the provision for > > >>> soc_id based on HW parameters. > > >> > > >> No, the soc_id is not provided by the bootloader, or at least I coul= dn't > > >> identify any related implementation. Instead, I provided this via the > > >> driver itself, since I've encountered this approach in some other soc > > >> drivers as well (e.g. imx/soc-imx.c, versatile/soc-integrator.c). = > > >> > > > = > > > Sorry, I was referring to serial_number. Since your comment says so, = can > > > you point to the corresponding code? > > = > > Seconded that this needs to be better understood. If this is just a > > convention of some downstream U-Boot that's not implemented in mainline > > (and maybe not even for Guitar or Labrador? tested on RoseapplePi only), > > it might not be worth its own reserved-memory based kernel driver? > = > The serial number is actually provided by the s500-bootloader for which > Actions did not provide the source code, at least it is not available > in the xapp github repo. I did not find anything related to this in > downstream U-Boot. > = Hmm, then we can consider this as the firmware dependent property. But can we get consensus that this is common for all S500 SoCs? Maybe, Matheus can verify it on Labrador? I don't think adding a SOCINFO driver for a single board is a good idea. Thanks, Mani > Kind regards, > Cristi > = > > Implementing a standard interface such as DMI tables or a DT property in > > mainline U-Boot may be more useful then. Is it still Mani's S900 only? > > = > > Regards, > > Andreas > > = > > -- = > > SUSE Software Solutions Germany GmbH > > Maxfeldstr. 5, 90409 N=FCrnberg, Germany > > GF: Felix Imend=F6rffer > > HRB 36809 (AG N=FCrnberg) _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel