From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1FAC8C433ED for ; Thu, 1 Apr 2021 10:33:24 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 98123606A5 for ; Thu, 1 Apr 2021 10:33:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 98123606A5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=Huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID: Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=MraPJPZSqDdiDyjYI5Lw73UftD+Hmguz5ZuaIb3ersU=; b=T7fePff0SLiGnKsnbXMgirYUY OFVs8mQvctH/x14g0xp9lbFcYGsQI+/fjdfL6gtRFO3opbUAFnfDH+Q+RS6vr5j1o+0MRyGCKKjPw cIGum6CC/EENwGLU9f4a1p0Ol6fNGFrwvxN1qc9uqwIGM56PSp3M9dXUVzlbK2yRQdZS4V2CzccfG ZRM2QvJT6x+QaZW9adlk2YKnGGVkJLdsb/cCSjJ9SS6txjLh0k6wSONDi9/uCwkoz550QFAyeJo5K JC4ETqQ2YO5rGZaDXAHXsHfAokNF3ijrYARFZOIVpFyIxLj6NVc8PgupYCfZEhJ3mOUPcHcpnFG4Q 3lHn9B8wA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lRucC-009ExL-MQ; Thu, 01 Apr 2021 10:31:52 +0000 Received: from frasgout.his.huawei.com ([185.176.79.56]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lRuc1-009EvW-GF for linux-arm-kernel@lists.infradead.org; Thu, 01 Apr 2021 10:31:43 +0000 Received: from fraeml702-chm.china.huawei.com (unknown [172.18.147.201]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4F9znv0bmMz685Dg; Thu, 1 Apr 2021 18:24:51 +0800 (CST) Received: from lhreml710-chm.china.huawei.com (10.201.108.61) by fraeml702-chm.china.huawei.com (10.206.15.51) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2106.2; Thu, 1 Apr 2021 12:31:37 +0200 Received: from localhost (10.47.80.95) by lhreml710-chm.china.huawei.com (10.201.108.61) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Thu, 1 Apr 2021 11:31:36 +0100 Date: Thu, 1 Apr 2021 11:30:15 +0100 From: Jonathan Cameron To: Andy Shevchenko CC: Mugilraj Dhavachelvan , Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Ray Jui , Scott Branden , bcm-kernel-feedback-list , linux-iio , linux-arm Mailing List , Linux Kernel Mailing List Subject: Re: [PATCH] iio: adc: bcm_iproc_adc: Use %s and __func__ Message-ID: <20210401113015.00006b70@Huawei.com> In-Reply-To: References: <20210401062517.28832-1-dmugil2000@gmail.com> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; i686-w64-mingw32) MIME-Version: 1.0 X-Originating-IP: [10.47.80.95] X-ClientProxiedBy: lhreml715-chm.china.huawei.com (10.201.108.66) To lhreml710-chm.china.huawei.com (10.201.108.61) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210401_113141_770346_0443014C X-CRM114-Status: GOOD ( 11.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 1 Apr 2021 12:24:50 +0300 Andy Shevchenko wrote: > On Thu, Apr 1, 2021 at 9:27 AM Mugilraj Dhavachelvan > wrote: > > > > Change function's name to %s and __func__ to fix checkpatch.pl errors. > > No, just drop the __func__ completely. First of all, we have a device > name, and uniqueness of the messages in the driver should guarantee > easy findings. Second, specific to _dbg() variants, with enabled > Dynamic Debug it can be chosen at run time! > > I recommend going through all drivers and drop __func__ near to > dev_dbg() and pr_debug(). > Agreed. Though beware that some maintainers will count this as noise and get grumpy. I'm fine with such patches for IIO. Jonathan _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel