From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A1E6C433ED for ; Thu, 1 Apr 2021 13:20:38 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CDD336120E for ; Thu, 1 Apr 2021 13:20:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CDD336120E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=nQC9R2OPFZUFf82BSnxGZ/X9DdeTwEDGI20hWHkt1Zc=; b=PTEm+KhgCk/GUfgxMQyCT2u3K KPZacuYJch2BUy0urBNTDxSQ3Gx1aZFQyWqr1+8Rso/KECpoHwBnt2AcYvhA34uIHeq0OZq3A7jJa tVkfYSjBLCJ2mS3FLNk6nxwpDKcFexABIOE7tTtUStWyT58mCCBxQ3n0ARCjesQfzQ55TAYkc2nsG Hew+7VDR7aO98ySe+P2wS3L+ZdRqqaCt8DRJXO10HnhJcsx9RimWnTGLBESCL7EqwcMFpjWTlXV2C qKf0GkgN5yH0FqDlvnNQPJum+FvFyWk8zhYtGhwTpDj1eGEUNTh8grqmdUQtQuce2j9H+zCPKBZI7 gxc5Ukosw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lRxE9-009fQp-3x; Thu, 01 Apr 2021 13:19:13 +0000 Received: from mail-ej1-x634.google.com ([2a00:1450:4864:20::634]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lRxE4-009fQ2-Ih; Thu, 01 Apr 2021 13:19:10 +0000 Received: by mail-ej1-x634.google.com with SMTP id u21so2807068ejo.13; Thu, 01 Apr 2021 06:19:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=VBkSNIu9jBA5fHU0Y3NWECYXpRzyBbvDWGafRk7gPpc=; b=lDMMOIL14l7ufUNV6xs2UXcYTPSgFU8h2wjQriVcS2+u/77N67wZRjQT7FyV14XZZX Vux7T+oSU2IBjynezw66qsucvl8LCudYt4kVtj7d/MhvU+9M1RHbFteRJnbPKK9savWX TZ7Fxz0SZVhpokqQDQ9UayzUwX67BwAJ7jAkGTPMP2UDpoYx4zKsVqceBL5OGkNvKOD3 0nLBCS+X6SysnRGEbJKpSuPi2UyBPHD+iafNpad9mdqffyDnlkPEGkjTySN1Z/lwDCKM FnT8+TMM7et/+H9Kj/T5wn8Bed6rojmWZbi8vv2j7EoBHAhqtJ1Kc9dEbGHDs4CZPmja BH0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=VBkSNIu9jBA5fHU0Y3NWECYXpRzyBbvDWGafRk7gPpc=; b=mW9L0JP87VZLIBfFNqpldI6b88mkkNBZtnLLFKDWVRu/6oGT+0DsrbuYSXmlmYI5/T VQCos3oeztXZfEP460z9fiHX9mmVi7HzRkZ+LlWs77f5lnm7K6q/Xum1Ul5Ua0ItPGaK 8wtvw/VIdNdTU0leeRXQPHWDNiVZ0ty6fBFaoIONb4CzGKjwGlTgdhGbGPJj8hCOhuq/ 7ooSmxNIv5G7RxhWkMOfSGDnE2kEGW9xpMFS6oU37uv5EhyqY8x91e+ItAbK3eedljw8 yvTmWLsX4+AoXRTpjJXuQV4ZkRCW+RLyfOOHf2mSkPFFBf6+5oal966j1IIZoGb80haG Rgow== X-Gm-Message-State: AOAM533bKogkOmtuOdA0IPbKSOAb2/8Ur71HaSd9IzT5KNTU+QdQJi0h KKPzzY/TNsVuC+WvfbXzk9TomQ38cvg= X-Google-Smtp-Source: ABdhPJxtVHhpwFKWAYnXpm2TJ6lXr751fh1nwggvs/oXsM+PTB9DFxC/IoGnBlNEJZovlhan+BixSQ== X-Received: by 2002:a17:906:4146:: with SMTP id l6mr9231494ejk.295.1617283148011; Thu, 01 Apr 2021 06:19:08 -0700 (PDT) Received: from BV030612LT ([188.24.140.160]) by smtp.gmail.com with ESMTPSA id jv19sm2751559ejc.74.2021.04.01.06.19.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Apr 2021 06:19:07 -0700 (PDT) Date: Thu, 1 Apr 2021 16:19:05 +0300 From: Cristian Ciocaltea To: Manivannan Sadhasivam Cc: Andreas =?iso-8859-1?Q?F=E4rber?= , Rob Herring , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-actions@lists.infradead.org, linux-kernel@vger.kernel.org, matheus@castello.eng.br Subject: Re: [PATCH v2 0/6] Add support for Actions Semi Owl socinfo Message-ID: <20210401131905.GA2001688@BV030612LT> References: <20210401052438.GB14052@work> <20210401094041.GA1993499@BV030612LT> <20210401102717.GF14052@work> <252dd954-c8f1-fa2a-c37a-ede386fc9d43@suse.de> <20210401105805.GA1998829@BV030612LT> <20210401110752.GG14052@work> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210401110752.GG14052@work> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210401_141908_713058_64813426 X-CRM114-Status: GOOD ( 43.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Apr 01, 2021 at 04:37:52PM +0530, Manivannan Sadhasivam wrote: > + Matheus > = > On Thu, Apr 01, 2021 at 01:58:05PM +0300, Cristian Ciocaltea wrote: > > Hi Mani, Andreas, > > = > > On Thu, Apr 01, 2021 at 12:49:37PM +0200, Andreas F=E4rber wrote: > > > Hi, > > > = > > > On 01.04.21 12:27, Manivannan Sadhasivam wrote: > > > > On Thu, Apr 01, 2021 at 12:40:41PM +0300, Cristian Ciocaltea wrote: > > > >> On Thu, Apr 01, 2021 at 10:54:38AM +0530, Manivannan Sadhasivam wr= ote: > > > >>> On Tue, Mar 30, 2021 at 04:48:15PM +0300, Cristian Ciocaltea wrot= e: > > > >>>> This patchset adds a socinfo driver which provides information a= bout > > > >>>> Actions Semi Owl SoCs to user space via sysfs: machine, family, = soc_id, > > > >>>> serial_number. > > > >>>> > > > >>>> Please note the serial number is currently available only for th= e S500 > > > >>>> SoC variant. > > > >>>> > > > >>>> This has been tested on the S500 SoC based RoseapplePi SBC. > > > >>>> > > > >>> > > > >>> Is this the soc_id provided by the vendor bootloader (uboot)? If = so, under > > > >>> what basis it provides? I don't think the SoC has the provision f= or > > > >>> soc_id based on HW parameters. > > > >> > > > >> No, the soc_id is not provided by the bootloader, or at least I co= uldn't > > > >> identify any related implementation. Instead, I provided this via = the > > > >> driver itself, since I've encountered this approach in some other = soc > > > >> drivers as well (e.g. imx/soc-imx.c, versatile/soc-integrator.c). = > > > >> > > > > = > > > > Sorry, I was referring to serial_number. Since your comment says so= , can > > > > you point to the corresponding code? > > > = > > > Seconded that this needs to be better understood. If this is just a > > > convention of some downstream U-Boot that's not implemented in mainli= ne > > > (and maybe not even for Guitar or Labrador? tested on RoseapplePi onl= y), > > > it might not be worth its own reserved-memory based kernel driver? > > = > > The serial number is actually provided by the s500-bootloader for which > > Actions did not provide the source code, at least it is not available > > in the xapp github repo. I did not find anything related to this in > > downstream U-Boot. > > = > = > Hmm, then we can consider this as the firmware dependent property. But > can we get consensus that this is common for all S500 SoCs? This should work on all S500 SoCs, as the downstream Linux kernel doesn't use any conditional logic around reading those memory locations. Please see "owl_check_revision()" in arch/arm/mach-owl/board-owl.c, from any of the following repos: * https://github.com/xapp-le/kernel * https://github.com/LeMaker/linux-actions > Maybe, > Matheus can verify it on Labrador? The verification is pretty straightforward: the serial number is dumped on the serial console by the s500 bootloader right before starting U-boot: load uboot: load address is 0x8000000, entry point is 0x8000040 in fourth chip serial no =3D 9d,4b,f,6d,31,46,e,8, [...] U-Boot 2015.04 (Apr 23 2020 - 23:01:25)Actions-Semi The socinfo driver should provide the equivalent information, but in reversed order (due to integer representation on LE arch): $ cat /sys/devices/soc0/serial_number 080e46316d0f4b9d > I don't think adding a SOCINFO driver for a single board is a good idea. The driver could be used for all Owl SoC variants, including S700 and S900, even though accessing the serial number is currently supported only on S500. Unfortunately I do only have this S500 SoC based SBC to experiment with, therefore I cannot enable new features for the hardware I'm not able to validate. Btw, do you know where I could get an S700 or S900 board from? I couldn't find any so far.. Thanks, Cristi > Thanks, > Mani > = > > Kind regards, > > Cristi > > = > > > Implementing a standard interface such as DMI tables or a DT property= in > > > mainline U-Boot may be more useful then. Is it still Mani's S900 only? > > > = > > > Regards, > > > Andreas > > > = > > > -- = > > > SUSE Software Solutions Germany GmbH > > > Maxfeldstr. 5, 90409 N=FCrnberg, Germany > > > GF: Felix Imend=F6rffer > > > HRB 36809 (AG N=FCrnberg) _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel