From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 514C5C433ED for ; Thu, 1 Apr 2021 15:57:31 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A93D761247 for ; Thu, 1 Apr 2021 15:57:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A93D761247 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=M8fqPhV2B0DdXLcQu78Lqo9MTHBTE5Lui4AZYDglGAE=; b=P16GYsttXA2Aa3wfVGi2tbex1 lxYMJyA0P7gpRYgkurVM3gp6ny9gkg1ROKc2/e2zX4rulZMF4sOKrNfUKsYuCxYLsdTkGtn5QJmxQ njRLZ0CHTQR3PbUsr3zEwY05426qlX4ms1bhOX7teY/phn0WcK6DgDFlGEGSyzccfyjK+tzT2T2HZ znnT9vl+9PZDkSoPXFbcLbdYp2RlxUjUwYFSbmawKbh2fCus8KvRQafmCjN8lEUWilZZ6niNIOYVf ptzrNSIOaf/qQw0KEGOxcQMDuEbUvLjDxdQd2/7rbOtOOMSP5ri7LxWbJ/cuEpFOelogkTBkE32Oe y+w/LU1Uw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lRzfg-00A6t1-Is; Thu, 01 Apr 2021 15:55:49 +0000 Received: from mail.kernel.org ([198.145.29.99]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lRzYT-00A4fm-6S for linux-arm-kernel@lists.infradead.org; Thu, 01 Apr 2021 15:48:31 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 811FC61006; Thu, 1 Apr 2021 15:48:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1617292099; bh=VeUt7aXaRs7KYH0Vx8CyRaYLs92NWnN+wtuiToutDtI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cNjStIl+7EfH7/YxO2syHozo9wv3xi9kXOGZeXudPC4wcRuOA7qt8I4ZqLdZQlnza NWhp+6fsvp5V2GoxssadWyeuOTnFY4D9WTn+KBlvp815TiWyGBMSnC1pDyC3vwDnaE 1kXfKTiRWAC6Naz1e/TojoWOBdCupz1uaGT7VA6AYCQJhl77nVA5wp0BCohvso3FqK rh6yju+s6swn8PURJqFINVXoTnU5RpWJ9C45Bd9XN66OARfMigMdvylDdyzK058XBp 1wzuJAusiqh5WHHWrijIVyu/ILAEgzlc6iZVsMdASUr00jcI2QvfQPTEfaOJw5Ndal G2x8FQrozgF8g== Date: Thu, 1 Apr 2021 16:48:05 +0100 From: Mark Brown To: Marc Zyngier Cc: Catalin Marinas , Will Deacon , Mark Rutland , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] arm64: Disable fine grained traps on boot Message-ID: <20210401154805.GL4758@sirena.org.uk> References: <20210401124936.56877-1-broonie@kernel.org> <87sg4aox44.wl-maz@kernel.org> MIME-Version: 1.0 In-Reply-To: <87sg4aox44.wl-maz@kernel.org> X-Cookie: You can't take damsel here now. User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210401_164822_673688_1056C426 X-CRM114-Status: GOOD ( 15.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============8621152565312050950==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============8621152565312050950== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="6CXocAQn8Xbegyxo" Content-Disposition: inline --6CXocAQn8Xbegyxo Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Apr 01, 2021 at 04:14:35PM +0100, Marc Zyngier wrote: > On Thu, 01 Apr 2021 13:49:36 +0100, > Mark Brown wrote: > > + msr_s SYS_HFGRTR_EL2, xzr > > + msr_s SYS_HFGITR_EL2, xzr > > + msr_s SYS_HFGWTR_EL2, xzr > nit: consider grouping SYS_HFGWTR_EL2 and SYS_HFGRTR_EL2 together, > since they affect the same registers. Ack, I'd sorted them numerically IIRC. > > + mrs x1, id_aa64pfr0_el1 // AMU traps UNDEF without AMU > > + ubfx x1, x1, #ID_AA64PFR0_AMU_SHIFT, #4 > > + cbz x1, .Lskip_fgt_\@ > > + msr_s SYS_HAFGRTR_EL2, xzr > Do we need to document the need for SCR_EL3.FGTEn to be set so that > these register accesses don't trap? That'd be consistent with what we > do for other features (PtrAuth, AMU...). Yes, good point. We should if this is going in - this is the result of some other stuff I've been sending to document disabling these on boot, Will wanted to have code doing that, so I'll pull that into there. It does end up being a bit weird that we demand this be enabled so we can explicitly not use it, but better to do that so we can in future decide to take advantage of it. --6CXocAQn8Xbegyxo Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmBl6zQACgkQJNaLcl1U h9DXIwf8CBJb4g1z3rkdIIH9AOCNEQgvEFf9dshnp5U0j1sUgSe6st5osXUAOsSH zltZC7N5ZCTU65UCJCUNM2B0pJrg5kS31mHqGdJAq0csEQ4LKMwXb1V954jMDFKL B3/xdtQXSkCT4qXMWm/9TwLoA33fFNDJt85m6KoY9YlGX8Kl7zAWPei1BifrK3CJ tO9fVwj8WRLAmqj6Re4RVYUwY+K+WwM8olXI81YTloSTxEXZqte/MuxT9OrBWSrF ShNdwyCCop799b6McrCoz50cVp8BHCHr60rECRHCa21D0zqlXLnq42h3Ri8NBAtA pwKr0exbIcZSAaNE7W8EUSijCwxHjA== =jjji -----END PGP SIGNATURE----- --6CXocAQn8Xbegyxo-- --===============8621152565312050950== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============8621152565312050950==--