From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A661C433ED for ; Thu, 1 Apr 2021 16:39:19 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2248A61379 for ; Thu, 1 Apr 2021 16:39:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2248A61379 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=i0UREZvG4nUIKGWgSocBrv/ZYqs/UpUItS7aU8U94pM=; b=K3bK496uVYnkO9Ov4tX0sIxee +AYjLNHrOdMp+wk+9eCLvARNf1/O3MseMQuO+IdQhFmT6Re38zwdueSmNdRGombqt8UQaVMJBt8sR k6ex/Ay4ToCY0evIg/vv8YItKEWCjF4Rlv0HoL/itrxY9rCSYfl3aHSDBg4OzdxcG3vl1R0Ka9AkC i/VPbbXZXLT1SbAk8ixI2CNx095r8L5hPo3XJDyjvaLPT3JX5N3yJd62ZrOidon7/v69ZQl57ILOS PZVFVCvz6FusaRD0Xhnj3dj5llZK3ofPNKETE21Px6yBcYYtq6i/zRkSGnmSbyowaeGAFqZq94Kb9 mfJeobW3g==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lS0KR-00ALFK-Ay; Thu, 01 Apr 2021 16:37:55 +0000 Received: from mail.kernel.org ([198.145.29.99]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lS0KC-00ALBN-Qn for linux-arm-kernel@lists.infradead.org; Thu, 01 Apr 2021 16:37:45 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 7BD3861381; Thu, 1 Apr 2021 16:37:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1617295057; bh=mSocOIXGvAFKcL19Ce6fU683sMoxx6GOB2FI63UFFps=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pfG4Ny5Naj2xO9xJs/GhyfkzUzVPEQeW7HePHaZfQpEBvHsMoE1lwGJBb/BJJTaxu LUTinilDjFtooZMZrmOLb/hUKZBguT8qdlqESp7Is4n7dJZVoo00lOu+jqlZFuehBv xFVWQB5fH6jYeAqP1RSl77oan6W2dBgFrNW/7Bbw5CaRaedgR8kecWxdJ+9v4+6kKX Vu0AG3AcvLjiGo6cASKJTWUltZn2tikCt7qkRAD6CxQSq5OynMTpNQNRDpoHoKuPlo Ey4SipMN6Cv/6ZK//nVQA7KzYcBsJJaHRBGp9lrar9wH/NdJxw/UUq5x7MiVzUIahF WAHIpad4zTH0w== Date: Thu, 1 Apr 2021 09:37:32 -0700 From: Nathan Chancellor To: Maciej Falkowski Cc: aaro.koskinen@iki.fi, tony@atomide.com, linux@armlinux.org.uk, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com Subject: Re: [PATCH] ARM: OMAP1: ams-delta: remove unused function ams_delta_camera_power Message-ID: <20210401163732.gl63gs2dpi6pickt@archlinux-ax161> References: <20210401160434.7655-1-maciej.falkowski9@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210401160434.7655-1-maciej.falkowski9@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210401_173741_513664_E4E14B7E X-CRM114-Status: GOOD ( 17.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Apr 01, 2021 at 06:04:34PM +0200, Maciej Falkowski wrote: > The ams_delta_camera_power() function is unused as reports > Clang compilation with omap1_defconfig on linux-next: > > arch/arm/mach-omap1/board-ams-delta.c:462:12: warning: unused function 'ams_delta_camera_power' [-Wunused-function] > static int ams_delta_camera_power(struct device *dev, int power) > ^ > 1 warning generated. > > The soc_camera support was dropped without removing > ams_delta_camera_power() function, making it unused. > > Signed-off-by: Maciej Falkowski > Fixes: ce548396a433 ("media: mach-omap1: board-ams-delta.c: remove soc_camera dependencies") > Link: https://github.com/ClangBuiltLinux/linux/issues/1326 Thanks for the patch! Reviewed-by: Nathan Chancellor > --- > arch/arm/mach-omap1/board-ams-delta.c | 14 -------------- > 1 file changed, 14 deletions(-) > > diff --git a/arch/arm/mach-omap1/board-ams-delta.c b/arch/arm/mach-omap1/board-ams-delta.c > index 2ee527c00284..1026a816dcc0 100644 > --- a/arch/arm/mach-omap1/board-ams-delta.c > +++ b/arch/arm/mach-omap1/board-ams-delta.c > @@ -458,20 +458,6 @@ static struct gpiod_lookup_table leds_gpio_table = { > > #ifdef CONFIG_LEDS_TRIGGERS > DEFINE_LED_TRIGGER(ams_delta_camera_led_trigger); > - > -static int ams_delta_camera_power(struct device *dev, int power) > -{ > - /* > - * turn on camera LED > - */ > - if (power) > - led_trigger_event(ams_delta_camera_led_trigger, LED_FULL); > - else > - led_trigger_event(ams_delta_camera_led_trigger, LED_OFF); > - return 0; > -} > -#else > -#define ams_delta_camera_power NULL > #endif > > static struct platform_device ams_delta_audio_device = { > -- > 2.26.3 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel