From: Will Deacon <will@kernel.org>
To: iommu@lists.linux-foundation.org
Cc: linux-arm-kernel@lists.infradead.org,
Will Deacon <will@kernel.org>,
"Isaac J. Manjarres" <isaacm@codeaurora.org>,
Pratik Patel <pratikp@codeaurora.org>,
Robin Murphy <robin.murphy@arm.com>,
Lu Baolu <baolu.lu@linux.intel.com>
Subject: [RFC PATCH 1/6] iommu/io-pgtable: Introduce unmap_pages() as a page table op
Date: Thu, 1 Apr 2021 17:47:33 +0100 [thread overview]
Message-ID: <20210401164738.9513-2-will@kernel.org> (raw)
In-Reply-To: <20210401164738.9513-1-will@kernel.org>
From: "Isaac J. Manjarres" <isaacm@codeaurora.org>
The io-pgtable code expects to operate on a single block or
granule of memory that is supported by the IOMMU hardware when
unmapping memory.
This means that when a large buffer that consists of multiple
such blocks is unmapped, the io-pgtable code will walk the page
tables to the correct level to unmap each block, even for blocks
that are virtually contiguous and at the same level, which can
incur an overhead in performance.
Introduce the unmap_pages() page table op to express to the
io-pgtable code that it should unmap a number of blocks of
the same size, instead of a single block. Doing so allows
multiple blocks to be unmapped in one call to the io-pgtable
code, reducing the number of page table walks, and indirect
calls.
Signed-off-by: Isaac J. Manjarres <isaacm@codeaurora.org>
Suggested-by: Will Deacon <will@kernel.org>
Signed-off-by: Will Deacon <will@kernel.org>
---
include/linux/io-pgtable.h | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/include/linux/io-pgtable.h b/include/linux/io-pgtable.h
index a4c9ca2c31f1..2ed0c057d9e7 100644
--- a/include/linux/io-pgtable.h
+++ b/include/linux/io-pgtable.h
@@ -144,6 +144,7 @@ struct io_pgtable_cfg {
*
* @map: Map a physically contiguous memory region.
* @unmap: Unmap a physically contiguous memory region.
+ * @unmap_pages: Unmap a range of virtually contiguous pages of the same size.
* @iova_to_phys: Translate iova to physical address.
*
* These functions map directly onto the iommu_ops member functions with
@@ -154,6 +155,9 @@ struct io_pgtable_ops {
phys_addr_t paddr, size_t size, int prot, gfp_t gfp);
size_t (*unmap)(struct io_pgtable_ops *ops, unsigned long iova,
size_t size, struct iommu_iotlb_gather *gather);
+ size_t (*unmap_pages)(struct io_pgtable_ops *ops, unsigned long iova,
+ size_t pgsize, size_t pgcount,
+ struct iommu_iotlb_gather *gather);
phys_addr_t (*iova_to_phys)(struct io_pgtable_ops *ops,
unsigned long iova);
};
--
2.31.0.291.g576ba9dcdaf-goog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-04-01 16:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-01 16:47 [RFC PATCH 0/6] iommu_pgsize() improvements to help towards ->[un]map_pages() Will Deacon
2021-04-01 16:47 ` Will Deacon [this message]
2021-04-01 16:47 ` [RFC PATCH 2/6] iommu: Add an unmap_pages() op for IOMMU drivers Will Deacon
2021-04-01 16:47 ` [RFC PATCH 3/6] iommu: Use bitmap to calculate page size in iommu_pgsize() Will Deacon
[not found] ` <7c012a63e8a5ad1856aac08995e6f154@codeaurora.org>
2021-04-06 11:40 ` Will Deacon
2021-04-01 16:47 ` [RFC PATCH 4/6] iommu: Split 'addr_merge' argument to iommu_pgsize() into separate parts Will Deacon
2021-04-01 16:47 ` [RFC PATCH 5/6] iommu: Hook up '->unmap_pages' driver callback Will Deacon
2021-04-01 16:47 ` [RFC PATCH 6/6] iommu: Accomodate larger pages in iommu_pgsize() 'count' calculation Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210401164738.9513-2-will@kernel.org \
--to=will@kernel.org \
--cc=baolu.lu@linux.intel.com \
--cc=iommu@lists.linux-foundation.org \
--cc=isaacm@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=pratikp@codeaurora.org \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).