From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 760B3C43600 for ; Thu, 1 Apr 2021 17:58:50 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1AC8E60FF3 for ; Thu, 1 Apr 2021 17:58:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1AC8E60FF3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=tFaIvUs4VGu++RgvI8UROlkoy9v7ch9G7Iz0Y9Bt8Cs=; b=oLAWurnVYGjnY6dPETnh4VMRY SEpmLl8S9/ARKTKi8EOgRSz+TuZDBKzxdLl/seWvCvjR/hqrokpdYJVIOzCxNZwS+wgn1Ezj1t7+A Ss0Cwj4zrDIGL3Rcvu8Q9cZCzxZLncN1uwwj1ZBpWOFa67DOrFZeGi3xh7ivOx2qrS28od7BoaSmE H8DT+TS3Qu3dHsa8vfUIISowpAx42bQW8HGdiIID7RcTZ/T7VQ+8YJlPnJlkBKOPAco4T3LD5Gw8t IP74nTIWVlJFRqeXI/oyVEbDDIHV8W455k2F6BuCETKT53qhcSa55DmlOw77EjyHXx4VsPvjNacrn jz7MHXOdg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lS1Z9-00AbdG-FF; Thu, 01 Apr 2021 17:57:11 +0000 Received: from mail-ej1-x634.google.com ([2a00:1450:4864:20::634]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lS1Z4-00AbcZ-82; Thu, 01 Apr 2021 17:57:08 +0000 Received: by mail-ej1-x634.google.com with SMTP id kt15so4104397ejb.12; Thu, 01 Apr 2021 10:57:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=SU4RbOPNHP2ZwBcuTmWq/GTcYcUsYxKHBsEME1pvvGQ=; b=Pk+H3SeIsgoAjYphDeLPalvCm6EsJbsA7KyLIPux7/WfS3x7EsLRgUNfTPL4QwprU3 sHWuE5J2TsFm5rYykvq+Vn4uw2nmvPDVjeEnQQ9hDzxbn3U3a3+3WlCHUhEXFpCW13N+ /vSnIMRA6aHL9eRRmias0UlyXR/0nbCS8ba+mBEVsLz40sOSo5NAq3LhSN6JvTD3ml7w jBSXTrdIcjUwtNlUTLYVhXfob8OnG3eH7o5AsljAUNBylL1TTiQNWdx5zLunp4cptHFX t2JIJe9XIsyu5Ul9/4lN3UokJtOwhYeQDo9BjnbedAGxHj37dVRX3RBJ4EY79+PMLPe9 +Bhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=SU4RbOPNHP2ZwBcuTmWq/GTcYcUsYxKHBsEME1pvvGQ=; b=QzPCdrOd4gTjw2y6XUbRCCjwf+8jlCwYNxrVQwQbbT9PIHoV8aQBtmQk4IgVSdUQ5Q kw1Xtl/ZtaEjW1EEDwlyzMzuqHnPQsN7jCQqUcnjcjECUJMzM8s2QHXdXtYg+YmW7557 GRolAd4oZU4PFB009Kn5CUQm4L6KroikrEMVkWpdoRLTUdP/9pTPf8mUvxBAWd5KTlr3 8hJMytKjrFuJhXp6igcrsiZ9DBqCFnkH2XVIFsQSaKGSdMFM+q9Kfd21hfFETWgCie/e uYI7WAWihdFc9flAYldxwrVUHk2ojpT+tlsYxYlAW7EQGjatCEg4TM7IYszev5RXXwZE ZZzA== X-Gm-Message-State: AOAM531adBfsYJHUdR8IyYXY9VMGFATj00GQxKOQ0H7MJl/9S2ewEg6M sRKLkGXK06VR89ndgdV5A/wz1KeUFcU= X-Google-Smtp-Source: ABdhPJzdA/tAYmJiie7zrEmMoslDQAs4DVN4ChKNsQPEoQCee4kryfkGjoQcSj/rqZOo4zGkwdVSvQ== X-Received: by 2002:a17:907:110c:: with SMTP id qu12mr10556442ejb.442.1617299825578; Thu, 01 Apr 2021 10:57:05 -0700 (PDT) Received: from BV030612LT ([188.24.140.160]) by smtp.gmail.com with ESMTPSA id yk8sm3167870ejb.123.2021.04.01.10.57.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Apr 2021 10:57:05 -0700 (PDT) Date: Thu, 1 Apr 2021 20:57:02 +0300 From: Cristian Ciocaltea To: Rob Herring Cc: Andreas =?iso-8859-1?Q?F=E4rber?= , Manivannan Sadhasivam , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-actions@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/6] dt-bindings: soc: actions: Add Actions Semi Owl socinfo binding Message-ID: <20210401175702.GB2016477@BV030612LT> References: <15da0257b10aa62bfb7046437915d05a614c01ee.1617110420.git.cristian.ciocaltea@gmail.com> <20210401170818.GB610119@robh.at.kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210401170818.GB610119@robh.at.kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210401_185706_443575_13460320 X-CRM114-Status: GOOD ( 19.58 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Apr 01, 2021 at 12:08:18PM -0500, Rob Herring wrote: > On Tue, Mar 30, 2021 at 04:48:17PM +0300, Cristian Ciocaltea wrote: > > Add devicetree binding for the Actions Semi Owl socinfo driver. > > > > Signed-off-by: Cristian Ciocaltea > > --- > > .../bindings/soc/actions/owl-socinfo.yaml | 57 +++++++++++++++++++ > > 1 file changed, 57 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/soc/actions/owl-socinfo.yaml > > > > diff --git a/Documentation/devicetree/bindings/soc/actions/owl-socinfo.yaml b/Documentation/devicetree/bindings/soc/actions/owl-socinfo.yaml > > new file mode 100644 > > index 000000000000..01e4a8b4f5ac > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/soc/actions/owl-socinfo.yaml > > @@ -0,0 +1,57 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/soc/actions/owl-socinfo.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Actions Semi Owl SoC info module > > + > > +maintainers: > > + - Cristian Ciocaltea > > + > > +description: | > > + Actions Semi Owl SoC info module provides access to various information > > + about the S500, S700 and S900 SoC variants, such as serial number or id. > > + > > +select: > > + properties: > > + compatible: > > + contains: > > + enum: > > + - actions,s500-soc > > + - actions,s700-soc > > + - actions,s900-soc > > + required: > > + - compatible > > + > > +properties: > > + compatible: > > + items: > > + - enum: > > + - actions,s500-soc > > + - actions,s700-soc > > + - actions,s900-soc > > + - const: simple-bus > > + > > +required: > > + - compatible > > + > > +additionalProperties: true > > + > > +examples: > > + - | > > + / { > > + compatible = "roseapplepi,roseapplepi", "actions,s500"; > > + model = "Roseapple Pi"; > > + #address-cells = <1>; > > + #size-cells = <1>; > > + > > + soc { > > + compatible = "actions,s500-soc", "simple-bus"; > > What's the actual h/w for this bus? Still looks like abuse of DT to > create your virtual soc_info driver. Right, there is no bus involved in accessing soc info, but I assumed the already existing soc node in common DTS is a good candidate for binding the driver. (e.g. arch/arm/boot/dts/owl-s500.dtsi) Should I, instead, create a dedicated sub-node? Thanks, Cristi > > > + #address-cells = <1>; > > + #size-cells = <1>; > > + ranges; > > + }; > > + }; > > + > > +... > > -- > > 2.31.1 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel