From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FE8DC433ED for ; Thu, 1 Apr 2021 21:29:00 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D1F67610F8 for ; Thu, 1 Apr 2021 21:28:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D1F67610F8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Mime-Version:References:In-Reply-To:Message-Id: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=3dweHKH2pTa7tQKWlqx0Hy4VVr+N0hYfyj8FjrpDgvc=; b=FuYfEtRrLiHAU99H7AK8qMVx2 eL9YJWmAgJ+Cc2EtfWi1TSq6H/vMeYlSK+9ETXAgdo99NoVPnAGeD6BynUIDKiq2gAipLZiNL1X4t Egn4yKoEQZUQWr3wlNicL+7PqpKUN+N8GPTyAay+G7WzRXRQeqwKBkm7pJwlgZ7XdNFzJfer3bCep qig2BxLBGv5cV/5BD4ELYtBsuamC5EQRtsNGc8BU/C7IR4DPLkDuDVr69yUmvd6WfhdYnytxcplup EMxzAbFR1gDV8BiKcjyiSZhU/GfUA7ojm6IAI71iKwJ4sUfq4ZyZ0WWgBkpqTqjNZH00ifuRPDYcx OxUdepIoQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lS4oi-00B3JX-1F; Thu, 01 Apr 2021 21:25:28 +0000 Received: from mail.kernel.org ([198.145.29.99]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lS4lG-00B35F-UZ for linux-arm-kernel@lists.infradead.org; Thu, 01 Apr 2021 21:22:52 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id A4340610F8; Thu, 1 Apr 2021 21:21:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1617312113; bh=fqFgia6xhcUSTm8pPYkWji0FiEe1A8KsE2ZdGQsnsjM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=WHW08u3rWaahx3qFLlnszE0gmloCWxA2IA+cvoFohd0HfSUReF3+Cy0fl8no1XKao Qas0X00DsfcfL2cLcd1wMIRV7GTC5OJXEofuaNQb3pSpT/pqiLfVVEuVy2X+upQZtT V5+A7T6BcIUNLgcUjYH6946PdRiAFgMtpdyOXDru10NfxAoRCcooi63DKHH6PtFXtQ LaYnGzoMryFry3vrD9T01YGyQpWIkoCY/iJGddX1kwO+TpQN/RD0Ev3Qkz7tqxjeoM wogIMZdP+MJt1vqvDXmUKAATXY/a1eIUtJiJDUt3QgzhEU58hxVR5SdlNSug6BCP+Z C6hPoR2m9GVNw== Date: Fri, 2 Apr 2021 06:21:49 +0900 From: Masami Hiramatsu To: zhouchuangao Cc: Catalin Marinas , Will Deacon , Jean-Philippe Brucker , Andrew Morton , Qais Yousef , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm64/kernel/probes: Use BUG_ON instead of if condition followed by BUG. Message-Id: <20210402062149.98ad11a0ec940cef86122fc2@kernel.org> In-Reply-To: <1617105472-6081-1-git-send-email-zhouchuangao@vivo.com> References: <1617105472-6081-1-git-send-email-zhouchuangao@vivo.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210401_222249_686068_DCAC9767 X-CRM114-Status: GOOD ( 14.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 30 Mar 2021 04:57:50 -0700 zhouchuangao wrote: > It can be optimized at compile time. > Anyway, this seems to make the code simpler. Reviewed-by: Masami Hiramatsu Thanks! > Signed-off-by: zhouchuangao > --- > arch/arm64/kernel/probes/kprobes.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/arch/arm64/kernel/probes/kprobes.c b/arch/arm64/kernel/probes/kprobes.c > index 66aac28..ecf0f61 100644 > --- a/arch/arm64/kernel/probes/kprobes.c > +++ b/arch/arm64/kernel/probes/kprobes.c > @@ -264,8 +264,7 @@ int __kprobes kprobe_fault_handler(struct pt_regs *regs, unsigned int fsr) > * normal page fault. > */ > instruction_pointer_set(regs, (unsigned long) cur->addr); > - if (!instruction_pointer(regs)) > - BUG(); > + BUG_ON(!instruction_pointer(regs)); > > if (kcb->kprobe_status == KPROBE_REENTER) > restore_previous_kprobe(kcb); > -- > 2.7.4 > -- Masami Hiramatsu _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel