From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72040C433B4 for ; Fri, 2 Apr 2021 14:23:07 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 079E361005 for ; Fri, 2 Apr 2021 14:23:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 079E361005 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=acm.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:Reply-To:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=W8cOAAsb5SbGrsyLbW91NvxjavZ3mOK0WWDSJhJnsSk=; b=PyPcm+BiOWjD1+FS8Y2cZxB6j olXlYz9UwbghGmIsxL4wq3MHYz8gifexOBdTMVxBxhqOx1X5zlG/XaQwFt9DquMrrty3PC5CDPsUi ay0iFdWSLSLG6KDuvLUk7h8rhU2/kf0AOVPOm4Wts4zJUNf/4piqaytkwXmY2lHUgt4pZ26e9vWTe 0CSAkhlACAkhe6u6t/H40yNyhmSf+cT5bBqcsSE7/J1jPoSNHrFuB/Y5wsLAqxJGnqzGv56LK8ocB 7We6COwJv552VdVN89UcFErvcsnymia+/NmGq3uZehBy1aSkRVMmZrn8VC0RMERqVY3ro1Ib6UOKy ovbrVu54g==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lSKg1-00D7tJ-9Y; Fri, 02 Apr 2021 14:21:33 +0000 Received: from mail-ot1-x331.google.com ([2607:f8b0:4864:20::331]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lSKfx-00D7sq-4p for linux-arm-kernel@lists.infradead.org; Fri, 02 Apr 2021 14:21:30 +0000 Received: by mail-ot1-x331.google.com with SMTP id m21-20020a9d7ad50000b02901b83efc84a0so5039273otn.10 for ; Fri, 02 Apr 2021 07:21:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:reply-to:references :mime-version:content-disposition:in-reply-to; bh=wFmEeiu8O3e8Ysh2Egg3y980B0w0wNYvL3AQsHO1K90=; b=TEke5GjgaqkttHMJd3gpOWOLZlhz+MiKptNdXq8ft1He/cIpADCj3tiZwUM9IYSw4V Gvvu7NIe9GL7P0s/lWgZAEyAviwLVRetY8SiH2c1VbyO1i/Tg8l9AY+WD+1EF/woPpfw rZBUW88EJspY50LRle0kjWmjeV/75EIcGor9r23rtDPE1G/M2kQMM3+y/hl6247D6rrf y7vV3SgypcrgIZcQipJSxG4KqvseVfEv3W9fsNylo2RXNfyFebh5btWeiLqZ4G04uUYr V4Cpss+112fE1xJx7eNhLhi30991uwkZKC31i9X3CgMq/2og6LMqgjONxTaOAPOtmXMz SGkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :reply-to:references:mime-version:content-disposition:in-reply-to; bh=wFmEeiu8O3e8Ysh2Egg3y980B0w0wNYvL3AQsHO1K90=; b=uDmgsMD1oCggzkwgW/4L9XatV67jMoHs+lcP8NcLNp7gt42/XyBdorsFk0Fy/R12r6 aihPyF7TNmiRV2tT90LXA6kmG0wskRf5AAmG20EYSx+6pWsV3lX1virCO6eoMNcK9dwz T6SSV1r/gFoZm8N/IcZq0acCfFhL85XkRq3zWBA5QRlcv15ZgVp4j23IHjMofku2XVOQ /GUkk6Url6X9Ahc7TYOqYcVsA2EnJP0hvonlYgT0OqBwTBM1E0HvpAXo+g8A8FgGDh35 LlmdwclpKyDF2uHu6ZAya1lmeVaFzsqSFVNHJ+2/gdnPH3dczKYupvu7P6Gxx7X3Yv3u stUA== X-Gm-Message-State: AOAM531CxPxJVyDGLM0S2cGCOyBGRRPNT893vI2qJUs1iHoA1nGQ3o3k xJmxGSm/KcpUQeb37LBRFQ== X-Google-Smtp-Source: ABdhPJwB49R/AXpP58aqRK6or0bUV24xyuHImwp2nt06uXJKkyQwip4E4SqGVpKu38xSByynoJ4+9g== X-Received: by 2002:a05:6830:15d2:: with SMTP id j18mr11707892otr.75.1617373286969; Fri, 02 Apr 2021 07:21:26 -0700 (PDT) Received: from serve.minyard.net (serve.minyard.net. [2001:470:b8f6:1b::1]) by smtp.gmail.com with ESMTPSA id b22sm1904897ots.59.2021.04.02.07.21.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Apr 2021 07:21:26 -0700 (PDT) Received: from minyard.net (unknown [IPv6:2001:470:b8f6:1b:f99f:823a:495e:5af]) by serve.minyard.net (Postfix) with ESMTPSA id 371D6180570; Fri, 2 Apr 2021 14:21:25 +0000 (UTC) Date: Fri, 2 Apr 2021 09:21:24 -0500 From: Corey Minyard To: Quan Nguyen Cc: Rob Herring , Joel Stanley , Andrew Jeffery , Wolfram Sang , Philipp Zabel , openipmi-developer@lists.sourceforge.net, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, openbmc@lists.ozlabs.org, Open Source Submission , Phong Vo , "Thang Q . Nguyen" Subject: Re: [PATCH v2 0/3] Add Aspeed SSIF BMC driver Message-ID: <20210402142124.GV507977@minyard.net> References: <20210330141029.20412-1-quan@os.amperecomputing.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210330141029.20412-1-quan@os.amperecomputing.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210402_152129_257245_EFCEA857 X-CRM114-Status: GOOD ( 21.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: minyard@acm.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Mar 30, 2021 at 09:10:26PM +0700, Quan Nguyen wrote: > This series add support for the Aspeed specific SSIF BMC driver which > is to perform in-band IPMI communication with the host in management > (BMC) side. I don't have any specific feedback for this, but I'm wondering if it's really necessary. Why can't the BMC just open the I2C device and use it? Is there any functionality that this provides that cannot be accomplished from userland access to the I2C device? I don't see any. If it tied into some existing framework to give abstract access to a BMC slave side interface, I'd be ok with this. But I don't see that. Unless there is a big need to have this in the kernel, I'm against including this and would suggest you do all this work in userland. Perhaps write a library. Sorry, but I'm trying to do my part to reduce unnecessary things in the kernel. Thanks, -corey > > v2: > + Fixed compiling error with COMPILE_TEST for arc > > Quan Nguyen (3): > i2c: i2c-core-smbus: Expose PEC calculate function for generic use > drivers: char: ipmi: Add Aspeed SSIF BMC driver > bindings: ipmi: Add binding for Aspeed SSIF BMC driver > > .../bindings/ipmi/aspeed-ssif-bmc.txt | 18 + > drivers/char/ipmi/Kconfig | 22 + > drivers/char/ipmi/Makefile | 2 + > drivers/char/ipmi/ssif_bmc.c | 645 ++++++++++++++++++ > drivers/char/ipmi/ssif_bmc.h | 92 +++ > drivers/char/ipmi/ssif_bmc_aspeed.c | 132 ++++ > drivers/i2c/i2c-core-smbus.c | 12 +- > include/linux/i2c.h | 1 + > 8 files changed, 922 insertions(+), 2 deletions(-) > create mode 100644 Documentation/devicetree/bindings/ipmi/aspeed-ssif-bmc.txt > create mode 100644 drivers/char/ipmi/ssif_bmc.c > create mode 100644 drivers/char/ipmi/ssif_bmc.h > create mode 100644 drivers/char/ipmi/ssif_bmc_aspeed.c > > -- > 2.28.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel