From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A327CC433B4 for ; Fri, 2 Apr 2021 18:06:05 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 43A61610A5 for ; Fri, 2 Apr 2021 18:06:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 43A61610A5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=s85BDuE49x3f2IaQKM5k76S/ZcQh8NjrrmnE7pg/45U=; b=rY6COMPJzY03/PCETlbTunI6B jFPnfQv6HtOLDudd63foJTLiPGNGV9BMrXgr20VisEomTTCuOW4fVF5Tssg19kEOmapAWiQIHq3aW Dgbh+2CfdjEBJ3PQsQ6Kx5DsbcaNzvm/ABP1l7iOAzJDZJwxqRPmb83QYm+jXLRNwoSqIsl3jbIGo td/w4SzRoEAI8ZGlIFxBAJHcFlbJsuuem697XVR1FphT8+Fe0XHGpbaESVxNJ0T/Re8buNjgNioUn wO+uDDgMHg7TYPRXift5OgZo6vJhsPDZbAgKDw4N2byqr92y2+CS3COVtiQjM802EID4WmVMMK2xp byHJ+2wqA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lSO9e-00DXtB-IR; Fri, 02 Apr 2021 18:04:26 +0000 Received: from mail.kernel.org ([198.145.29.99]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lSO9Z-00DXsF-8m; Fri, 02 Apr 2021 18:04:19 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 8C47861103; Fri, 2 Apr 2021 18:04:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1617386654; bh=kFNql03iRJYWFFqCOpmJeMMhSwVZGro/bynT35/QM7Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YhfIqSv9ITyDPO8D/gVwv1tf48FBxjioByYJt+Ln6wAreHnm8sNKJ73WUwvKShrhM Drl4OfahXF53Dhe+fsRyJSUJceNSw+Id9vMmmQ8nTyxLpye3bJISmcEfoORt3MyL6G QJPiKZDBajUT1N7UwNzKz9tNE4kIVwol0zHrJrdSrnEnLdfUzIrbaQjw+pbcos7XOO 4dKe4oQje+7TkDwAFzULs5h5Cw7g3Xje+SYnxcMeS5ip3Oh8wEEwrU8pFf6pVe8I2W lbX3/1yiFUJmqPUyi6dLVksyJnytuTi13SbJkvugJrCy7nKzeJ6WWmt2UEKpFCdCk0 q63exufmS2fMw== Date: Fri, 2 Apr 2021 23:34:07 +0530 From: Manivannan Sadhasivam To: Cristian Ciocaltea Cc: Rob Herring , Andreas =?iso-8859-1?Q?F=E4rber?= , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-actions@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/6] dt-bindings: soc: actions: Add Actions Semi Owl socinfo binding Message-ID: <20210402180407.GA31906@thinkpad> References: <15da0257b10aa62bfb7046437915d05a614c01ee.1617110420.git.cristian.ciocaltea@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <15da0257b10aa62bfb7046437915d05a614c01ee.1617110420.git.cristian.ciocaltea@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210402_190417_692492_C0AF9560 X-CRM114-Status: GOOD ( 18.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Mar 30, 2021 at 04:48:17PM +0300, Cristian Ciocaltea wrote: > Add devicetree binding for the Actions Semi Owl socinfo driver. > Devicetree binding shouldn't be added for a driver instead for an IP or hw. > Signed-off-by: Cristian Ciocaltea > --- > .../bindings/soc/actions/owl-socinfo.yaml | 57 +++++++++++++++++++ > 1 file changed, 57 insertions(+) > create mode 100644 Documentation/devicetree/bindings/soc/actions/owl-socinfo.yaml > > diff --git a/Documentation/devicetree/bindings/soc/actions/owl-socinfo.yaml b/Documentation/devicetree/bindings/soc/actions/owl-socinfo.yaml > new file mode 100644 > index 000000000000..01e4a8b4f5ac > --- /dev/null > +++ b/Documentation/devicetree/bindings/soc/actions/owl-socinfo.yaml > @@ -0,0 +1,57 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/soc/actions/owl-socinfo.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Actions Semi Owl SoC info module > + > +maintainers: > + - Cristian Ciocaltea > + > +description: | > + Actions Semi Owl SoC info module provides access to various information > + about the S500, S700 and S900 SoC variants, such as serial number or id. > + S700/S900 are not yet confirmed, so please avoid them. > +select: > + properties: > + compatible: > + contains: > + enum: > + - actions,s500-soc > + - actions,s700-soc > + - actions,s900-soc > + required: > + - compatible > + > +properties: > + compatible: > + items: > + - enum: > + - actions,s500-soc > + - actions,s700-soc > + - actions,s900-soc > + - const: simple-bus > + > +required: > + - compatible > + > +additionalProperties: true > + > +examples: > + - | > + / { > + compatible = "roseapplepi,roseapplepi", "actions,s500"; > + model = "Roseapple Pi"; > + #address-cells = <1>; > + #size-cells = <1>; > + > + soc { > + compatible = "actions,s500-soc", "simple-bus"; No. This shouldn't fall under /soc. I think you should added a separate compatible for the reserved memory itself and add a corresponding socinfo driver under drivers/soc. This way it is obvious that the information is contained in a memory region and a driver is used for parsing that. Thanks, Mani > + #address-cells = <1>; > + #size-cells = <1>; > + ranges; > + }; > + }; > + > +... > -- > 2.31.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel