From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03B9CC433B4 for ; Fri, 2 Apr 2021 19:27:57 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9556561164 for ; Fri, 2 Apr 2021 19:27:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9556561164 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=O3sCyxwtY3ejqzGmjHRrHysnZ1nwXs5ohGEOVOKsLLM=; b=kCf17CHd6qA7W02qjbVpDomzs CiyYwhhEh0Hsn29PcYsRM8+7CM+2bHkW7BRkNxCkSoCo1xypXuQUHJ5j9Lvl5djBhYIxxueEF/fet NgJ6oAyKEEdWQ13iQJyvxb7uLm6lp+gWPDOUdlREZct3NQHTaorCsnSXUT0QN7fCo/cP3nuYyOgun ZuH0asI8ht28wHYcbPuJp1JatgwOJv0bLjnsN4tWS1GErsSDVgKm8x7BxFfe+vS2lnDgVg5xphYi7 hOFbwEH7mKQuv8coVWlo5+TYtddgSKPp1xJTWfYHXgfXdJxEPGTd/yR1eU2Ewebl5LBnzkhTiE+MB Ev6/eG5hQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lSPQn-00DfvE-N1; Fri, 02 Apr 2021 19:26:10 +0000 Received: from mail-ed1-x52a.google.com ([2a00:1450:4864:20::52a]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lSPQf-00Dfqp-BK; Fri, 02 Apr 2021 19:26:04 +0000 Received: by mail-ed1-x52a.google.com with SMTP id l18so6351943edc.9; Fri, 02 Apr 2021 12:25:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=eBa1l0nkkvfTf4uuzpNC8DhkE5lg+13JVTfQ5ud3GcE=; b=A5owe0ywEifla9cqAwxdKeZzym4fxNR9UBjsxw86RxuLyevdtD34PPVnFCPX1XZDD8 97B1ynxpvQGkMusOuC2GvfxNZD666mpEf3EzauHUDxcBllWka/mZTCubSaZmPFi1YdQH CS1GACuYXaOB4JHh1Titvx/SO6KfNDx3u80Hc8KRe7AP4Kngxul9MFdjW/ZyGu4in5mW LGYQKbFegQEmaes5kRgHgCX3c/0eZ4KCXlkXadCj/rNDVvRb3SDI1hs31wiOmygCw+hr r4c1XiCH6vVkxsoYbVyYFomUTjgQZeOc0vC5cX2ms5AA9DrjQ9vcEZaPOAf0bkSTA0V2 rd8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=eBa1l0nkkvfTf4uuzpNC8DhkE5lg+13JVTfQ5ud3GcE=; b=uA7SlKT6ADLk/KuAmS4GxV3QtWKTc2EKyZOHbHc+u3aPj+rluoiianBRt11HeSB4hj HvzN7Tcm7tCZHNIycBQ0Kx4K/qtw3bXLic9Ckc3AdC/l7my/ROMtewNq0Dv0W1oklEXq 9z2vl+omzkUGEgBopJjC/+R2LcKMiWZZjuIexfmmxqpOtqQr9ftrQh54QP0y6nfo0v3S +9mAW7mqu2nZjNtM8ES267qHpxq7V7fwQNs4gcVcBdrp5EWXJ56OYAsKt4HrY3r2aL4+ A8xOeXLfpBhSFJ+kkrk4QwBJb5PPyAasuW7bLrHC2AigH06JY6THkY5tbWyojt4mAOzP yh1Q== X-Gm-Message-State: AOAM530o6OKqT5q92D/QltAbCtna65p3QLJuDd6MeZSurs8ei8PYHDar ZfgeQVE0PnWe1LzDPnXIU7s= X-Google-Smtp-Source: ABdhPJyavIkdyCjowSW48m9XSi0klJz2e7GZPVIBZdf7s99BueQwLG4v7nsfEpVUkPZMMnS81OZ3+g== X-Received: by 2002:a05:6402:2787:: with SMTP id b7mr1875410ede.225.1617391558402; Fri, 02 Apr 2021 12:25:58 -0700 (PDT) Received: from BV030612LT ([188.24.140.160]) by smtp.gmail.com with ESMTPSA id x24sm754352edr.36.2021.04.02.12.25.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Apr 2021 12:25:57 -0700 (PDT) Date: Fri, 2 Apr 2021 22:25:55 +0300 From: Cristian Ciocaltea To: Manivannan Sadhasivam Cc: Rob Herring , Andreas =?iso-8859-1?Q?F=E4rber?= , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-actions@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/6] dt-bindings: soc: actions: Add Actions Semi Owl socinfo binding Message-ID: <20210402192555.GA2052516@BV030612LT> References: <15da0257b10aa62bfb7046437915d05a614c01ee.1617110420.git.cristian.ciocaltea@gmail.com> <20210402180407.GA31906@thinkpad> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210402180407.GA31906@thinkpad> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210402_202601_498731_D2C89C55 X-CRM114-Status: GOOD ( 28.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Apr 02, 2021 at 11:34:07PM +0530, Manivannan Sadhasivam wrote: > On Tue, Mar 30, 2021 at 04:48:17PM +0300, Cristian Ciocaltea wrote: > > Add devicetree binding for the Actions Semi Owl socinfo driver. > > > > Devicetree binding shouldn't be added for a driver instead for an IP or hw. > > > Signed-off-by: Cristian Ciocaltea > > --- > > .../bindings/soc/actions/owl-socinfo.yaml | 57 +++++++++++++++++++ > > 1 file changed, 57 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/soc/actions/owl-socinfo.yaml > > > > diff --git a/Documentation/devicetree/bindings/soc/actions/owl-socinfo.yaml b/Documentation/devicetree/bindings/soc/actions/owl-socinfo.yaml > > new file mode 100644 > > index 000000000000..01e4a8b4f5ac > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/soc/actions/owl-socinfo.yaml > > @@ -0,0 +1,57 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/soc/actions/owl-socinfo.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Actions Semi Owl SoC info module > > + > > +maintainers: > > + - Cristian Ciocaltea > > + > > +description: | > > + Actions Semi Owl SoC info module provides access to various information > > + about the S500, S700 and S900 SoC variants, such as serial number or id. > > + > > S700/S900 are not yet confirmed, so please avoid them. > > > +select: > > + properties: > > + compatible: > > + contains: > > + enum: > > + - actions,s500-soc > > + - actions,s700-soc > > + - actions,s900-soc > > + required: > > + - compatible > > + > > +properties: > > + compatible: > > + items: > > + - enum: > > + - actions,s500-soc > > + - actions,s700-soc > > + - actions,s900-soc > > + - const: simple-bus > > + > > +required: > > + - compatible > > + > > +additionalProperties: true > > + > > +examples: > > + - | > > + / { > > + compatible = "roseapplepi,roseapplepi", "actions,s500"; > > + model = "Roseapple Pi"; > > + #address-cells = <1>; > > + #size-cells = <1>; > > + > > + soc { > > + compatible = "actions,s500-soc", "simple-bus"; > > No. This shouldn't fall under /soc. I think you should added a separate > compatible for the reserved memory itself and add a corresponding socinfo > driver under drivers/soc. > > This way it is obvious that the information is contained in a memory region and > a driver is used for parsing that. I avoided on purpose to bind the driver on the reserved memory node in order to be able to handle also the S700 and S900 SoCs, for which we currently provide (only) the following information: machine, family, soc_id. I assumed the serial_number is not mandatory and we can use the driver as it is for all SoC variants. I don't know how the serial number for S700 and S900 could be read, but I think it is very likely they require a different access method. Hence my intention was to keep the driver generic, not coupled strictly with the serial number information. Regards, Cristi > Thanks, > Mani > > > + #address-cells = <1>; > > + #size-cells = <1>; > > + ranges; > > + }; > > + }; > > + > > +... > > -- > > 2.31.1 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel