From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED75BC433ED for ; Tue, 6 Apr 2021 13:09:04 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 75985613B7 for ; Tue, 6 Apr 2021 13:09:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 75985613B7 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=jdDgEWWeODsPHZ/Rpt6Yy+2yzz8MEeP8jQxn8VuyThk=; b=UJYcUKh7LyFfoTriTJvjQdjyg sYrVLablbOfh9OZ5gsEQWOkh/0fx57/7KgM/+p89YDHXBVn/34EyAFqsItkbryVEDTb7qZZwWPCrf tloSftxfiRfH7RqJzfzcdPkcJw9kvcY3UVUHAEj+iQcGJzY2Z9i7JsXtjJC8jtpD/a6U7xdeqNjD5 68qoyIZQBMUBtVN6bU+7IkItiyr1V0Q3UrgNB+HO2myOjTx6Eqm9X1XWH+Nyb6a8oIL0SyfzZS/wW pucPVPPPVjei+b3GxKKprLfuolFCf0NJxsFzbd2xL3fv5N8xII3TZ2aq/T3cuG8kTjePj57eOP6Cc EKo9avLtA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lTlQN-002fG0-4r; Tue, 06 Apr 2021 13:07:19 +0000 Received: from fllv0016.ext.ti.com ([198.47.19.142]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lTlQH-002fFD-G7 for linux-arm-kernel@lists.infradead.org; Tue, 06 Apr 2021 13:07:15 +0000 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 136D6vLo002198; Tue, 6 Apr 2021 08:06:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1617714417; bh=uma/HGrD7FSNCA7vvx/wHhmqWGFic54vXdLDcyBqkzU=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=iOFmoAFC0it38WA1hWkUfWIIYyFgiaYp9wlsdcmZPU21THa0Ed0py7uQSsZFVKJVG RWOUhcNqciVDbgxc2m9cqOlILpHb1r7MleBBC2Ikg7nJcL9o81IbFpy6ZUxxJhfE3y /BXz44wNFYJY1hYRsduyBHwLdPlZQ7uPm7j973kI= Received: from DFLE111.ent.ti.com (dfle111.ent.ti.com [10.64.6.32]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 136D6vhR008986 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 6 Apr 2021 08:06:57 -0500 Received: from DFLE103.ent.ti.com (10.64.6.24) by DFLE111.ent.ti.com (10.64.6.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Tue, 6 Apr 2021 08:06:57 -0500 Received: from fllv0040.itg.ti.com (10.64.41.20) by DFLE103.ent.ti.com (10.64.6.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2 via Frontend Transport; Tue, 6 Apr 2021 08:06:57 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id 136D6vSh112043; Tue, 6 Apr 2021 08:06:57 -0500 Date: Tue, 6 Apr 2021 08:06:57 -0500 From: Nishanth Menon To: Qiheng Lin CC: Santosh Shilimkar , , , , Hulk Robot Subject: Re: [PATCH -next] PM: AVS: remove redundant dev_err call in omap_sr_probe() Message-ID: <20210406130657.c5edf3pakylxwavr@spoon> References: <20210406122840.39-1-linqiheng@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210406122840.39-1-linqiheng@huawei.com> User-Agent: NeoMutt/20171215 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210406_140713_827872_E6722307 X-CRM114-Status: GOOD ( 15.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 20:28-20210406, Qiheng Lin wrote: > There is a error message within devm_ioremap_resource > already, so remove the dev_err call to avoid redundant > error message. > > Reported-by: Hulk Robot > Signed-off-by: Qiheng Lin > --- > drivers/soc/ti/smartreflex.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/soc/ti/smartreflex.c b/drivers/soc/ti/smartreflex.c > index 5376f3d22f31..06cbee5fd254 100644 > --- a/drivers/soc/ti/smartreflex.c > +++ b/drivers/soc/ti/smartreflex.c > @@ -846,10 +846,8 @@ static int omap_sr_probe(struct platform_device *pdev) > > mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); > sr_info->base = devm_ioremap_resource(&pdev->dev, mem); > - if (IS_ERR(sr_info->base)) { > - dev_err(&pdev->dev, "%s: ioremap fail\n", __func__); > + if (IS_ERR(sr_info->base)) > return PTR_ERR(sr_info->base); > - } > > irq = platform_get_resource(pdev, IORESOURCE_IRQ, 0); > > Reviewed-by: Nishanth Menon -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel