From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56D60C433B4 for ; Wed, 7 Apr 2021 16:56:50 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ED2AE6120E for ; Wed, 7 Apr 2021 16:56:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ED2AE6120E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ZiiNCt6RDAEoMdJeRZTkYlcZ99HnSw6YgWZSN6ypWhA=; b=g9/FtheMFaXha1A3MtiXXbIQ5 6tfXN/8DHaYY39O/12JWy8wrK3cDZUtj4YvgHUwceOo5d3aMvrQrmGxapEcQjqk1qHwQZ/CiKv5QP AMYvG0g36XFKVx7zr+B+aYFulP2+Mx0+ERCJQekl09DKIr/ZuCeIXhaAQk6ACcfxlM1vtWrxRB3Dn 2/BN9evuh5PqEiWnjD6y2R49tLTAfGPqmuTEBY6sa+pv17M4VWPSYsd/G9C6E9oJIYeISZrbGkZVw CiLEP0UNwSXeS8OEDSi9vBphYGTv1LGWphkDVFGFn0daNU55O5/DE03zXVlwH7lCeEpMO1wnq5aUk LO/VNU6Dw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lUBRd-005Vwh-5x; Wed, 07 Apr 2021 16:54:21 +0000 Received: from mga09.intel.com ([134.134.136.24]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lUBRX-005Vw9-MA for linux-arm-kernel@lists.infradead.org; Wed, 07 Apr 2021 16:54:18 +0000 IronPort-SDR: kNOR2HIfuiHOk6r/WejlT0xFsjmWryWrRSp1ZxugYrUxHMgpfXx1JQX1ubEVpVl4ylQh1GcZbH H3vtE8LXJ8pA== X-IronPort-AV: E=McAfee;i="6000,8403,9947"; a="193465290" X-IronPort-AV: E=Sophos;i="5.82,203,1613462400"; d="scan'208";a="193465290" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Apr 2021 09:54:13 -0700 IronPort-SDR: 2a8Kf6WaNd/0kxyeCZqP4ukkq0OmJunrLAZ3NAgBJ+INoMBdilDMdz2NV0XM/GzRMyIYk3jRsG wXeqclFq4xGg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,203,1613462400"; d="scan'208";a="530272883" Received: from linux.intel.com ([10.54.29.200]) by orsmga004.jf.intel.com with ESMTP; 07 Apr 2021 09:54:13 -0700 Received: from linux.intel.com (unknown [10.88.229.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by linux.intel.com (Postfix) with ESMTPS id 7BE2E5805A1; Wed, 7 Apr 2021 09:54:10 -0700 (PDT) Date: Thu, 8 Apr 2021 00:54:07 +0800 From: Wong Vee Khee To: Andrew Lunn Cc: Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S . Miller" , Jakub Kicinski , Maxime Coquelin , Voon Weifeng , Ong Boon Leong , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 1/1] net: stmmac: Add support for external trigger timestamping Message-ID: <20210407165407.GA27820@linux.intel.com> References: <20210407141537.2129-1-vee.khee.wong@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210407_175416_379885_CABB17A9 X-CRM114-Status: GOOD ( 22.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Apr 07, 2021 at 04:21:09PM +0200, Andrew Lunn wrote: > On Wed, Apr 07, 2021 at 10:15:37PM +0800, Wong Vee Khee wrote: > > From: Tan Tee Min > > > > The Synopsis MAC controller supports auxiliary snapshot feature that > > allows user to store a snapshot of the system time based on an external > > event. > > > > This patch add supports to the above mentioned feature. Users will be > > able to triggered capturing the time snapshot from user-space using > > application such as testptp or any other applications that uses the > > PTP_EXTTS_REQUEST ioctl request. > > You forgot to Cc: the PTP maintainer. > Will Cc Richard Cochran on v2. > > @@ -159,6 +163,37 @@ static int stmmac_enable(struct ptp_clock_info *ptp, > > priv->systime_flags); > > spin_unlock_irqrestore(&priv->ptp_lock, flags); > > break; > > + case PTP_CLK_REQ_EXTTS: > > + priv->plat->ext_snapshot_en = on; > > + mutex_lock(&priv->aux_ts_lock); > > + acr_value = readl(ptpaddr + PTP_ACR); > > + acr_value &= ~PTP_ACR_MASK; > > + if (on) { > > + /* Enable External snapshot trigger */ > > + acr_value |= priv->plat->ext_snapshot_num; > > + acr_value |= PTP_ACR_ATSFC; > > + pr_info("Auxiliary Snapshot %d enabled.\n", > > + priv->plat->ext_snapshot_num >> > > + PTP_ACR_ATSEN_SHIFT); > > dev_dbg()? > > > + /* Enable Timestamp Interrupt */ > > + intr_value = readl(ioaddr + GMAC_INT_EN); > > + intr_value |= GMAC_INT_TSIE; > > + writel(intr_value, ioaddr + GMAC_INT_EN); > > + > > + } else { > > + pr_info("Auxiliary Snapshot %d disabled.\n", > > + priv->plat->ext_snapshot_num >> > > + PTP_ACR_ATSEN_SHIFT); > > dev_dbg()? > > Do you really want to spam the kernel log with this? > Thanks for the review. I will switch this to netdev_dbg(). _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel