From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF86AC433ED for ; Wed, 7 Apr 2021 17:02:01 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 42F9C61139 for ; Wed, 7 Apr 2021 17:02:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 42F9C61139 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=xL2qbdbH83if/I/0i4+6W9R1uiOCUvyUHC/ikU5W+IY=; b=RitVuWyPc1gAQIrBEO24JKnM/ Qf6CnLGBObXyCPelhzUdLa0cs3xizLWGY+Rkf+K554XAvn3hneK4LdOB07vtXAIRkk1isnzrE3D7F QX5ixxnqBARIvcJW/fPW/fcdbMMvl7wxVSyM9ycKT0kd2v8OOfaTFRNx11DkHnK9GZSNpmmXuE+oY qTGDPJIfUJXy4FfmhfWjLuViPO/o7djn7B3HGnQPANiU3iXWQfupIrbQ2+Mx+Izguilt+75LQGhc3 ro9mEP9tFmQ+76+9+ld6oUI00pnqGApP2UPFSgPic9rF6cf5IYIlqbug851MIQx7Lqn/4TLHb/2sP edphMxbmA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lUBWy-005XtY-N2; Wed, 07 Apr 2021 16:59:52 +0000 Received: from mail-pf1-x434.google.com ([2607:f8b0:4864:20::434]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lUBWt-005Xp6-GD for linux-arm-kernel@lists.infradead.org; Wed, 07 Apr 2021 16:59:49 +0000 Received: by mail-pf1-x434.google.com with SMTP id c17so13335288pfn.6 for ; Wed, 07 Apr 2021 09:59:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=eLTW/ZkkTyCTqB6iu1rtru6bTgFZgwWXKzMypqfmgqM=; b=CWft3GmsUrXx8JEx6CTw6lEYf09sLZpZHvKpi5RwVM/iZ5pPKg4uL3juo2C0uAPiGs TA5CMBZzMlayQY7L+nNPBBMQd/PD8K1YYNq4Yts/dPbs7lYkxlnTz67CxLJm03UE1lEU erOmFzKOHZsgZ0ON+xqljZ4OeKRESwnMbZFTq5jwS7LwGwA8ZZyuUr2i09LBqedcqxtw 4aKqK2hVH32npqBCmKhouZz3LXi3f0//zYnMkphkeXGn/k6XlFJyBA4JBBPUuKOZdMGW hnsHQAFc+vYkmh13vrhQDHrdyr15kXIt1RlbV4jhrk9iMhwq9Sy5oO224Bf5/BNbw4nP YnYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=eLTW/ZkkTyCTqB6iu1rtru6bTgFZgwWXKzMypqfmgqM=; b=q/C9sgB/kDSuG2V5eoGZMwhPgs/lCODLMWAnbcX8i0y+MkQj0bYKDWHCvlzkpnWLkE 25M7AntArm6X0zbFfQ0522AMUyBSiFUSFFJK1QcvTnpQmZb5I2AauaK2Sm3FsVo8k/v9 9phS69fssaI82R77bTOD4LzwwkwgOY62Na6SsYSk40dxgIZVtXBTEkqUCet21fqUig0h ddAJkYcw4TtDy/LMv9FLeh0z3prtLzQC6+IqC6fjjcY9iMKL4oiv0IvTsu7TRAssGbf6 nZhdboFSIMczOB3VvCAPWkHcMl5tVNhvcZm6amQNSeaXxf6xzAyEi61vy9WPDGeAyL3L c7dw== X-Gm-Message-State: AOAM530OcbMRIldEnClJeoE1abznJWh4BW32sitz7BdotxAPLzr/3Fuz l7CeDdAUGqxMYkBAY3GGtOrkew== X-Google-Smtp-Source: ABdhPJxlOKgAaT/UdnWkhWXesWaSW3c/InbpMcfAXw2FRlscSoekEPYJdP3Vry++OB5sfM4mN3m1Sg== X-Received: by 2002:a63:e242:: with SMTP id y2mr4342156pgj.298.1617814785732; Wed, 07 Apr 2021 09:59:45 -0700 (PDT) Received: from xps15 (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id j22sm5701327pjz.3.2021.04.07.09.59.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Apr 2021 09:59:45 -0700 (PDT) Date: Wed, 7 Apr 2021 10:59:43 -0600 From: Mathieu Poirier To: peng.fan@oss.nxp.com Cc: ohad@wizery.com, bjorn.andersson@linaro.org, o.rempel@pengutronix.de, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-remoteproc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan Subject: Re: [PATCH V2 3/4] remoteproc: imx: move memory parsing to rproc_ops Message-ID: <20210407165943.GE418374@xps15> References: <1617082235-15923-1-git-send-email-peng.fan@oss.nxp.com> <1617082235-15923-4-git-send-email-peng.fan@oss.nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1617082235-15923-4-git-send-email-peng.fan@oss.nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210407_175947_576270_9E6757DA X-CRM114-Status: GOOD ( 18.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Mar 30, 2021 at 01:30:34PM +0800, peng.fan@oss.nxp.com wrote: > From: Peng Fan > > Use the rproc_ops::prepare() hook for doing memory resources > reallocation when reattach an remote procesor. s/when reattach an remote/when reattaching a remote/ > > Suggested-by: Mathieu Poirier > Signed-off-by: Peng Fan > --- > drivers/remoteproc/imx_rproc.c | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c > index b05aae0ad7a2..7cd09971d1a4 100644 > --- a/drivers/remoteproc/imx_rproc.c > +++ b/drivers/remoteproc/imx_rproc.c > @@ -317,7 +317,7 @@ static int imx_rproc_mem_release(struct rproc *rproc, > return 0; > } > > -static int imx_rproc_parse_memory_regions(struct rproc *rproc) > +static int imx_rproc_prepare(struct rproc *rproc) > { > struct imx_rproc *priv = rproc->priv; > struct device_node *np = priv->dev->of_node; > @@ -363,10 +363,7 @@ static int imx_rproc_parse_memory_regions(struct rproc *rproc) > > static int imx_rproc_parse_fw(struct rproc *rproc, const struct firmware *fw) > { > - int ret = imx_rproc_parse_memory_regions(rproc); > - > - if (ret) > - return ret; > + int ret; > > ret = rproc_elf_load_rsc_table(rproc, fw); > if (ret) > @@ -399,6 +396,7 @@ static void imx_rproc_kick(struct rproc *rproc, int vqid) > } > > static const struct rproc_ops imx_rproc_ops = { > + .prepare = imx_rproc_prepare, > .start = imx_rproc_start, > .stop = imx_rproc_stop, > .kick = imx_rproc_kick, > -- > 2.30.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel