Re: [PATCH] KVM: arm64: Clarify vcpu reset behaviour

From: Will Deacon <will@kernel.org>
To: Marc Zyngier <maz@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org, kernel-team@android.com,
	ascull@google.com, tabba@google.com, dbrazdil@google.com,
	James Morse <james.morse@arm.com>,
	Suzuki K Poulose <suzuki.poulose@arm.com>,
	Alexandru Elisei <alexandru.elisei@arm.com>
Subject: Re: [PATCH] KVM: arm64: Clarify vcpu reset behaviour
Date: Wed, 7 Apr 2021 21:35:37 +0100	[thread overview]
Message-ID: <20210407203537.GA16011@willie-the-truck> (raw)
In-Reply-To: <20210406125841.1077079-1-maz@kernel.org>

On Tue, Apr 06, 2021 at 01:58:41PM +0100, Marc Zyngier wrote:
> Although the KVM_ARM_VCPU_INIT documentation mention that the
> registers are reset to their "initial values", it doesn't
> describe what these values are.
> 
> Describe this state explicitly.
> 
> Signed-off-by: Marc Zyngier <maz@kernel.org>
> ---
>  Documentation/virt/kvm/api.rst | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/Documentation/virt/kvm/api.rst b/Documentation/virt/kvm/api.rst
> index 38e327d4b479..e2237e4e10ba 100644
> --- a/Documentation/virt/kvm/api.rst
> +++ b/Documentation/virt/kvm/api.rst
> @@ -3115,6 +3115,16 @@ optional features it should have.  This will cause a reset of the cpu
>  registers to their initial values.  If this is not called, KVM_RUN will
>  return ENOEXEC for that vcpu.
>  
> +The initial values are defined as:
> +	- Processor state:
> +		* AArch64: EL1h, D, A, I and F bits set
> +		* Aarch32: SVC, D, A, I and F bits set

nit, but capitalisation should be "AArch32"

Is "SVC" sufficient, or do we also need to describe Arm vs Thumb?

Will

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel