From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46841C433ED for ; Thu, 8 Apr 2021 08:01:44 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C9C9761155 for ; Thu, 8 Apr 2021 08:01:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C9C9761155 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=vKvR1rIMtR42kE/SAKuqtmbfcqEXd7bXg6YP7YFNvFQ=; b=KDE2qP8PgrjzcChE8N3MIerB9 kOd83uihuzRBirh4Z1p2/oTjxQ5dKPeNb/jUD8rX1sF8ISg5FLcfb87C5CIXcyXycr3XycvhgelYJ 6pCkHhApfijl785fMPqPhy7XwoWU+dd2XiADb18Jm2dMEibuWtHsMGNE43m8HfPKl3IylFD0+DfrF GYp4NNB6jBy89ai777C/MWxdjdIOOVC3I4GtsmEwJvCGsHeFDYMVG2Osg35UhgqjywXq2qcH1DKjR YRIlTNLo1zwkF43WX53f1RjA8TgZml5sWv9P8V8yU7mnzeziZDHxGqCPdG97MmGePTvYF0p+wQ3pl XFDNX+kcw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lUPZn-007I4n-QQ; Thu, 08 Apr 2021 07:59:44 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lUPZg-007I36-OR for linux-arm-kernel@lists.infradead.org; Thu, 08 Apr 2021 07:59:39 +0000 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lUPZU-0002a4-DU; Thu, 08 Apr 2021 09:59:24 +0200 Received: from ukl by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1lUPZQ-0005CS-Vf; Thu, 08 Apr 2021 09:59:20 +0200 Date: Thu, 8 Apr 2021 09:59:20 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Nobuhiro Iwamatsu Cc: linux-pwm@vger.kernel.org, punit1.agrawal@toshiba.co.jp, devicetree@vger.kernel.org, yuji2.ishikawa@toshiba.co.jp, linux-kernel@vger.kernel.org, Rob Herring , Thierry Reding , kernel@pengutronix.de, Lee Jones , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 2/2] pwm: visconti: Add Toshiba Visconti SoC PWM support Message-ID: <20210408075920.rfrcqxec2yvepj3y@pengutronix.de> References: <20210212131910.557581-1-nobuhiro1.iwamatsu@toshiba.co.jp> <20210212131910.557581-3-nobuhiro1.iwamatsu@toshiba.co.jp> <20210212164144.wcvy7jkxmrysqxux@pengutronix.de> <20210407231548.4paov2fb33cpxxui@toshiba.co.jp> MIME-Version: 1.0 In-Reply-To: <20210407231548.4paov2fb33cpxxui@toshiba.co.jp> X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210408_085937_068300_9C060BE6 X-CRM114-Status: GOOD ( 24.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============4750650333572532779==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============4750650333572532779== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="geu5564gy6ryykgp" Content-Disposition: inline --geu5564gy6ryykgp Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hello Nobuhiro, On Thu, Apr 08, 2021 at 08:15:48AM +0900, Nobuhiro Iwamatsu wrote: > > > + /* > > > + * pwmc is a 2-bit divider for the input clock running at 1 MHz. > > > + * When the settings of the PWM are modified, the new values are sh= adowed in hardware until > > > + * the period register (PCSR) is written and the currently running = period is completed. This > > > + * way the hardware switches atomically from the old setting to the= new. > > > + * Also, disabling the hardware completes the currently running per= iod and keeps the output > > > + * at low level at all times. > >=20 > > Did you just copy my optimal description or is your hardware really that > > nice? >=20 > Yes, this hardware works as you wrote. > And I added about the state if the sinnal when this hardware disabled. >=20 > >=20 > > Do you know scripts/checkpatch.pl? I bet it will tell you to limit your > > lines to approx. 80 chars where sensible. >=20 > Yes, I know. I ran scripts/checkpatch.pl before send patch. > I understand that the number of characters per line has been changed to > 100 characters. Does the pwm driver recommend 80 characters? For free-text comments I'd still recommend 80, yes. For code lines I'd be indeed more lax, as a line break in function calls reduces readability. Best regards Uwe --=20 Pengutronix e.K. | Uwe Kleine-K=F6nig | Industrial Linux Solutions | https://www.pengutronix.de/ | --geu5564gy6ryykgp Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAmBut9MACgkQwfwUeK3K 7AlwEwf+LOf+gfIUqpelOcF+8SK6n10H1NShUmwZh32SQfCI6WR7zeuehzeR3f2r ujKiNUDTbhTyqUUV8FKZL0ezCJkW8LGiVMzMLnmS3xJkfPkLzaiJfRwtRksWJlRU KIyrRmN2c2sQsEBqZNX++V1QYjorEMAieBJfq442oePYvToBW1EsIXC+/FZ2SNec mZfVX6SqYvMCHZ5hLxIveAhseJ+LE+QRwQNoWQNanYPRlXf2QfN4H6GLQXTqNyw/ BxGNekeiyyXlUPovaHgdiCYiph6t4AqhPq0q9AG/kSjGeQDyhmWnxSjRtUHs1li4 mr2MPB0qxKRjT5876znW5v2bOWw/9g== =aMAV -----END PGP SIGNATURE----- --geu5564gy6ryykgp-- --===============4750650333572532779== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============4750650333572532779==--