From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E58AC433ED for ; Thu, 8 Apr 2021 10:55:37 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A1F37610A2 for ; Thu, 8 Apr 2021 10:55:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A1F37610A2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=p00BZ6YwYX9UGum5kgiUHS1uqUoLjtJxyxbZ+WPxYAo=; b=bIHscjGj775wVKEHSmUXPlOyq YHohH61RZ7RYBgFFsrImAxdxhszDeskUhDXJGM9J+S7MZjxkp+zVvCIqT25vs/7pE9DQyzRcqNS9W YHqzmKqbHC5I3eycYeUpGhMoZFBDkDBABM+cvuIPDbYsOAJ0OiEYxYWe5NhL6QWa1npu8pPkpKJxK NoVxOIPmIAVi3g+Ef1o1ruKh9pYn3aZdi3kPZNcg95UHiTTRgzlCDifxqHr2OAR+7VFBG3zUxnnt8 O5RQpcFCjxz0XolAhvHjxlBcVGDpo5rZ/mFqckt6H7NrwlPLaLaAs1qm9N0rbvn3vRuKrGokaeBqC UG2yoPS7g==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lUSIF-007iHD-D8; Thu, 08 Apr 2021 10:53:48 +0000 Received: from mail.kernel.org ([198.145.29.99]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lUSI9-007iGF-NG for linux-arm-kernel@lists.infradead.org; Thu, 08 Apr 2021 10:53:44 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 9A35F610A2; Thu, 8 Apr 2021 10:53:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1617879220; bh=uNX7EzB95tkTpbJCKS+CuK7rA8/DTTMFGTEFrHmBPKE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Tj5pTOlvmPxq8dAGRtkLsQlngAiYyBUnZ/chq7XzmSGVXcCVxcQiJ+OEvHt3Dm322 bp0/NR/8hK5S9gUHGoH78VG8kOuPw6YFTSAvPE2EhIRWeuoQRNSt3GyF9PGv9SB9X6 KlrTGpCM8zgY3FaaeHUPyjeFBgUh4MhVYNB/JpI1hOwPPEvilydx19Ehvmg7hod73W nkigQ9+yjt1Uym0v1NHUEo2/RdSNVSvViK5uLHP28WIYULVSTpg8tguJlpkw41uq2j TlxpGVir8JpshdcPqlYd4qBSbz41vwllddY4ANC804c0xpwBwjxrCBHMs23cGSJ9S/ xvBcbsVOBUIBA== Date: Thu, 8 Apr 2021 11:53:35 +0100 From: Will Deacon To: Marc Zyngier Cc: linux-arm-kernel@lists.infradead.org, kernel-team@android.com, ascull@google.com, tabba@google.com, dbrazdil@google.com, James Morse , Suzuki K Poulose , Alexandru Elisei Subject: Re: [PATCH] KVM: arm64: Clarify vcpu reset behaviour Message-ID: <20210408105334.GA17280@willie-the-truck> References: <20210406125841.1077079-1-maz@kernel.org> <20210407203537.GA16011@willie-the-truck> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210408_115343_196215_C14ACBC5 X-CRM114-Status: GOOD ( 23.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Apr 08, 2021 at 11:36:34AM +0100, Marc Zyngier wrote: > On 2021-04-07 21:35, Will Deacon wrote: > > On Tue, Apr 06, 2021 at 01:58:41PM +0100, Marc Zyngier wrote: > > > Although the KVM_ARM_VCPU_INIT documentation mention that the > > > registers are reset to their "initial values", it doesn't > > > describe what these values are. > > > = > > > Describe this state explicitly. > > > = > > > Signed-off-by: Marc Zyngier > > > --- > > > Documentation/virt/kvm/api.rst | 10 ++++++++++ > > > 1 file changed, 10 insertions(+) > > > = > > > diff --git a/Documentation/virt/kvm/api.rst > > > b/Documentation/virt/kvm/api.rst > > > index 38e327d4b479..e2237e4e10ba 100644 > > > --- a/Documentation/virt/kvm/api.rst > > > +++ b/Documentation/virt/kvm/api.rst > > > @@ -3115,6 +3115,16 @@ optional features it should have. =A0This will > > > cause a reset of the cpu > > > registers to their initial values. =A0If this is not called, KVM_RUN > > > will > > > return ENOEXEC for that vcpu. > > > = > > > +The initial values are defined as: > > > + - Processor state: > > > + * AArch64: EL1h, D, A, I and F bits set > > > + * Aarch32: SVC, D, A, I and F bits set > > = > > nit, but capitalisation should be "AArch32" > > = > > Is "SVC" sufficient, or do we also need to describe Arm vs Thumb? > = > SVC doesn't describe the instruction set, but we don't say that PSR.T > is set, which implies ARM. Ah yes, thanks. > I can add something like "All other bits are set to 0", if that makes it > clearer. I think that would be worth adding. With that and the minor typo fix: Acked-by: Will Deacon Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel