From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50A63C433B4 for ; Fri, 9 Apr 2021 09:41:09 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D877461106 for ; Fri, 9 Apr 2021 09:41:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D877461106 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:CC:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=okgO2HWGTITRu/U8r8kveN972gIp2GLj40MJ/1Ns8Nc=; b=UpJl4YJQ8igfbfVmHUc2beGs4w rGNIN9PcJiYrwt1GhatbLd21vJA2IGOB7L+vgjF/eqcdVoS0suNWO14hg1scio4koXYeQAyt3N83T CPuCNXjBRhuZncSmvZ0y+Njc6VIOS04OF+E5T4K1Y1jazzLS4cAEJ7/G4c8BP0u/pCYu7oxaRC2jG tgeNSE8wgWCUEbtpCTD0/AAS5LD0su0ea1f16s8JyHCOMkbLEtk2XAKl5yIy6xY4f0Ho6qLljEOSr oxYlXhYutNv2ryvtcIh4RcPrnAnhPqZ/S5KEYSq76H0B+MALvNS4Rlfs/8pK6sa4Vzaf6WTgXbtmn J+FIjUOg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lUnc1-000HQy-Eq; Fri, 09 Apr 2021 09:39:37 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lUnbk-000HLW-Ae for linux-arm-kernel@desiato.infradead.org; Fri, 09 Apr 2021 09:39:22 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:MIME-Version:Message-ID:Date:Subject:CC:To:From:Sender:Reply-To: Content-ID:Content-Description:In-Reply-To:References; bh=+6bVO7bP23eikkod8H8iOkEFC3n8OaRkB0YX35ntp1U=; b=cviehoGDUdWsW4DC8qULdDIw2Q kH2nEqHE3Q3WMujtSPXwc9y5I55nL2OrNH5FCAL8TrIdMIWCSn2jw1O4YXdq6tk69JC3POrRYnWSR IDOtGMHoIHiJcrKX1g0J5Po3VEgqRfe76bqyJRusfLPSnsA33CujHjy2uz2+r+gyq1O5G/25mlWrI FZ8HfnAd+C+S35E4VNiSfn1WfglYPOqbmLd2qrXFoDLb+NZZ92PjjF8VCqnL7MXw+Y5+eCDJ0RAcE 3R/Z9vPe7wXWk1I/x/Vu1uTDJIR5kGLfy0N+74efnXYaiWUp0GHF7g0+Fnj+7cAT3y9BuIoCI0a44 fq1BUy7w==; Received: from szxga04-in.huawei.com ([45.249.212.190]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lUnbh-0042tS-E8 for linux-arm-kernel@lists.infradead.org; Fri, 09 Apr 2021 09:39:18 +0000 Received: from DGGEMS414-HUB.china.huawei.com (unknown [172.30.72.60]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4FGtLC5sy6zpWq1; Fri, 9 Apr 2021 17:36:19 +0800 (CST) Received: from localhost.localdomain (10.175.102.38) by DGGEMS414-HUB.china.huawei.com (10.3.19.214) with Microsoft SMTP Server id 14.3.498.0; Fri, 9 Apr 2021 17:38:57 +0800 From: Wei Yongjun To: , Anshuman Khandual , Mathieu Poirier , Suzuki K Poulose , Alexander Shishkin CC: , , , , Hulk Robot Subject: [PATCH -next v2] coresight: trbe: Fix return value check in arm_trbe_register_coresight_cpu() Date: Fri, 9 Apr 2021 09:49:01 +0000 Message-ID: <20210409094901.1903622-1-weiyongjun1@huawei.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Originating-IP: [10.175.102.38] X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210409_023917_667123_0A5EE124 X-CRM114-Status: GOOD ( 10.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org In case of error, the function devm_kasprintf() returns NULL pointer not ERR_PTR(). The IS_ERR() test in the return value check should be replaced with NULL test. Reported-by: Hulk Robot Signed-off-by: Wei Yongjun --- v1 -> v2: remove fixes tag. --- drivers/hwtracing/coresight/coresight-trbe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hwtracing/coresight/coresight-trbe.c b/drivers/hwtracing/coresight/coresight-trbe.c index 5ce239875c98..176868496879 100644 --- a/drivers/hwtracing/coresight/coresight-trbe.c +++ b/drivers/hwtracing/coresight/coresight-trbe.c @@ -871,7 +871,7 @@ static void arm_trbe_register_coresight_cpu(struct trbe_drvdata *drvdata, int cp dev = &cpudata->drvdata->pdev->dev; desc.name = devm_kasprintf(dev, GFP_KERNEL, "trbe%d", cpu); - if (IS_ERR(desc.name)) + if (!desc.name) goto cpu_clear; desc.type = CORESIGHT_DEV_TYPE_SINK; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel